Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Jul 2021 11:17:06 -0700
From:   mark gross <mgross@linux.intel.com>
To:     markgross@kernel.org, mgross@linux.intel.com, arnd@arndb.de,
        bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
        gregkh@linuxfoundation.org, corbet@lwn.net,
        palmerdabbelt@google.com, paul.walmsley@sifive.com,
        peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org,
        jassisinghbrar@gmail.com
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 00/34] Intel Vision Processing base enabling
Message-ID: <20210709181706.GA44982@linux.intel.com>
Reply-To: mgross@linux.intel.com
References: <20210212222304.110194-1-mgross@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210212222304.110194-1-mgross@linux.intel.com>
Precedence: bulk

I want to thank you for all the work and feedback given reviewing these series
of patches.  Our upstream strategy for the VPU enabling has changed and we are
regrouping and redesigning this stack in a significant way.

To avoid legacy ABI compatibility issues with the redesigned stack we are
dropping this set of patches.  Other KMB changes, that are not VPU related,
will continue to be up streamed.

Thanks again for all the valuable feedback and lessons given through the
reviews.

--mark

On Fri, Feb 12, 2021 at 02:22:30PM -0800, mgross@linux.intel.com wrote:
> From: Mark Gross <mgross@linux.intel.com>
> 
> The Intel Vision Processing Unit (VPU) is an IP block that is showing up for
> the first time as part of the Keem Bay SOC.  Keem Bay is a quad core A53 Arm
> SOC.  It is designed to be used as a stand alone SOC as well as in an PCIe
> Vision Processing accelerator add in card.
> 
> This 6th version of this patch set includes more updates to the xlink SMBUS
> patch correction some language in its Kconfig file.
> 
> At the bottom of this cover letter is the delta between v5 and this version for
> easy review of the modifications.
> 
> Thanks for looking at these and providing feedback.
> 
> 
> C, Udhayakumar (8):
>   dt-bindings: misc: intel_tsens: Add tsens thermal bindings
>     documentation
>   misc: Tsens ARM host thermal driver.
>   misc: Intel tsens IA host driver.
>   Intel tsens i2c slave driver.
>   misc:intel_tsens: Intel Keem Bay tsens driver.
>   dt-bindings: misc: hddl_dev: Add hddl device management documentation
>   misc: Hddl device management for local host
>   misc: HDDL device management for IA host
> 
> Daniele Alessandrelli (4):
>   dt-bindings: mailbox: Add Intel VPU IPC mailbox bindings
>   mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox
>   dt-bindings: Add bindings for Keem Bay IPC driver
>   keembay-ipc: Add Keem Bay IPC module
> 
> Li, Tingqian (2):
>   dt-bindings: misc: Add Keem Bay vpumgr
>   misc: Add Keem Bay VPU manager
> 
> Paul Murphy (2):
>   dt-bindings: Add bindings for Keem Bay VPU IPC driver
>   keembay-vpu-ipc: Add Keem Bay VPU IPC module
> 
> Ramya P Karanth (1):
>   Intel Keembay XLink SMBus driver
> 
> Seamus Kelly (7):
>   xlink-ipc: Add xlink ipc device tree bindings
>   xlink-ipc: Add xlink ipc driver
>   xlink-core: Add xlink core device tree bindings
>   xlink-core: Add xlink core driver xLink
>   xlink-core: Enable xlink protocol over pcie
>   xlink-core: Enable VPU IP management and runtime control
>   xlink-core: add async channel and events
> 
> Srikanth Thokala (9):
>   misc: xlink-pcie: Add documentation for XLink PCIe driver
>   misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host
>   misc: xlink-pcie: lh: Add PCIe EP DMA functionality
>   misc: xlink-pcie: lh: Add core communication logic
>   misc: xlink-pcie: lh: Prepare changes for adding remote host driver
>   misc: xlink-pcie: rh: Add PCIe EP driver for Remote Host
>   misc: xlink-pcie: rh: Add core communication logic
>   misc: xlink-pcie: Add XLink API interface
>   misc: xlink-pcie: Add asynchronous event notification support for
>     XLink
> 
> mark gross (1):
>   Add Vision Processing Unit (VPU) documentation.
> 
>  .../mailbox/intel,vpu-ipc-mailbox.yaml        |   69 +
>  .../bindings/misc/intel,hddl-client.yaml      |  117 +
>  .../bindings/misc/intel,intel-tsens.yaml      |  122 +
>  .../bindings/misc/intel,keembay-vpu-mgr.yaml  |   48 +
>  .../misc/intel,keembay-xlink-ipc.yaml         |   51 +
>  .../bindings/misc/intel,keembay-xlink.yaml    |   29 +
>  .../bindings/soc/intel/intel,keembay-ipc.yaml |   45 +
>  .../soc/intel/intel,keembay-vpu-ipc.yaml      |  143 ++
>  Documentation/hwmon/index.rst                 |    2 +
>  Documentation/hwmon/intel_tsens_host.rst      |   71 +
>  Documentation/hwmon/intel_tsens_sensor.rst    |   67 +
>  Documentation/i2c/busses/index.rst            |    1 +
>  .../i2c/busses/intel-xlink-smbus.rst          |   71 +
>  Documentation/index.rst                       |    1 +
>  .../misc-devices/hddl_device_client.rst       |  212 ++
>  .../misc-devices/hddl_device_server.rst       |  205 ++
>  Documentation/misc-devices/index.rst          |    2 +
>  Documentation/vpu/index.rst                   |   20 +
>  Documentation/vpu/vpu-stack-overview.rst      |  270 +++
>  Documentation/vpu/xlink-core.rst              |   81 +
>  Documentation/vpu/xlink-ipc.rst               |   51 +
>  Documentation/vpu/xlink-pcie.rst              |   90 +
>  MAINTAINERS                                   |   54 +
>  drivers/mailbox/Kconfig                       |   11 +
>  drivers/mailbox/Makefile                      |    2 +
>  drivers/mailbox/vpu-ipc-mailbox.c             |  297 +++
>  drivers/misc/Kconfig                          |    7 +
>  drivers/misc/Makefile                         |    7 +
>  drivers/misc/hddl_device/Kconfig              |   26 +
>  drivers/misc/hddl_device/Makefile             |    7 +
>  drivers/misc/hddl_device/hddl_device.c        |  565 +++++
>  drivers/misc/hddl_device/hddl_device_lh.c     |  764 +++++++
>  drivers/misc/hddl_device/hddl_device_rh.c     |  837 +++++++
>  drivers/misc/hddl_device/hddl_device_util.h   |   52 +
>  drivers/misc/intel_tsens/Kconfig              |   54 +
>  drivers/misc/intel_tsens/Makefile             |   10 +
>  drivers/misc/intel_tsens/intel_tsens_host.c   |  352 +++
>  drivers/misc/intel_tsens/intel_tsens_i2c.c    |  119 +
>  .../misc/intel_tsens/intel_tsens_thermal.c    |  651 ++++++
>  .../misc/intel_tsens/intel_tsens_thermal.h    |   38 +
>  drivers/misc/intel_tsens/keembay_thermal.c    |  169 ++
>  drivers/misc/intel_tsens/keembay_tsens.h      |  366 +++
>  drivers/misc/vpumgr/Kconfig                   |    9 +
>  drivers/misc/vpumgr/Makefile                  |    3 +
>  drivers/misc/vpumgr/vpu_common.h              |   31 +
>  drivers/misc/vpumgr/vpu_mgr.c                 |  370 +++
>  drivers/misc/vpumgr/vpu_smm.c                 |  554 +++++
>  drivers/misc/vpumgr/vpu_smm.h                 |   30 +
>  drivers/misc/vpumgr/vpu_vcm.c                 |  584 +++++
>  drivers/misc/vpumgr/vpu_vcm.h                 |   84 +
>  drivers/misc/xlink-core/Kconfig               |   33 +
>  drivers/misc/xlink-core/Makefile              |    5 +
>  drivers/misc/xlink-core/xlink-core.c          | 1331 +++++++++++
>  drivers/misc/xlink-core/xlink-core.h          |   25 +
>  drivers/misc/xlink-core/xlink-defs.h          |  181 ++
>  drivers/misc/xlink-core/xlink-dispatcher.c    |  436 ++++
>  drivers/misc/xlink-core/xlink-dispatcher.h    |   26 +
>  drivers/misc/xlink-core/xlink-ioctl.c         |  554 +++++
>  drivers/misc/xlink-core/xlink-ioctl.h         |   36 +
>  drivers/misc/xlink-core/xlink-multiplexer.c   | 1164 ++++++++++
>  drivers/misc/xlink-core/xlink-multiplexer.h   |   35 +
>  drivers/misc/xlink-core/xlink-platform.c      |  273 +++
>  drivers/misc/xlink-core/xlink-platform.h      |   65 +
>  drivers/misc/xlink-ipc/Kconfig                |    7 +
>  drivers/misc/xlink-ipc/Makefile               |    4 +
>  drivers/misc/xlink-ipc/xlink-ipc.c            |  878 +++++++
>  drivers/misc/xlink-pcie/Kconfig               |   20 +
>  drivers/misc/xlink-pcie/Makefile              |    2 +
>  drivers/misc/xlink-pcie/common/core.h         |  245 ++
>  drivers/misc/xlink-pcie/common/interface.c    |  124 +
>  drivers/misc/xlink-pcie/common/util.c         |  373 +++
>  drivers/misc/xlink-pcie/common/util.h         |   68 +
>  drivers/misc/xlink-pcie/common/xpcie.h        |  100 +
>  drivers/misc/xlink-pcie/local_host/Makefile   |    6 +
>  drivers/misc/xlink-pcie/local_host/core.c     |  817 +++++++
>  drivers/misc/xlink-pcie/local_host/dma.c      |  575 +++++
>  drivers/misc/xlink-pcie/local_host/epf.c      |  482 ++++
>  drivers/misc/xlink-pcie/local_host/epf.h      |  101 +
>  drivers/misc/xlink-pcie/remote_host/Makefile  |    6 +
>  drivers/misc/xlink-pcie/remote_host/core.c    |  621 +++++
>  drivers/misc/xlink-pcie/remote_host/main.c    |   93 +
>  drivers/misc/xlink-pcie/remote_host/pci.c     |  523 +++++
>  drivers/misc/xlink-pcie/remote_host/pci.h     |   65 +
>  drivers/misc/xlink-smbus/Kconfig              |   25 +
>  drivers/misc/xlink-smbus/Makefile             |    5 +
>  drivers/misc/xlink-smbus/xlink-smbus.c        |  467 ++++
>  drivers/soc/Kconfig                           |    1 +
>  drivers/soc/Makefile                          |    1 +
>  drivers/soc/intel/Kconfig                     |   33 +
>  drivers/soc/intel/Makefile                    |    5 +
>  drivers/soc/intel/keembay-ipc.c               | 1364 +++++++++++
>  drivers/soc/intel/keembay-vpu-ipc.c           | 2026 +++++++++++++++++
>  include/linux/hddl_device.h                   |  153 ++
>  include/linux/intel_tsens_host.h              |   34 +
>  include/linux/soc/intel/keembay-ipc.h         |   30 +
>  include/linux/soc/intel/keembay-vpu-ipc.h     |   62 +
>  include/linux/xlink-ipc.h                     |   48 +
>  include/linux/xlink.h                         |  146 ++
>  include/linux/xlink_drv_inf.h                 |   70 +
>  include/uapi/misc/vpumgr.h                    |   64 +
>  include/uapi/misc/xlink_uapi.h                |  145 ++
>  101 files changed, 21774 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,hddl-client.yaml
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-vpu-mgr.yaml
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink-ipc.yaml
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/intel/intel,keembay-ipc.yaml
>  create mode 100644 Documentation/devicetree/bindings/soc/intel/intel,keembay-vpu-ipc.yaml
>  create mode 100644 Documentation/hwmon/intel_tsens_host.rst
>  create mode 100644 Documentation/hwmon/intel_tsens_sensor.rst
>  create mode 100644 Documentation/i2c/busses/intel-xlink-smbus.rst
>  create mode 100644 Documentation/misc-devices/hddl_device_client.rst
>  create mode 100644 Documentation/misc-devices/hddl_device_server.rst
>  create mode 100644 Documentation/vpu/index.rst
>  create mode 100644 Documentation/vpu/vpu-stack-overview.rst
>  create mode 100644 Documentation/vpu/xlink-core.rst
>  create mode 100644 Documentation/vpu/xlink-ipc.rst
>  create mode 100644 Documentation/vpu/xlink-pcie.rst
>  create mode 100644 drivers/mailbox/vpu-ipc-mailbox.c
>  create mode 100644 drivers/misc/hddl_device/Kconfig
>  create mode 100644 drivers/misc/hddl_device/Makefile
>  create mode 100644 drivers/misc/hddl_device/hddl_device.c
>  create mode 100644 drivers/misc/hddl_device/hddl_device_lh.c
>  create mode 100644 drivers/misc/hddl_device/hddl_device_rh.c
>  create mode 100644 drivers/misc/hddl_device/hddl_device_util.h
>  create mode 100644 drivers/misc/intel_tsens/Kconfig
>  create mode 100644 drivers/misc/intel_tsens/Makefile
>  create mode 100644 drivers/misc/intel_tsens/intel_tsens_host.c
>  create mode 100644 drivers/misc/intel_tsens/intel_tsens_i2c.c
>  create mode 100644 drivers/misc/intel_tsens/intel_tsens_thermal.c
>  create mode 100644 drivers/misc/intel_tsens/intel_tsens_thermal.h
>  create mode 100644 drivers/misc/intel_tsens/keembay_thermal.c
>  create mode 100644 drivers/misc/intel_tsens/keembay_tsens.h
>  create mode 100644 drivers/misc/vpumgr/Kconfig
>  create mode 100644 drivers/misc/vpumgr/Makefile
>  create mode 100644 drivers/misc/vpumgr/vpu_common.h
>  create mode 100644 drivers/misc/vpumgr/vpu_mgr.c
>  create mode 100644 drivers/misc/vpumgr/vpu_smm.c
>  create mode 100644 drivers/misc/vpumgr/vpu_smm.h
>  create mode 100644 drivers/misc/vpumgr/vpu_vcm.c
>  create mode 100644 drivers/misc/vpumgr/vpu_vcm.h
>  create mode 100644 drivers/misc/xlink-core/Kconfig
>  create mode 100644 drivers/misc/xlink-core/Makefile
>  create mode 100644 drivers/misc/xlink-core/xlink-core.c
>  create mode 100644 drivers/misc/xlink-core/xlink-core.h
>  create mode 100644 drivers/misc/xlink-core/xlink-defs.h
>  create mode 100644 drivers/misc/xlink-core/xlink-dispatcher.c
>  create mode 100644 drivers/misc/xlink-core/xlink-dispatcher.h
>  create mode 100644 drivers/misc/xlink-core/xlink-ioctl.c
>  create mode 100644 drivers/misc/xlink-core/xlink-ioctl.h
>  create mode 100644 drivers/misc/xlink-core/xlink-multiplexer.c
>  create mode 100644 drivers/misc/xlink-core/xlink-multiplexer.h
>  create mode 100644 drivers/misc/xlink-core/xlink-platform.c
>  create mode 100644 drivers/misc/xlink-core/xlink-platform.h
>  create mode 100644 drivers/misc/xlink-ipc/Kconfig
>  create mode 100644 drivers/misc/xlink-ipc/Makefile
>  create mode 100644 drivers/misc/xlink-ipc/xlink-ipc.c
>  create mode 100644 drivers/misc/xlink-pcie/Kconfig
>  create mode 100644 drivers/misc/xlink-pcie/Makefile
>  create mode 100644 drivers/misc/xlink-pcie/common/core.h
>  create mode 100644 drivers/misc/xlink-pcie/common/interface.c
>  create mode 100644 drivers/misc/xlink-pcie/common/util.c
>  create mode 100644 drivers/misc/xlink-pcie/common/util.h
>  create mode 100644 drivers/misc/xlink-pcie/common/xpcie.h
>  create mode 100644 drivers/misc/xlink-pcie/local_host/Makefile
>  create mode 100644 drivers/misc/xlink-pcie/local_host/core.c
>  create mode 100644 drivers/misc/xlink-pcie/local_host/dma.c
>  create mode 100644 drivers/misc/xlink-pcie/local_host/epf.c
>  create mode 100644 drivers/misc/xlink-pcie/local_host/epf.h
>  create mode 100644 drivers/misc/xlink-pcie/remote_host/Makefile
>  create mode 100644 drivers/misc/xlink-pcie/remote_host/core.c
>  create mode 100644 drivers/misc/xlink-pcie/remote_host/main.c
>  create mode 100644 drivers/misc/xlink-pcie/remote_host/pci.c
>  create mode 100644 drivers/misc/xlink-pcie/remote_host/pci.h
>  create mode 100644 drivers/misc/xlink-smbus/Kconfig
>  create mode 100644 drivers/misc/xlink-smbus/Makefile
>  create mode 100644 drivers/misc/xlink-smbus/xlink-smbus.c
>  create mode 100644 drivers/soc/intel/Kconfig
>  create mode 100644 drivers/soc/intel/Makefile
>  create mode 100644 drivers/soc/intel/keembay-ipc.c
>  create mode 100644 drivers/soc/intel/keembay-vpu-ipc.c
>  create mode 100644 include/linux/hddl_device.h
>  create mode 100644 include/linux/intel_tsens_host.h
>  create mode 100644 include/linux/soc/intel/keembay-ipc.h
>  create mode 100644 include/linux/soc/intel/keembay-vpu-ipc.h
>  create mode 100644 include/linux/xlink-ipc.h
>  create mode 100644 include/linux/xlink.h
>  create mode 100644 include/linux/xlink_drv_inf.h
>  create mode 100644 include/uapi/misc/vpumgr.h
>  create mode 100644 include/uapi/misc/xlink_uapi.h
> 
> -- 
> 2.17.1
> 
> diff --git a/drivers/misc/xlink-smbus/Kconfig b/drivers/misc/xlink-smbus/Kconfig
> index e6cdf8b9a096..8d2451f8d1be 100644
> --- a/drivers/misc/xlink-smbus/Kconfig
> +++ b/drivers/misc/xlink-smbus/Kconfig
> @@ -2,25 +2,24 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
>  config XLINK_SMBUS
> -	tristate "Enable smbus interface over Xlink PCIe"
> +	tristate "Enable SMBUS interface over Xlink PCIe"
>  	depends on XLINK_CORE
>  	depends on HDDL_DEVICE_CLIENT || HDDL_DEVICE_SERVER
>  	help
> -	 Enable xlink-pcie as i2c adapter both slave and master. The server
> -	 (Remote Host) will use this interface to get sensor data from the soc
> -	 (vision accelerator - Local Host) which is connected over PCIe.
> -	 This driver is loaded on both Remote Host and Local Host.
> -	 Select M to compile the driver as a module, name is xlink-smbus.
> -	 If unsure, select N.
> -
> +	  Enable xlink-pcie as I2C adapter both slave and master. The server
> +	  (Remote Host) will use this interface to get sensor data from the SoC
> +	  (vision accelerator - Local Host) which is connected over PCIe.
> +	  This driver is loaded on both Remote Host and Local Host.
> +	  Select M to compile the driver as a module, name is xlink-smbus.
> +	  If unsure, select N.
>  
>  config XLINK_SMBUS_PROXY
>  	tristate "Enable SMBUS adapter as proxy for I2C controller"
>  	depends on XLINK_CORE
>  	depends on XLINK_SMBUS
>  	help
> -	 Enable this config when SMBUS adapter is acting as proxy for
> -	 another I2C controller.
> -	 Select M or Y if building for Intel Vision Processing Unit (VPU)
> -	 Local Host core.
> -	 Select N, if building for a Remote Host kernel.
> +	  Enable this config when SMBUS adapter is acting as proxy for
> +	  another I2C controller.
> +	  Select M or Y if building for Intel Vision Processing Unit (VPU)
> +	  Local Host core.
> +	  Select N, if building for a Remote Host kernel.