Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162245AbWKPCp1 (ORCPT ); Wed, 15 Nov 2006 21:45:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1162242AbWKPCpK (ORCPT ); Wed, 15 Nov 2006 21:45:10 -0500 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:44175 "EHLO sous-sol.org") by vger.kernel.org with ESMTP id S1162234AbWKPCpE (ORCPT ); Wed, 15 Nov 2006 21:45:04 -0500 Message-Id: <20061116024544.195213000@sous-sol.org> References: <20061116024332.124753000@sous-sol.org> User-Agent: quilt/0.45-1 Date: Wed, 15 Nov 2006 18:43:42 -0800 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, Daniel Yeisley , Andi Kleen , Christoph Lameter , Pekka Enberg , Manfred Spraul Subject: [patch 10/30] init_reap_node() initialization fix Content-Disposition: inline; filename=init_reap_node-initialization-fix.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1464 Lines: 42 -stable review patch. If anyone has any objections, please let us know. ------------------ From: Daniel Yeisley It looks like there is a bug in init_reap_node() in slab.c that can cause multiple oops's on certain ES7000 configurations. The variable reap_node is defined per cpu, but only initialized on a single CPU. This causes an oops in next_reap_node() when __get_cpu_var(reap_node) returns the wrong value. Fix is below. Signed-off-by: Dan Yeisley Cc: Andi Kleen Acked-by: Christoph Lameter Cc: Pekka Enberg Cc: Manfred Spraul Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Chris Wright --- mm/slab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.18.2.orig/mm/slab.c +++ linux-2.6.18.2/mm/slab.c @@ -867,7 +867,7 @@ static void init_reap_node(int cpu) if (node == MAX_NUMNODES) node = first_node(node_online_map); - __get_cpu_var(reap_node) = node; + per_cpu(reap_node, cpu) = node; } static void next_reap_node(void) -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/