Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709180944.2533114-1-ztong0001@gmail.com>
In-Reply-To: <20210709180944.2533114-1-ztong0001@gmail.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Sat, 10 Jul 2021 06:04:00 +1000
Message-ID: <CAPM=9twS2B-bY8_AxB0mEVtr_2N3y3AyWjL2SNvOHA8tSMRSMQ@mail.gmail.com>
Subject: Re: [PATCH v1] fix vmwgfx compilation error due to a missing include
To:     Tong Zhang <ztong0001@gmail.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Roland Scheidegger <sroland@vmware.com>,
        Zack Rusin <zackr@vmware.com>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

cc'ing Christian to fix this I assume it was ttm refactor?

>
> This patch fixes vmwgfx driver compilation error due to a missing include
>
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function =E2=80=98vmw_vram_manage=
r_init=E2=80=99:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:678:8: error: implicit declaration of=
 function =E2=80=98ttm_range_man_init=E2=80=99 [-Werror=3Dimplicit-function=
-declaration]
>   678 |  ret =3D ttm_range_man_init(&dev_priv->bdev, TTM_PL_VRAM, false,
>       |        ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function =E2=80=98vmw_vram_manage=
r_fini=E2=80=99:
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:2: error: implicit declaration of=
 function =E2=80=98ttm_range_man_fini=E2=80=99 [-Werror=3Dimplicit-function=
-declaration]
>   690 |  ttm_range_man_fini(&dev_priv->bdev, TTM_PL_VRAM);
>       |  ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx=
/vmwgfx_drv.c
> index 6f5ea00973e0..6eb93aa2f311 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -37,6 +37,7 @@
>  #include <drm/drm_sysfs.h>
>  #include <drm/ttm/ttm_bo_driver.h>
>  #include <drm/ttm/ttm_placement.h>
> +#include <drm/ttm/ttm_range_manager.h>
>  #include <generated/utsrelease.h>
>
>  #include "ttm_object.h"
> --
> 2.25.1
>