Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709104320.101568-1-sumit.garg@linaro.org> <20210709104320.101568-3-sumit.garg@linaro.org>
In-Reply-To: <20210709104320.101568-3-sumit.garg@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 9 Jul 2021 14:37:13 -0700
Message-ID: <CAD=FV=WrfJEH-VYcf9ULC0pA5x0ju422c8GM1G1y33mJOmv1Fw@mail.gmail.com>
Subject: Re: [PATCH v4 2/4] kdb: Get rid of redundant kdb_register_flags()
To:     Sumit Garg <sumit.garg@linaro.org>
Cc:     kgdb-bugreport@lists.sourceforge.net,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Fri, Jul 9, 2021 at 3:43 AM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> Commit e4f291b3f7bb ("kdb: Simplify kdb commands registration")
> allowed registration of pre-allocated kdb commands with pointer to
> struct kdbtab_t. Lets switch other users as well to register pre-
> allocated kdb commands via:
> - Changing prototype for kdb_register() to pass a pointer to struct
>   kdbtab_t instead.
> - Embed kdbtab_t structure in kdb_macro_t rather than individual params.
>
> With these changes kdb_register_flags() becomes redundant and hence
> removed. Also, since we have switched all users to register
> pre-allocated commands, "is_dynamic" flag in struct kdbtab_t becomes
> redundant and hence removed as well.
>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Looking at v3 responses [1], seems like you forgot to add again:

Suggested-by: Daniel Thompson <daniel.thompson@linaro.org>

This also looks good to me now.

Reviewed-by: Douglas Anderson <dianders@chromium.org>