Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1144287pxv; Fri, 9 Jul 2021 19:24:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlZAh1VpXuGGJdtQeelZ4z4eRs2ePPSb/enBdps888o84NlJBNskJXlct53haRVVN8XLvu X-Received: by 2002:a17:906:270f:: with SMTP id z15mr40836459ejc.340.1625883891027; Fri, 09 Jul 2021 19:24:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625883891; cv=none; d=google.com; s=arc-20160816; b=xLBA/iR9FKxv3X0TJRx1foYWb9IRs10pO7DS1L9Sh2pi2aLVo9cWwDxZ76dcscYCUF VOO8MuRKRBS+qmBO+2D2J3RCPAZ8dTuP9lrLwh6NnJ+AqyIn9LwuG0ktRxPj54aflcGs wGzKjHEqL3uosnRara1bsRxBRjoDJEWqD11tp3OPoKI2XIYwe4DrKT4WdXyc3xV1mb3j K6AA+VKavQvo9PFk989Rqay98yY9irtvyX7Dqa2MMbYl9zfMH92GoEUjqjAIqVyS4t0w Cf90Wuscc6VU4ncKI/Sruhu6vVRWJIXRg5vpx/mJj4QBrnhbEle4zziREG2WNV6kFWLD jwYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lI7IcPhwkA1MSkC230Fio/iU/o9QSMduuipFKmZ6kB4=; b=BG+ev4ymE1m8aWgUwCLTMvdyL0Krog2vwnJWjf9ftdC/p2hbUAhHDrhNky6VMbILoJ AnxmysYPYqb/2VOytbmiU9rGJ+xn/CAZ93rihz16a/MWU1VK9kROjFsjWM9erMof4zam +Z59c55bn6UwYrWd/zxprKIOZM6C4aj2YzhWJ3+6yOkLTk9bpDX+K4vBlQxOKzMw3HjF AZHSe97p+IGHPXlFi0smwqxIbXKa9RmpUZKyIEn1PqkKevWKYXU9w2qgdjNjxB1hzcmS K311fw+3QHg3m5IwAt///FCNEyjy5EMisd51XIYvuWeTsqRiZVY807tV7O3zGUPG/RPx BkTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NEKXM04B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si9025616ejn.172.2021.07.09.19.24.27; Fri, 09 Jul 2021 19:24:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NEKXM04B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233090AbhGJCWq (ORCPT + 99 others); Fri, 9 Jul 2021 22:22:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:38204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232625AbhGJCVt (ORCPT ); Fri, 9 Jul 2021 22:21:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6157B61412; Sat, 10 Jul 2021 02:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883543; bh=1tBw5Zt9YPIrQK/9dRp5GoREl6y7xA8VRfsxmcF8F8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NEKXM04BVNkTEAnN5ljrN2cA3E3OUbO16Olcl+FwWYk86dJuI1mCIP4uwT19lolSf 34zZFAaGJYJUBaxV6CUbMJvK5p3kzOnaH5JOZnNMs68Cfb9QSX4QBoHzbOrcGhgqbs VHkFj7mcW2+E0X/OAhPckSb0yDeZaY3CkccjN/NJpfGW/pNOYUd2DF9ewoTIuCD3I5 nAOixl2qV0NlmfuE1OupZH4fGGyn4ZnwFqi5FTzNOJ0hAvYIrLVgjn3GE8Z67p7Ba8 CRiSnXwJBLD0TihfdDCpuHuto79i6xCN19TKaqfgLwW9FETt/8rjxVT7DgWnbypcCn 9tDc4fi8+B4ug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yufen Yu , Hulk Robot , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.13 054/114] ASoC: img: Fix PM reference leak in img_i2s_in_probe() Date: Fri, 9 Jul 2021 22:16:48 -0400 Message-Id: <20210710021748.3167666-54-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710021748.3167666-1-sashal@kernel.org> References: <20210710021748.3167666-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yufen Yu [ Upstream commit 81aad47278539f02de808bcc8251fed0ad3d6f55 ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yufen Yu Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/img/img-i2s-in.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index 0843235d73c9..fd3432a1d6ab 100644 --- a/sound/soc/img/img-i2s-in.c +++ b/sound/soc/img/img-i2s-in.c @@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev) if (ret) goto err_pm_disable; } - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) goto err_suspend; -- 2.30.2