Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1145837pxv; Fri, 9 Jul 2021 19:28:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBp9RPjn7jKx5r68dqu/MkNy0Wek+p0UpBw9Ikt158yEKascJSAuh0iLjNi1H8IRyozt8Y X-Received: by 2002:a05:6402:b07:: with SMTP id bm7mr44074958edb.345.1625884105817; Fri, 09 Jul 2021 19:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625884105; cv=none; d=google.com; s=arc-20160816; b=Y687sSe8OJysWLn2rMlQWF7o0jEGz5sIBb8yU+7R6hYbH62UV1utqfEvfpi0HfRS2w fvLBxwWXxhAMbVwh5rgmFQ7KslPbTKPZCArwwEJvuBoTk+RZx+9Iwr3/AQ+DP1MLKidl cAZ1+0tdUFidBPgcoFBFxMIjGT0Fuk+Pm1XFAi/rLEFWA1V35KFUpBl/xUFslVHoRDAR yoS1PD7UEWXLN6hsMt6cqvY4XKUOgZrLUNW9jm+tJh87XeRzf8sCMjD0AvlkpWjyj0li jZmLQ8FfCF8cyZRZDrGkAxEFUJVQpz15oOBth5jPlJJSisK5SQWk2A9ZV9Y+Jr6+nq2X Jd6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HbyEz9ODklKN6Ax8Mvy3ht6GJdxy0z3AtBLd3VOGR/8=; b=ow6YNQ71SlLjx0V6Q+mSv1k4XdIecg9R8chOVUYwNxeV925z1eRnSnj+9muf3Y0gNM 8lZksZWJkW0GnkS5461vlB5z45uf1FcUfMLFkMOkRzc0XNLGATcWUxl34lun2+tjRcos kABe2vgGDikwX3ZLOG2Acj/q1IddKa8iItD7qJVqZm5Scegnm/AgHerXBG2GGozWFqBl KEBjcJETO8ZHV0Mu69+bW8FZ23EMsxoym/Nxl7lrmvV6KhybPLeCrsoV2v4kdHHzRy+c yZgpAmMX24mbguwr6dHblp3gTibv8x6tieZJy/ZsdaqNZmGXuU4YH1MB5KtpX5YeYzh/ VJuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cFwJHjLN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si9856144edr.274.2021.07.09.19.28.02; Fri, 09 Jul 2021 19:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cFwJHjLN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234492AbhGJC3b (ORCPT + 99 others); Fri, 9 Jul 2021 22:29:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:43180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233500AbhGJC1f (ORCPT ); Fri, 9 Jul 2021 22:27:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF406613B7; Sat, 10 Jul 2021 02:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883877; bh=tRDHwn5HH5ijS49x9UzBnNcADt+hEptErFJf+WL4Q0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cFwJHjLNUBH2BvAaRmCmIzdjtumYcI0OSzcOE5TkDs306FWw45xX9DT77ti/WRIJr V4oxUXPQn2ddWXQ17iDijy2v2fdg+mfjTmDFI6XW2VQvh0ODp79SDowPIgH9qq/b/j cuVtn6imN2bi94xt/Eehd+rqpDxrCJvAYxN6qa0gsaqnstdXf+i3LcMz5dQaYWYhFI 7k0bdb/PfWQ7RfWNdOcttuKYTZMBKlOU0pyNr1llI8NCfNdSeEqioeouAHDww/4MpL ky2dFL4AKupHH05jtIwEQdUvbrsZ9cdlBfahD8dukJoo99HaZeiDiXRVRk7m1YoSMF LEFeCpp6hItxA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Frederic Weisbecker , "Paul E . McKenney" , Boqun Feng , Lai Jiangshan , Neeraj Upadhyay , Josh Triplett , Joel Fernandes , Uladzislau Rezki , Sasha Levin , rcu@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 06/93] srcu: Fix broken node geometry after early ssp init Date: Fri, 9 Jul 2021 22:23:00 -0400 Message-Id: <20210710022428.3169839-6-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022428.3169839-1-sashal@kernel.org> References: <20210710022428.3169839-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frederic Weisbecker [ Upstream commit b5befe842e6612cf894cf4a199924ee872d8b7d8 ] An srcu_struct structure that is initialized before rcu_init_geometry() will have its srcu_node hierarchy based on CONFIG_NR_CPUS. Once rcu_init_geometry() is called, this hierarchy is compressed as needed for the actual maximum number of CPUs for this system. Later on, that srcu_struct structure is confused, sometimes referring to its initial CONFIG_NR_CPUS-based hierarchy, and sometimes instead to the new num_possible_cpus() hierarchy. For example, each of its ->mynode fields continues to reference the original leaf rcu_node structures, some of which might no longer exist. On the other hand, srcu_for_each_node_breadth_first() traverses to the new node hierarchy. There are at least two bad possible outcomes to this: 1) a) A callback enqueued early on an srcu_data structure (call it *sdp) is recorded pending on sdp->mynode->srcu_data_have_cbs in srcu_funnel_gp_start() with sdp->mynode pointing to a deep leaf (say 3 levels). b) The grace period ends after rcu_init_geometry() shrinks the nodes level to a single one. srcu_gp_end() walks through the new srcu_node hierarchy without ever reaching the old leaves so the callback is never executed. This is easily reproduced on an 8 CPUs machine with CONFIG_NR_CPUS >= 32 and "rcupdate.rcu_self_test=1". The srcu_barrier() after early tests verification never completes and the boot hangs: [ 5413.141029] INFO: task swapper/0:1 blocked for more than 4915 seconds. [ 5413.147564] Not tainted 5.12.0-rc4+ #28 [ 5413.151927] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 5413.159753] task:swapper/0 state:D stack: 0 pid: 1 ppid: 0 flags:0x00004000 [ 5413.168099] Call Trace: [ 5413.170555] __schedule+0x36c/0x930 [ 5413.174057] ? wait_for_completion+0x88/0x110 [ 5413.178423] schedule+0x46/0xf0 [ 5413.181575] schedule_timeout+0x284/0x380 [ 5413.185591] ? wait_for_completion+0x88/0x110 [ 5413.189957] ? mark_held_locks+0x61/0x80 [ 5413.193882] ? mark_held_locks+0x61/0x80 [ 5413.197809] ? _raw_spin_unlock_irq+0x24/0x50 [ 5413.202173] ? wait_for_completion+0x88/0x110 [ 5413.206535] wait_for_completion+0xb4/0x110 [ 5413.210724] ? srcu_torture_stats_print+0x110/0x110 [ 5413.215610] srcu_barrier+0x187/0x200 [ 5413.219277] ? rcu_tasks_verify_self_tests+0x50/0x50 [ 5413.224244] ? rdinit_setup+0x2b/0x2b [ 5413.227907] rcu_verify_early_boot_tests+0x2d/0x40 [ 5413.232700] do_one_initcall+0x63/0x310 [ 5413.236541] ? rdinit_setup+0x2b/0x2b [ 5413.240207] ? rcu_read_lock_sched_held+0x52/0x80 [ 5413.244912] kernel_init_freeable+0x253/0x28f [ 5413.249273] ? rest_init+0x250/0x250 [ 5413.252846] kernel_init+0xa/0x110 [ 5413.256257] ret_from_fork+0x22/0x30 2) An srcu_struct structure that is initialized before rcu_init_geometry() and used afterward will always have stale rdp->mynode references, resulting in callbacks to be missed in srcu_gp_end(), just like in the previous scenario. This commit therefore causes init_srcu_struct_nodes to initialize the geometry, if needed. This ensures that the srcu_node hierarchy is properly built and distributed from the get-go. Suggested-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker Cc: Boqun Feng Cc: Lai Jiangshan Cc: Neeraj Upadhyay Cc: Josh Triplett Cc: Joel Fernandes Cc: Uladzislau Rezki Signed-off-by: Paul E. McKenney Signed-off-by: Sasha Levin --- kernel/rcu/rcu.h | 2 ++ kernel/rcu/srcutree.c | 3 +++ kernel/rcu/tree.c | 16 +++++++++++++++- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h index e01cba5e4b52..fcf95d1eec69 100644 --- a/kernel/rcu/rcu.h +++ b/kernel/rcu/rcu.h @@ -308,6 +308,8 @@ static inline void rcu_init_levelspread(int *levelspread, const int *levelcnt) } } +extern void rcu_init_geometry(void); + /* Returns a pointer to the first leaf rcu_node structure. */ #define rcu_first_leaf_node() (rcu_state.level[rcu_num_lvls - 1]) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index c13348ee80a5..68ceac387844 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -90,6 +90,9 @@ static void init_srcu_struct_nodes(struct srcu_struct *ssp, bool is_static) struct srcu_node *snp; struct srcu_node *snp_first; + /* Initialize geometry if it has not already been initialized. */ + rcu_init_geometry(); + /* Work out the overall tree geometry. */ ssp->level[0] = &ssp->node[0]; for (i = 1; i < rcu_num_lvls; i++) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 61e250cdd7c9..ac036d99b2f5 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -4383,11 +4383,25 @@ static void __init rcu_init_one(void) * replace the definitions in tree.h because those are needed to size * the ->node array in the rcu_state structure. */ -static void __init rcu_init_geometry(void) +void rcu_init_geometry(void) { ulong d; int i; + static unsigned long old_nr_cpu_ids; int rcu_capacity[RCU_NUM_LVLS]; + static bool initialized; + + if (initialized) { + /* + * Warn if setup_nr_cpu_ids() had not yet been invoked, + * unless nr_cpus_ids == NR_CPUS, in which case who cares? + */ + WARN_ON_ONCE(old_nr_cpu_ids != nr_cpu_ids); + return; + } + + old_nr_cpu_ids = nr_cpu_ids; + initialized = true; /* * Initialize any unspecified boot parameters. -- 2.30.2