Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1147109pxv; Fri, 9 Jul 2021 19:30:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9G76ck4aaNp+5xKkMhJgy6+nsOsyzWj97KTk2BhGEiwBOIxpiz4DevT8VxQ7I8CVIvQ7r X-Received: by 2002:a17:907:a04e:: with SMTP id gz14mr7083782ejc.24.1625884247590; Fri, 09 Jul 2021 19:30:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625884247; cv=none; d=google.com; s=arc-20160816; b=s8JQvmmwrQ9694DCYaFDi5t0nLNgv9sm+BximX2fb55bb64ZByR9/P51Bdaa+iIdET EBDud4wST5FKDBcQl979u5K5zvHmhRMWWUQsEbNJCp5zPsoAC9aAR/Rwnt6gDgyeX16W jSlKtMze5Lqa0Gs/2C1fSnd3tYmwi4n75ngi3xKllBQpUcrfamWCCcBePVEm/gViwEmf bvDIPGBb2v+ifCez4IsplH//HDDsSEk6iIPRe5mZpAMecpN/sBd8k/XsQUBJp64v3c+1 uUlTMowMOfLN9lQb+BNLxn8R64yDwLeMZ04GXvrz4KlTtnPni/WTFxkprvNAnS6K5+h5 0RUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lI7IcPhwkA1MSkC230Fio/iU/o9QSMduuipFKmZ6kB4=; b=SUAxlCzolt2L/E1iym9KFDEFrWMtUACtc1dHC8oNEoSyLA5t0j7lV0fq3A13EKxH/E P4OzN0wxUeGtqajILIc9QZ2L2zu1Uh/v9jZeg19zsuEjAehZScuAJG/8D4wBn7bHVVBt arqG/VtAfS+eaIBdeOzRkG/fOyI1MElCm9JOy6U3awq8/LzrvM+eS0tLwp+cAJ37I477 pSERgqKz9WQf6DFnnSesKg9rN76NcE+zsTKzXiBO9IG7ePOPr1fPuv2JVgsUcZgi4bp0 yQhHhI/ki0NsmTl4CE1++lDEBDF82Oe0zVnBgktWFlX4vGaFbCNuRGGomOA2ecejtIYr iXQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MpqqBhtR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si8519545edp.98.2021.07.09.19.30.24; Fri, 09 Jul 2021 19:30:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MpqqBhtR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234293AbhGJCbv (ORCPT + 99 others); Fri, 9 Jul 2021 22:31:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:41906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234136AbhGJC3N (ORCPT ); Fri, 9 Jul 2021 22:29:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3FE84613F4; Sat, 10 Jul 2021 02:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625883930; bh=1tBw5Zt9YPIrQK/9dRp5GoREl6y7xA8VRfsxmcF8F8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MpqqBhtRDP1MZdvQObU42OqkWHjFjSAslm28T35diLCCnCiZrB0KxYpQrK5OqyUTw Vp+hPWm6S73xhcPG4sCk7caDEX2rCwN1Y97cqd+YewgOmm2FNQz/w9lUXbiHQ9Trml 8qHPNwHpy003e+h2LiBxkCu5HoWSbtPJXhywVEa/Uq44I5Sngq4tv2vAbHmM4vrM5g 0hxJFoXGY1PCvf+/nWdroTRk1xDvqFMxCnMQnF6+8XYosVwWrk1AEqOvYjoD/uxpZm OJgubjOT3o6dLiTu0XW1r+ymmN+3GYFKyhRn8nXnhszkcqzXNuEbVRlnNIK7RKR6Vw 5RQm968xte23A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yufen Yu , Hulk Robot , Mark Brown , Sasha Levin , alsa-devel@alsa-project.org Subject: [PATCH AUTOSEL 5.10 47/93] ASoC: img: Fix PM reference leak in img_i2s_in_probe() Date: Fri, 9 Jul 2021 22:23:41 -0400 Message-Id: <20210710022428.3169839-47-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022428.3169839-1-sashal@kernel.org> References: <20210710022428.3169839-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yufen Yu [ Upstream commit 81aad47278539f02de808bcc8251fed0ad3d6f55 ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot Signed-off-by: Yufen Yu Link: https://lore.kernel.org/r/20210524093521.612176-1-yuyufen@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/img/img-i2s-in.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index 0843235d73c9..fd3432a1d6ab 100644 --- a/sound/soc/img/img-i2s-in.c +++ b/sound/soc/img/img-i2s-in.c @@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev) if (ret) goto err_pm_disable; } - ret = pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) goto err_suspend; -- 2.30.2