Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1219250pxv;
        Fri, 9 Jul 2021 22:07:29 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJx+y8UmBuhPV/iaFz7L79bT8Y/gLMlCNEHK442YOnF7U4tlKtCWiMUQU/SbSruO51c1563H
X-Received: by 2002:a17:906:dbec:: with SMTP id yd12mr40476881ejb.102.1625893648998;
        Fri, 09 Jul 2021 22:07:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1625893648; cv=none;
        d=google.com; s=arc-20160816;
        b=vpV50ukfEWR50/yrErPDe/AuqoToJaxlAajpeWjbcZE6fSOp0GoUJVoeXo0OGfWgD1
         ugm2Tkzqoz3TCtMI2D5U4PaXc3C+XTln7+o7zxM7taRJUAsotGX2yfsf0W3i+/WSq9Hy
         4vpdU7OlrwcLYFY1tBzf+Zsh6ex9VpOeEcHB4KYGYrlEF/4bWODVEPAP7ZuD5K8hYQh8
         3BIcKgj8H3K21aVyRTs5bnMEZAWFEtxLA/PZAstz4G6K7Gv3o9Fb7qRQixK1mD6yP91S
         yqrMnViemthIm4S4ikoex/yUAAqgq/zfqMYdiNvKZSaspDDWUXDQJw3I4YZMJZq2TnSm
         ZK/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=oqZMStHcgIcH14eb91GKxZroagBfx3UMmVwT2JK0JQI=;
        b=u43wGOnA3vprc4lVct+mdf/YeSZ9QVsCjNWZCcfkn+w4OLsikctQ1RNuxx5jXcjjQ3
         RtYhaQEUKq9stfR7nz2jlrBZTO5gVVt8wUlsKDpjv+Cl7wx5+XBSP91SdduOR6d36TLA
         B01SczVcq0GHxACoFTRPodirbKf0LFo0p12+jTi9yIQYYV+RIf+3i5n0lpKb7HOGvGsH
         IcubQw9UswRQH+gdPpp9hT+BjE/PP0Y0LskbNWDoReEuh9u2VNVwEQt3zYtpsO2e8xQo
         ogAPbzBLgoI8FRSWszRRQDc3+yw08GPjZqkw8MtRn5xwWZMg7CRbdenq3FLd+vKrDysF
         VF+Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PKje/gft";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a5si9302858edu.602.2021.07.09.22.07.03;
        Fri, 09 Jul 2021 22:07:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="PKje/gft";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231414AbhGJFFs (ORCPT <rfc822;maloy021189ju@gmail.com>
        + 99 others); Sat, 10 Jul 2021 01:05:48 -0400
Received: from mail.kernel.org ([198.145.29.99]:46438 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229567AbhGJFFs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 10 Jul 2021 01:05:48 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 88851613E6;
        Sat, 10 Jul 2021 05:03:03 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1625893383;
        bh=iYSchZmAc/97hywuhc0uv/csuJSDFBMm/mbu5MwOqdo=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=PKje/gftA3ophK4pa8QSFmR5FJGuH3xfEDUJ5JJZP+JVWABTbgJpz7iVH8c4F3Msc
         xhX9SL9gFuXUUB3E7Co3+wrTkwo/i7uYQzyvA21iBkqIDewUxMq1xN7mk+dVQDLCYs
         88i+60iOKxhiUCr0VSJiYSbK+dPePdj+nm0A7wAhfeX3akJ1aQrEA3JERcRtbkAMWQ
         EgzcUL0UI7yk2av6N+UnE3Wd6axeaQurBmQbR1oGmakkEU1lYCjhLJe9/LAEGvbUBr
         8VugYJN+Li5MJ9tWHKIfqm00vz+lkg3nVLLt7NTzDMPiuJWGvN97zEQhSCGDrzyUn2
         6S3o4CGQFFZTQ==
Received: by mail-pj1-f50.google.com with SMTP id n11so6884426pjo.1;
        Fri, 09 Jul 2021 22:03:03 -0700 (PDT)
X-Gm-Message-State: AOAM531RWlq2eK5/96o/oLt1Nw06PISYixce3LRQWPPWhHDMw8Dcc/g5
        nVc595hMp4n/cQusQ1KW5jkOKDA887+hIa5gbas=
X-Received: by 2002:a17:90a:9411:: with SMTP id r17mr41449680pjo.49.1625893383288;
 Fri, 09 Jul 2021 22:03:03 -0700 (PDT)
MIME-Version: 1.0
References: <20210709142418.453-1-paskripkin@gmail.com>
In-Reply-To: <20210709142418.453-1-paskripkin@gmail.com>
From:   Timur Tabi <timur@kernel.org>
Date:   Sat, 10 Jul 2021 00:02:26 -0500
X-Gmail-Original-Message-ID: <CAOZdJXWm4=UHw42YjUAQLZTNd=qbxyRag7-MJ5V4aq_xf8-1Vw@mail.gmail.com>
Message-ID: <CAOZdJXWm4=UHw42YjUAQLZTNd=qbxyRag7-MJ5V4aq_xf8-1Vw@mail.gmail.com>
Subject: Re: [PATCH] net: qcom/emac: fix UAF in emac_remove
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     timur@kernel.org, David Miller <davem@davemloft.net>,
        kuba@kernel.org, netdev <netdev@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 9, 2021 at 9:24 AM Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> adpt is netdev private data and it cannot be
> used after free_netdev() call. Using adpt after free_netdev()
> can cause UAF bug. Fix it by moving free_netdev() at the end of the
> function.

Please spell out what "UAF" means, thanks.  If you fix that, then

Acked-by: Timur Tabi <timur@kernel.org>

Thanks.