Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1304056pxv; Sat, 10 Jul 2021 00:11:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxr5P53Qv0rBQLdIvOkJhhoWPCcL16Yj048WsZw3/JdHBYgoJQTr0Ca2cZcr0j4MZZZ/vm1 X-Received: by 2002:a02:7093:: with SMTP id f141mr6925943jac.24.1625901090731; Sat, 10 Jul 2021 00:11:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625901090; cv=none; d=google.com; s=arc-20160816; b=RDjr1AhB6IuwI2KXHDFL2r8YyVptoxMbkloxzBlRipKtzX3Ysc+xcWuhkld0mXOMNQ h7rCg09Aj8XPBm54k3moNttbrlj/1w8frseG0bq49KVGYXk/jGyphy+Q5vgthzFOWywc W9HKPBGO5B7zcWxaLZ+bHN0ZeXs4c6DLX/3ZckRcoNACCSf9Q3hq4SPfqGgo7AM9O0LR 6dzqxb+IkyI+eOq2zod5HuiubLXEmD7qkq7nbtTSDnTaNtvljTJ1qU+vSkNsUlNFXcoc EmhT/p56k6cHVwTkTkvqncgEjir/ofmpRqi7n9Tr6neZmcni1YTIN6EU32TUK0jm7Ak4 HSzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RoAygn85CqSsjA+ZP3tE/tDUqjjTDbTT9PVg83fTW1Q=; b=GfkHTK/6v92PChYMRLhHExSkztqRpMepuvtFk3h2mHft+x0Ar+Enq0rygc3wNdpktF aw4LeBaqipmeIt3pVjRBG7igmrAc1o0JVhBSBb7MM8gnOoyNv3ud/fA3e/Q7PkPWFTk4 RdrGiCjD2vQwIqnUvZb4an3tKEXRFQyFPxKuGfkQVHsXo70zYGvZiDglBPPFHt/TpP+0 UldRa19Ibx4EZeBa/JWn5uIxvV2sj+HW5rlEjJZE3OcXPd+X8Dlg687QxeH9OoWISbJW nWSURLYZrnT+y9x8gsG2kZoMs7X3M60aOLklP0KlFKvv4DJGFh4R9sMBQgPReeD3CBLG L4nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qk0M31hp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t10si9472712ilf.122.2021.07.10.00.11.18; Sat, 10 Jul 2021 00:11:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Qk0M31hp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbhGJHGO (ORCPT + 99 others); Sat, 10 Jul 2021 03:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbhGJHGN (ORCPT ); Sat, 10 Jul 2021 03:06:13 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E258AC0613E5; Sat, 10 Jul 2021 00:03:27 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id v14so28217866lfb.4; Sat, 10 Jul 2021 00:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RoAygn85CqSsjA+ZP3tE/tDUqjjTDbTT9PVg83fTW1Q=; b=Qk0M31hpLFQuZ101Z7OCsnl/DFh07uLcSdbJyOMSFQuqHdob7iXbLGmemYWt/lfub5 EP9sj0t53DYqp1W5+g37adrSfcG0qcwDYdrZHBcy3apVTnmM+Jz2MXLU3kxuPXKa1Y9w PNTI0y3bknbuJH8YyX67X7z1T+1R7LZjx61tEPvtHNiljlrvAug2dyit7wb48X73zFgP IGdWrEDfByHJ33MLetB6+mIA+CFRvqqqcAMd6Z+esO5ilKyk88pt6gpf3zEWP8I3smlz G/ZGtaJs/Pm/Lf2WCtTokYQyQXDw4cWPNx5RWeekJY/pBozggYukO9jOaOzEQ4Pa3Ias x0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RoAygn85CqSsjA+ZP3tE/tDUqjjTDbTT9PVg83fTW1Q=; b=ML/wi8iJ2lFOvtBjpmHrM/fopaaWBPF7HdM8CgDAMl1UxTDZ5FqbqZHlt7MsVm+ue3 +aFvLqLS9B7wfDARtmf+RuQiKywzTRtdIa1OawcofdVNchWBnrYyTkIfQn1+TL9YsqyM LV+35Ref5aHaIEfKYo+wkrmoBs0luNPS7nRKoU6WeKSIyipanFd21RNiXCS/nQ3/bKjN iBjPx0UXWq0jmtN5d/YOgqte5O8O+GRcIMCgZ4eOiaWISbpQ9CZsUu1bKsc0aMhICVej Pu2FbzW4+woYN+HrAK8/j82I+m6Fl+c4LEQpvW/natIlLTpdf3tz4nDjWhtHrA4IW2dq +pZQ== X-Gm-Message-State: AOAM5304sbVui5huUBjN+/0muMVVEamcDTH9euw67lmTJm0IGcTJpBNx tS4TH6Ww/0bcdRSoGBpt4FU= X-Received: by 2002:a05:6512:4007:: with SMTP id br7mr23604831lfb.271.1625900606277; Sat, 10 Jul 2021 00:03:26 -0700 (PDT) Received: from localhost.localdomain ([94.103.225.155]) by smtp.gmail.com with ESMTPSA id a1sm616309lff.232.2021.07.10.00.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 00:03:25 -0700 (PDT) From: Pavel Skripkin To: paul@paul-moore.com, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Skripkin Subject: [PATCH 2/2] net: cipso: fix memory leak in cipso_v4_doi_free Date: Sat, 10 Jul 2021 10:03:23 +0300 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When doi_def->type == CIPSO_V4_MAP_TRANS doi_def->map.std should be freed to avoid memory leak. Fail log: BUG: memory leak unreferenced object 0xffff88801b936d00 (size 64): comm "a.out", pid 8478, jiffies 4295042353 (age 15.260s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 15 b8 12 26 00 00 00 00 00 00 00 00 .......&........ backtrace: netlbl_cipsov4_add (net/netlabel/netlabel_cipso_v4.c:145 net/netlabel/netlabel_cipso_v4.c:416) genl_family_rcv_msg_doit (net/netlink/genetlink.c:741) genl_rcv_msg (net/netlink/genetlink.c:783 net/netlink/genetlink.c:800) netlink_rcv_skb (net/netlink/af_netlink.c:2505) genl_rcv (net/netlink/genetlink.c:813) Fixes: b1edeb102397 ("netlabel: Replace protocol/NetLabel linking with refrerence counts") Signed-off-by: Pavel Skripkin --- net/ipv4/cipso_ipv4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c index bfaf327e9d12..e0480c6cebaa 100644 --- a/net/ipv4/cipso_ipv4.c +++ b/net/ipv4/cipso_ipv4.c @@ -472,6 +472,7 @@ void cipso_v4_doi_free(struct cipso_v4_doi *doi_def) kfree(doi_def->map.std->lvl.local); kfree(doi_def->map.std->cat.cipso); kfree(doi_def->map.std->cat.local); + kfree(doi_def->map.std); break; } kfree(doi_def); -- 2.32.0