Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1396546pxv; Sat, 10 Jul 2021 03:06:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKnv52KmWyn7ZTZQghIlfQejMrG2/zf/JjBsA6J91ANuAffIqAkFLXzh55Snr2JOR2JMZe X-Received: by 2002:a05:6402:1488:: with SMTP id e8mr29431972edv.341.1625911564816; Sat, 10 Jul 2021 03:06:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625911564; cv=none; d=google.com; s=arc-20160816; b=NP43g8yQ5xce1mtLhc90+Do8ZoADaHPxlRKzkIfENSfXf6gI+XtmNEHQZFrIPLAiNq KbgMdKMlfYKRNfEal5yQF4zBwd/GDC8APsymX3fSTTlBMI+J5Yc3bMxm1ufDfk9gKPrv oSVXdM/DuVDjXP0txAAAgDKj7MU/HGKKaWPqN8RM3DfWCkucx+nPg9wV5iJHjUsvC7CR kKdDY4wlzxjbV2l/co6ulXAeK0opPCWp418yO+YahjtlwzPH4++CtHuczd+NHplAUrV2 dk6namaEPf2DiubV+Q4t8iYYq/0eY0CBXqWDKo4btjnt7gAOKStPHXah2LfxYjh+Xgjr 0RUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=RXX85j7s8xfuPRdyAvMVBuKrCzKB1cSTQ/b5n0WQ6uA=; b=zn5ZFtLFW6FJ0YUSoAiHV0ucO5yqPxn7u9tfDy0ZfvH1iGJm9Q7usBpJoqEgACOq/J Boi2NGCOMZTkQoQl31o0m0yTOBY4MyZlsyTyjRUJPpQHP6vZRlgOGMUQjtwi4ID4G6qL srYwd5La8waeesR67vKFg7r9RtN7G5cTAFROr+gi0rXCDcWtjKf+sLzwHLCBmWFl8Nzh rQhuxLtoVkP0uEpDK6YkuDMD8V2nZCWcOlxbFtBWln7iRx5jf7cd+5CYv9XGN1YUJ2q3 aiKm1p59eY4HNm/fXf2EG7meliX69E18YZTlV7FQW90bv/F+SiEjT4JLRkYT6iasSs7r Woiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nd21si9678752ejc.248.2021.07.10.03.05.27; Sat, 10 Jul 2021 03:06:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232544AbhGJKGK (ORCPT + 99 others); Sat, 10 Jul 2021 06:06:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:6800 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232504AbhGJKGG (ORCPT ); Sat, 10 Jul 2021 06:06:06 -0400 Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GMQSW09Z6zXpcg; Sat, 10 Jul 2021 17:57:47 +0800 (CST) Received: from huawei.com (10.175.124.27) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 10 Jul 2021 18:03:19 +0800 From: Miaohe Lin To: CC: , , , , , , , , , , , , , , Subject: [PATCH 2/5] mm/vmscan: remove misleading setting to sc->priority Date: Sat, 10 Jul 2021 18:03:26 +0800 Message-ID: <20210710100329.49174-3-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210710100329.49174-1-linmiaohe@huawei.com> References: <20210710100329.49174-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The priority field of sc is used to control how many pages we should scan at once while we always traverse the list to shrink the pages in these functions. So these settings are unneeded and misleading. Signed-off-by: Miaohe Lin --- mm/vmscan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 6483fe0e2065..fbe53e60b248 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1702,7 +1702,6 @@ unsigned int reclaim_clean_pages_from_list(struct zone *zone, { struct scan_control sc = { .gfp_mask = GFP_KERNEL, - .priority = DEF_PRIORITY, .may_unmap = 1, }; struct reclaim_stat stat; @@ -2327,7 +2326,6 @@ unsigned long reclaim_pages(struct list_head *page_list) unsigned int noreclaim_flag; struct scan_control sc = { .gfp_mask = GFP_KERNEL, - .priority = DEF_PRIORITY, .may_writepage = 1, .may_unmap = 1, .may_swap = 1, -- 2.23.0