Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
Date:   Sat, 10 Jul 2021 15:09:55 +0200
From:   Salvatore Bonaccorso <carnil@debian.org>
To:     Maxime Ripard <maxime@cerno.tech>
Cc:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@siol.net>,
        Rob Herring <robh+dt@kernel.org>,
        Chen-Yu Tsai <wens@kernel.org>,
        Vagrant Cascadian <vagrant@reproducible-builds.org>,
        "B.R. Oake" <broake@mailfence.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode
Message-ID: <YOmcI191mbxXCrp1@eldamar.lan>
References: <20210524122111.416885-1-carnil@debian.org>
 <20210524123506.cuwwtqgtejquuq5e@gilmour>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210524123506.cuwwtqgtejquuq5e@gilmour>
Precedence: bulk

Hi Maxime,

On Mon, May 24, 2021 at 02:35:06PM +0200, Maxime Ripard wrote:
> On Mon, May 24, 2021 at 02:21:11PM +0200, Salvatore Bonaccorso wrote:
> > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") sets the RX/TX delay according to the phy-mode property in the
> > device tree. For the Orange Pi Plus board this is "rgmii", which is the
> > wrong setting.
> > 
> > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > the Ethernet working again on this board.
> > 
> > Fixes: bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config")
> > Reported-by: "B.R. Oake" <broake@mailfence.com>
> > Reported-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
> > Link: https://bugs.debian.org/988574
> > Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
> 
> Applied, thanks!

Did this fall trough the cracks? 

I see it in
https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git/commit/?id=b19d3479f25e8a0ff24df0b46c82e50ef0f900dd
but got not merged yet in mainline.

Thank you for your work!

Regards,
Salvatore