Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 10 Jul 2021 17:42:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Shuyi Cheng <chengshuyi@linux.alibaba.com>
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak
 caused by obj->kconfig
Message-ID: <20210710144248.GA1931@kadam>
References: <1625798873-55442-1-git-send-email-chengshuyi@linux.alibaba.com>
 <1625798873-55442-3-git-send-email-chengshuyi@linux.alibaba.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1625798873-55442-3-git-send-email-chengshuyi@linux.alibaba.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kadam (102.222.70.252) by JNAP275CA0046.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Sat, 10 Jul 2021 14:43:21 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 19946d22-cc1f-4e52-41b8-08d943b1156b
X-MS-TrafficTypeDiagnostic: CO1PR10MB4706:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB47063EAF72E9143A74591A638E179@CO1PR10MB4706.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:357;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8XfqzTxlT2uiC4dMzZM9AXb7gYnEe0kA5hg6t7X9+b3jWDfUpM7KklV0+JBQZunRDBU1z+0hVUKQl9weF8OSVRR1snhoyXGd1/RoYnhhPj8TAaWCQiCF+x1af5CEJ/cWvmBaaz35ovDFDbjsTftg0XvAk9P353hAu6ciwvZ7RVVddXN520JEOiHv5HceqMHj3OcvJEW8bxd1pBG/+pnRG6yXKTFPAV3cWycBV6g0CWXWcZMF9PeePmTWJF836at4IsyI2uTF/AEL/DFzdBWSrwz4boyxvk2RpftNmLMtqvIO4eMmhFOa/MNiEIps0jCOr3Bb4Ct4NLjrl9dz7HTzTj/FJa7NcrcSXwzNMZeQ5kAqYPIBzhoU0+5WUM4r/Hr8+wZAC3RinzJV879UW0kje29+NDkcxIybpgFsfA/KtaeJiOM51xlMsfrmPWzHwhGtDB7M5V9FQ+kDuzI/4pEsRLgNbOvrby51kpoKnHqIoqnO3hiHXnONNfc5+2s4THC/wU/AH48AtyqUVvHjOzAWCX4fZyJFuRRcy2wstgRhbZNPZave/1pEnqgkeRQZGg5QPa2hZEkaQyEfMSHjsRoZ/jUtfWu19NYJmNa0lp3iu4ojmvEXkrijB0dYHxs9GgF3y+Z8KapfO/kz0CW04y9uHYdLMnxdKw6oY5SjluUj3bbC8ux9OTOCUbSGY/6dhGz4SkJKVbzL92k8piNBY4jc2Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(366004)(136003)(396003)(376002)(4744005)(83380400001)(6666004)(33716001)(66476007)(186003)(6916009)(44832011)(66556008)(66946007)(5660300002)(86362001)(38350700002)(38100700002)(26005)(478600001)(6496006)(7416002)(316002)(9686003)(4326008)(8936002)(9576002)(2906002)(33656002)(1076003)(55016002)(8676002)(956004)(52116002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5sa2BhtJEHOS+BzP5/8NBC7ShBAZV1mGfIvIBNWZU5OxPplmSLK9rR7lSmBp?=
 =?us-ascii?Q?7O1M8JIbvdFCLtndikqWuZ3qlDEn/8U+Fit3hCsyDmcX5OU1MPzBN3fqM6zb?=
 =?us-ascii?Q?gT5KVnm8bjLOquVLvcIatRkxE+qx5AW0jcuN5ZHSXu9NQvOLLCVujrinrvo0?=
 =?us-ascii?Q?HhnRsoemm+J35ZfVUllSmHjJH6Fc0pE3UKvds7fliNidlLBIucY6CIOnINcK?=
 =?us-ascii?Q?Zi54VKp0tFN/hyma3flbJqZhS8UFZniCfVVlONQQoglXsTvfxDstZGol3ygW?=
 =?us-ascii?Q?QUGFM1z3WC70vF4S69d8rTl9hFJT9Spa1RZiCcTwTEi4scLBCS9K8vaECJxO?=
 =?us-ascii?Q?VdVWf1SK3QlhG1dcHqLeSR+wmKMnmUUpceJxx6+ispXiCxoD1e2e5fyyRF3b?=
 =?us-ascii?Q?nPSAJnT7VgWH3DZ/J3H05Q7SRFRZUCcna9me7AjlQHiDkzBafbYNDDwbACFV?=
 =?us-ascii?Q?mU2zQQEXxPCoyEqnfUSus80McGcb7l9gsCMrp9+DKeAmN5ZmldG7EHJb1i/A?=
 =?us-ascii?Q?xj/fdZ3ZeFwKh1xIwP8ZR9NUEOPwvKXNqtGvmRO1KCyNlEUxu/TFJkuK/yfL?=
 =?us-ascii?Q?44p1wxuHAdh7Bj3DzreTXZnHmtbxlzZ/WEal94PhaHBiJ7K//5TMnU4CJg2+?=
 =?us-ascii?Q?U8b7weY3IUawiBVAQ2jKii+jZYPLL8DnFrAEEzucYoDMtgEAG3QF369n1ld8?=
 =?us-ascii?Q?kD8HkNfcMaXGwupWHfIG2+7t997HdFp4s9NtfsOpHB8ZEr6jYP7t2HolRRJz?=
 =?us-ascii?Q?7PqAKG1LRY4Me2u/xxvAf7+5UAYi5MXSiBMv3tZSeik+9F6tR763WOHJwJlw?=
 =?us-ascii?Q?FPNdLeDWYUJcw4qKL6iiKH0IMzYIV1WyOj8kWWzd+AERd1wSs6NEg7Z7GB4z?=
 =?us-ascii?Q?ejEm5f/K0wuklHH2L3BJKdASoEWIfgEism05QjbTC4O9mcbuMLlJaZpwq9yu?=
 =?us-ascii?Q?c49gYkzvIEC0R6hlL/tyTNEojKMaliEzc34C2T6CW/zU1JG4fO/f1OL3ECPk?=
 =?us-ascii?Q?Yhwp7Ub5+KGNMKPL81tWYGwI23Y2KbCh+kLIhOzaR7va/EMU/kv9S/noDSQu?=
 =?us-ascii?Q?tMh/RH++OJgCqByMiaDQnWD98NqxsiFoCbY2+4cjiYwvGnGPSba4jWTDyXdQ?=
 =?us-ascii?Q?btpDyF3+h+3VhkVYA0eN2ZvKd7Q338sFHY0aDAZxHn6XSVVY8hLCqAUq8B4b?=
 =?us-ascii?Q?BKyPaXvq8+W/g0+c7TOmvbD5e0b09neR9UVkLjeQxW4en8I519dC2Vke3yjY?=
 =?us-ascii?Q?Wn7P11x9b4oVwCP/h29iV7/Hq9osk/i2BtjAV3xOIgsuzQgZnZzTl5VRs0+Y?=
 =?us-ascii?Q?4Kzuk+sfzKJc5Nq8XAQhIiQI?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19946d22-cc1f-4e52-41b8-08d943b1156b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2021 14:43:30.0626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iVaOGgOCs6XO7q2edd7kTaMF59PVwhz+0F11fPUtIDkm1YdGXIe3XBFOZ7sBC9vyZ9MopbrbmvyS6fsxYI8wXzGpTkETUQ2cqOnYlI5CoZw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4706
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10040 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 mlxscore=0
 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107100024
X-Proofpoint-GUID: k7qmlPS5cASjv27YkkpVlJ0KBZIMgXR7
X-Proofpoint-ORIG-GUID: k7qmlPS5cASjv27YkkpVlJ0KBZIMgXR7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 09, 2021 at 10:47:53AM +0800, Shuyi Cheng wrote:
> When obj->kconfig is NULL, ERR_PTR(-ENOMEM) should not be returned
> directly, err=-ENOMEM should be set, and then goto out.
> 

The commit message needs to say what the problem is that the patch is
fixing.  Here is a better commit message:

[PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak on error

If the strdup() fails then we need to call bpf_object__close(obj) to
avoid a resource leak.

Add a Fixes tag as well.

regards,
dan carpenter