Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v12 15/17] counter: Implement events_queue_size sysfs
 attribute
From:   David Lechner <david@lechnology.com>
To:     William Breathitt Gray <vilhelm.gray@gmail.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     jic23@kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        kernel@pengutronix.de, a.fatoum@pengutronix.de,
        kamel.bouhara@bootlin.com, gwendal@chromium.org,
        alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        syednwaris@gmail.com, patrick.havelange@essensium.com,
        fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com,
        alexandre.torgue@st.com, o.rempel@pengutronix.de
References: <cover.1625471640.git.vilhelm.gray@gmail.com>
 <e298043c880b350a42bdc40452376a3708bf533b.1625471640.git.vilhelm.gray@gmail.com>
 <1a624011-0b43-ac42-be53-a42f81923e5a@linux.intel.com>
 <YOl1frCrophjhk7y@shinobu>
 <fbf1ba4c-412b-fe22-0e79-76e968a00fb4@lechnology.com>
 <76cc7f77-a59c-86ef-8df9-65b877356b32@lechnology.com>
Message-ID: <f1c57abc-cb68-c00c-3037-dc53c0adab1a@lechnology.com>
Date:   Sat, 10 Jul 2021 12:53:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <76cc7f77-a59c-86ef-8df9-65b877356b32@lechnology.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/10/21 11:08 AM, David Lechner wrote:
> On 7/10/21 10:43 AM, David Lechner wrote:
>> On 7/10/21 5:25 AM, William Breathitt Gray wrote:
>>>> and after that
>>>>
>>>> [   16.564403] ================================================
>>>> [   16.570725] WARNING: lock held when returning to user space!
>>>> [   16.577044] 5.13.0-next-20210706+ #4 Not tainted
>>>> [   16.582198] ------------------------------------------------
>>>> [   16.588507] cat/331 is leaving the kernel with locks still held!
>>>> [   16.595214] 1 lock held by cat/331:
>>>> [   16.599103]  #0: ffff888102bb3630
>>>> (&counter->chrdev_lock){+.+.}-{3:3}, at: counter_chrdev_open+0x21/0x60
>>>> [counter]
>>>>
>>>> Jarkko
>>> I'm not sure how to resolve this warning. The purpose of this lock is to
>>> limit chrdev to a single open at a time. To accomplish this I grab this
>>> lock in counter_chrdev_open() and hold it until counter_chrdev_release()
>>> is called. Is there a better way to accomplish this?
>>
>> How about using an atomic flag, e.g test_and_set_bit()?
> 
> Another option could be to rethink it at a higher level and avoid the
> need for a lock (and sysfs attribute) altogether. For example, would it
> work to (re)allocate the kfifo buffer in the COUNTER_ENABLE_EVENTS_IOCTL
> callback and add a parameter to that ioctl to specify the buffer size
> (with units of events rather than bytes)?
> 

Thinking about it a bit more, this probably isn't a good suggestion.
It would create issues with being able to start reading from the chrdev
before enabling events.