Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 10 Jul 2021 22:59:13 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
        claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com,
        UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 net-next 2/8] net: dsa: ocelot: felix: move MDIO
 access to a common location
Message-ID: <20210710195913.owqvc7llnya74axl@skbuf>
References: <20210710192602.2186370-1-colin.foster@in-advantage.com>
 <20210710192602.2186370-3-colin.foster@in-advantage.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210710192602.2186370-3-colin.foster@in-advantage.com>
Precedence: bulk

On Sat, Jul 10, 2021 at 12:25:56PM -0700, Colin Foster wrote:
> Indirect MDIO access is a feature that doesn't need to be specific to the
> Seville driver. Separate the feature to a common file so it can be shared.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---

In fact, this same piece of hardware has a dedicated driver inside
drivers/net/mdio/mdio-mscc-miim.c. The only problem is that it doesn't
work with regmap, and especially not with a caller-supplied regmap. I
was too lazy to do that, but it is probably what should have been done.

By comparison, felix_vsc9959.c was coded up to work with an internal
MDIO bus whose ops are implemented by another driver (enetc_mdio). Maybe
you could take that as an example and have mdio-mscc-miim.c drive both
seville and ocelot.