Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp1722977pxv; Sat, 10 Jul 2021 13:03:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFiNNsdlvXfsJUEdSORUX7otqAZ3+PJBWKy2o7Z06P2Ba2IRu1Oe8AJOKG49rlJSV8kp5H X-Received: by 2002:a50:ed91:: with SMTP id h17mr6176490edr.133.1625947416824; Sat, 10 Jul 2021 13:03:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625947416; cv=none; d=google.com; s=arc-20160816; b=rU66v/xy2eV6lloxjh9eIaWDzOvdG3i9sihuniSZQxAXFVhk6ETQoJd6XvumDsZvwc vqSvuF0tLihqAcYwpT/IA+tucxlUYEDcRUyhrETdMhI25DqryExBNVA/TfRED7oR4ZuH bkAtSYaN10kt4i8oxEnNh9NhQtBEIubeAIf4sSfMraqbdrED/aEq8/O6rD+B/7fzEKCw VDSNWfJaBDaunBp47KkhNapGIvfbSE5lB+w/lLWVXMTGAuyD3HgGddLIgtkW9qRSlarL 2FCQNxjD4Erg0vOVBbtSqFs4YYyIoSzbYWHevFI7WvPEnI9oHHIFcbMKf2XiKQYMcZiT cBzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=w0st8invJPUBlBrC3mMsH9YtOHoYZNwzSkFW4dmNY64=; b=DB35ikPAHh+7noZVxzIwSzptiQIi4iHqnc31c55/2BS1l18HvNtm4gJAwIZ0GbcyxF QoEqjI5YNzsyTstb+PdfeG20PNZ1cPenwaJQyoRZc0+k6C7iuozQpJI+IhjjBToYL92Z ZsnIxG/PFnkQblQDAfXYAw4QsXNEomVVKtVaLeDWB7AcvLN5yDMpZBavbREuanIVRoRa sg6DrcohpfgTWrWDocYY2aLjtC9he0TDYYwT1cA71QK1UU3umZ8yxfpGGo0Q5nQJl6xa WcoQw1VacSOzwR6Q22m5+e1k0FQb3P89wYpkBzNsKEHQ0Gfj54bDERBVS4iE0tBj/zMZ h2mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si11706057edt.425.2021.07.10.13.03.13; Sat, 10 Jul 2021 13:03:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbhGJUEe (ORCPT + 99 others); Sat, 10 Jul 2021 16:04:34 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:45065 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbhGJUEd (ORCPT ); Sat, 10 Jul 2021 16:04:33 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A34AD20005; Sat, 10 Jul 2021 20:01:45 +0000 (UTC) Date: Sat, 10 Jul 2021 22:01:45 +0200 From: Alexandre Belloni To: Colin Foster Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, claudiu.manoil@nxp.com, UNGLinuxDriver@microchip.com, linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 net-next 0/8] Add support for VSC7511-7514 chips over SPI Message-ID: References: <20210710192602.2186370-1-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210710192602.2186370-1-colin.foster@in-advantage.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2021 12:25:54-0700, Colin Foster wrote: > Add support for configuration and control of the VSC7511, VSC7512, VSC7513, and > VSC7514 chips over a SPI interface. The intent is to control these chips from an > external CPU. The expectation is to have most of the features of the > net/ethernet/mscc/ocelot_vsc7514 driver. > > I have tried to heed all the advice from my first patch RFC. Thanks to everyone > for all the feedback. > > The current status is that there are two functional "bugs" that need > investigation: > 1. The first probe of the internal MDIO bus fails. I suspect this is related to > power supplies / grounding issues that would not appear on standard hardware. Did you properly reset the internal phys? mdio-mscc-miim.c does that. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com