Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424188AbWKPPlS (ORCPT ); Thu, 16 Nov 2006 10:41:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1424187AbWKPPlR (ORCPT ); Thu, 16 Nov 2006 10:41:17 -0500 Received: from mga09.intel.com ([134.134.136.24]:18047 "EHLO mga09.intel.com") by vger.kernel.org with ESMTP id S1424184AbWKPPlQ (ORCPT ); Thu, 16 Nov 2006 10:41:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: i="4.09,430,1157353200"; d="scan'208"; a="162601169:sNHT42161098" Message-ID: <455C8696.80508@linux.intel.com> Date: Thu, 16 Nov 2006 18:41:10 +0300 From: Alexey Starikovskiy User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) MIME-Version: 1.0 To: David Brownell CC: Len Brown , Linux Kernel list , linux-acpi@vger.kernel.org Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors References: <200611142303.47325.david-b@pacbell.net> <455B28B2.4010707@linux.intel.com> <200611151356.52985.david-b@pacbell.net> <200611151710.26570.david-b@pacbell.net> In-Reply-To: <200611151710.26570.david-b@pacbell.net> Content-Type: multipart/mixed; boundary="------------030108010505080106030705" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3448 Lines: 111 This is a multi-part message in MIME format. --------------030108010505080106030705 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Looks like either EC GPE or whole ACPI irq got disabled... Could you check that ACPI interrupts still arrive after you notice AE_TIME? Also, may be attached patch will help? Regards, Alex. David Brownell wrote: > On Wednesday 15 November 2006 1:56 pm, David Brownell wrote: > >> On Wednesday 15 November 2006 6:48 am, Alexey Starikovskiy wrote: >> >>> ec1.patch >>> >>> >>> Always enable GPE after return from notify handler. >>> >>> From: Alexey Starikovskiy >>> >>> >>> --- >>> >> Yes, this seems to resolve the regression as well as Len's ec_intr=0 boot param. >> > > Whoops, I spoke too soon. It does get rid of SOME of the AE_TIME errors. But > the system is still confused about whether or not the AC is connected, and > whether the battery is charging or not; and the CPU is still relatively hot. > Even with this patch I later got: > > ACPI Exception (evregion-0424): AE_TIME, Returned by Handler for [EmbeddedControl] [20060707] > ACPI Exception (dswexec-0458): AE_TIME, While resolving operands for [OpcodeName unavailable] [2006070 > 7] > ACPI Error (psparse-0537): Method parse/execution failed [\_TZ_.THRM._TMP] (Node ffff810002032d10), AE > _TIME > > In short, better but evidently not yet good enough... > > - Dave > > > > >> IMO this should get merged into 2.6.19 ASAP ... >> >> >> >>> drivers/acpi/ec.c | 2 -- >>> 1 files changed, 0 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c >>> index e6d4b08..937eafc 100644 >>> --- a/drivers/acpi/ec.c >>> +++ b/drivers/acpi/ec.c >>> @@ -465,8 +465,6 @@ static u32 acpi_ec_gpe_handler(void *dat >>> >>> if (value & ACPI_EC_FLAG_SCI) { >>> status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec); >>> - return status == AE_OK ? >>> - ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED; >>> } >>> acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR); >>> return status == AE_OK ? >>> --------------030108010505080106030705 Content-Type: text/plain; name="ec2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ec2.patch" Always confirm handled interrupt, even if we failed. From: Alexey Starikovskiy --- drivers/acpi/ec.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 937eafc..6fb5ee0 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec); } acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR); - return status == AE_OK ? - ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED; + WARN_ON(ACPI_FAILURE(status)); + return ACPI_INTERRUPT_HANDLED; } /* -------------------------------------------------------------------------- --------------030108010505080106030705-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/