Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     Kajol Jain <kjain@linux.ibm.com>,
        "will@kernel.org" <will@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "Xu, Yilun" <yilun.xu@intel.com>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "maddy@linux.ibm.com" <maddy@linux.ibm.com>,
        "atrajeev@linux.vnet.ibm.com" <atrajeev@linux.vnet.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "rnsastry@linux.ibm.com" <rnsastry@linux.ibm.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance
 reporting
Thread-Topic: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance
 reporting
Thread-Index: AQHXdJ6Olv3FhDOpC0+B/jPwvOSEk6s+nwpQ
Date:   Mon, 12 Jul 2021 02:27:24 +0000
Message-ID: <DM6PR11MB38197304C3BC02672304201A85159@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20210709084319.33776-1-kjain@linux.ibm.com>
In-Reply-To: <20210709084319.33776-1-kjain@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4ugT/pDLy5EV6tDElHTJkUbmxnq5I55BCDt1yYNF7H4uEkqeGrx5iFIrOE2s?=
 =?us-ascii?Q?803yNQ48bgjDn+gj0hHNJM9DyYk9s6JnCWcBN+WeGznGuBN4/kxt45WRq8fc?=
 =?us-ascii?Q?XdtXuhAkzuVcxLhg2spVQtIa9teby7To8ire/K29OJNM/pVvhlsLMOvwpmDA?=
 =?us-ascii?Q?0TaO54CKpJapuKENAik1pyO8IB7mqJpEODcSNQwPEnSaVlpzXXS+pud5xFnC?=
 =?us-ascii?Q?188kfY5iHyG2BjOVxZndrR3LH/tDw1jkR9OjRokCdLfd+1m4Tfw6hcGqCaya?=
 =?us-ascii?Q?FN6fSPQEODpIxXahdL75cId3SyVmd0Fs9OxJ0ujEEFU4jcAeQNH7z19MsTf4?=
 =?us-ascii?Q?nV63iNuKrzWtgjpYcQe6zLL+sGubC36gFZf6p3IwVt+J5JB61RYko571FYG8?=
 =?us-ascii?Q?zv5aj+iFSpERN1lwu7EMdApBIMEfzJtnjNx5DiQgz9I1wRlk0B4HXhZnI0MT?=
 =?us-ascii?Q?Q3f+9eZxP1LLab6rnMo+tDJGhqYA0JQANbGGrUNoLienChYutzpPUA0vnT6O?=
 =?us-ascii?Q?qbHMyiti0uNUnXm8+Y2pXsDL4IbQY3Eb6ZLlBH+X8P98j/c6SV+TSPhxYaBf?=
 =?us-ascii?Q?YAzM0qnWOhD8XpLac52Ud8DVaFhqOn4SCdMxKw9CCP+aTesy8IJMlVz+egi6?=
 =?us-ascii?Q?bgfqW5WEx3PJgi/0HJo7B/Vc2L3sCjNOzce0G0fA3tSYQWIbvRHVqzOq1ibP?=
 =?us-ascii?Q?ZCcuEZaGRn5Ejatx1HuYTbwvS2dlHk+YtLnRCFhQVwAk5SyAwcCiNpN6Jqbb?=
 =?us-ascii?Q?LmIRw5lExZGEofvBmniVLFopvmHIW8qH4h5VRG9bnloHTedRZTgnNcFpVhfs?=
 =?us-ascii?Q?k28d43RNajRKEe796wlQCX7kLS1cRLBkSfubGNcBcQr/RKTepdesJkJb9rx7?=
 =?us-ascii?Q?Xw8tj4wls4zLYB3yXR8njmd1KAcvk5mLNtPZb8cqqGfGfdHDL2owBVZliuU6?=
 =?us-ascii?Q?uZk/y6TGyGoCqo+4Xn+zrCTR16O/+Durgk5+T1YtS525/PUQdGFz0IkSNT08?=
 =?us-ascii?Q?dztjtG+UOOp0RX7tKJI9WIFu3LpuJB5SU9U2RULSan+T2wI2sh4YbjzgRrWO?=
 =?us-ascii?Q?XyVULntuUeMiNAIveP2NrZOrWUyDObxp4+riUIRwoHWiysSJSD1RFfeLBKmg?=
 =?us-ascii?Q?USTPGMxDOnXiqRX4GyZu3uY/0TAcIpb1zdbgB1rKuqZqCLwLimAwI17U+aC1?=
 =?us-ascii?Q?IwJdygB4YswILzSPOkNm4nt4dridffg7oHRgXpJX3JphaTTlqVnemky9MFo0?=
 =?us-ascii?Q?DNOTud2n3PNKH1r+a6LPvECNzww9b5/PpGAITSom9os4nSNwHM4tw4Yi3HTJ?=
 =?us-ascii?Q?rGibxLJ+ZhJeIHXWF84qQWUj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2035c0bc-912a-418c-ec0b-08d944dc95c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 02:27:24.5221
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rtPEcShbylyS4W+xJs4OlJcmTG7iw/+Df/JFHZo1LkUVGaVXsmUCHAllGOT7Uocl8K426C72NBT9Wt/wUtIv2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5421
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v2] fpga: dfl: fme: Fix cpu hotplug issue in performance
> reporting
>=20
> The performance reporting driver added cpu hotplug
> feature but it didn't add pmu migration call in cpu
> offline function.
> This can create an issue incase the current designated
> cpu being used to collect fme pmu data got offline,
> as based on current code we are not migrating fme pmu to
> new target cpu. Because of that perf will still try to
> fetch data from that offline cpu and hence we will not
> get counter data.
>=20
> Patch fixed this issue by adding pmu_migrate_context call
> in fme_perf_offline_cpu function.
>=20
> Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
> Tested-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Kajol Jain <kjain@linux.ibm.com>

Thanks for this fixing! And thanks Yilun for the verification too. : )

> Cc: stable@vger.kernel.org
> ---
>  drivers/fpga/dfl-fme-perf.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> ---
> Changelog:
> v1 -> v2:
> - Add stable@vger.kernel.org in cc list
>=20
> RFC -> PATCH v1
> - Remove RFC tag
> - Did nits changes on subject and commit message as suggested by Xu Yilun
> - Added Tested-by tag
> - Link to rfc patch: https://lkml.org/lkml/2021/6/28/112
> ---
> diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
> index 4299145ef347..b9a54583e505 100644
> --- a/drivers/fpga/dfl-fme-perf.c
> +++ b/drivers/fpga/dfl-fme-perf.c
> @@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, st=
ruct
> hlist_node *node)
>  		return 0;
>=20
>  	priv->cpu =3D target;
> +
> +	/* Migrate fme_perf pmu events to the new target cpu */

Only one minor item, this line is not needed. : )

After remove it,=20
Acked-by: Wu Hao <hao.wu@intel.com>

Thanks
Hao

> +	perf_pmu_migrate_context(&priv->pmu, cpu, target);
> +
>  	return 0;
>  }
>=20
> --
> 2.31.1