Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2638669pxv; Sun, 11 Jul 2021 21:04:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOu1ijmyKr86BHthD9WiK8RfZYpAd2PWtOmHFFHxhyQ8wBPDg6v51jxvSGRP/uD4UG7H4C X-Received: by 2002:a05:6402:2714:: with SMTP id y20mr13492727edd.190.1626062667847; Sun, 11 Jul 2021 21:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626062667; cv=none; d=google.com; s=arc-20160816; b=0JzZsjiDmYr/30bxgyi5odrLTdRg1PJghGoN9GHqeixbzg3UqOgzHyCdTfbLR2mX8F Ac00DREm9xmsDGHiw3q4OLBqtFloWuGlw+3BNWHu1xPAVYTaKoTZcJwtgt/U82p9AU9/ dsdeWVZHFefVE1XxxJb8qU1vkfehmj1DQzEgjbAo0VNMbAVnfKbSO0NOkFD3GcFh7pYQ atLWkXBvYA82pGlFsgrjbdWv/5cTLYHnSt6Rc/cIcV6V5xeuFvwUNgTme5LpusdsivAS FDkMl8G4fiZ/FT7DfoaCiq90q5lRdDCiZewaTclg6taH/ifmHZVi7vr3EoWculN3Wh5G Iw3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D1HowpT1gxnF9kAzU5JMzfIgQy89IyYzAww8rxSf4K8=; b=Ij6zeTrhuUI8ulfX8rpsYatKfTj8vNOanLbRJ/fXufxbuy3IHgK7JsduzF8yLS1Usb jbgMdZsuzzQPqtirueyfzeFCCvmsoUQ13utvqQ0U3hauDXZB6iUf02WideKaI8Qad6pg I6T4xolRIAsYRTtk6R26xi3dqoF5YK+A8i3Nkf/H09EFcJhfc1GyYLTWVBqzaaIRMj1x c32nLfjqHAIzX77jW6X7LFJyDFS4ofOqZIL5iFg6/lk6DjeL4bZqm5kf/a1M/JPudhxH P/dDBwrElKwIDyaHyQOkcb0GX/C52rla8b6K/CSHJYzk95EObPk9BaTyNmFVxt6jNaM4 4E9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qTJiH1qd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 24si16262260ejw.232.2021.07.11.21.04.05; Sun, 11 Jul 2021 21:04:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qTJiH1qd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbhGLEE5 (ORCPT + 99 others); Mon, 12 Jul 2021 00:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231589AbhGLEEm (ORCPT ); Mon, 12 Jul 2021 00:04:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9680C0613E5; Sun, 11 Jul 2021 21:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=D1HowpT1gxnF9kAzU5JMzfIgQy89IyYzAww8rxSf4K8=; b=qTJiH1qdJ+FMxvOcFEfAlZKO+M yQbcV2YIxqSM1z6ATloZL401BXjw5OBuanlDDqRAm1b4zeF4WgQHHJQNHKretQ74gQA5kWYTdfMNM VKPk2Hjq7VLPQepdRP3KTkmvA648/6nwxYy8jVwMaAN3YPXQHD6QN3CsTIvcioh+bBUEksYkwILaJ KLF64ZxAFnpCn/cuPnJXS/KidlaD4tQPuYp4aS4BCxjefqM78KucAbnhYO49lflYxmrXJ0vLc90WI rzG4IyGrGjjpdfUiRtq3iWSC2RoN5Bj4BcXlDFH138HBqtR6a1HzdYHx9g9UUExhaUdBHTBZJta1B IFXdc16g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2n81-00Gqbq-02; Mon, 12 Jul 2021 04:01:16 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v13 103/137] iomap: Convert iomap_write_end_inline to take a folio Date: Mon, 12 Jul 2021 04:06:27 +0100 Message-Id: <20210712030701.4000097-104-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210712030701.4000097-1-willy@infradead.org> References: <20210712030701.4000097-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Inline data only occupies a single page, but using a folio means that we don't need to call compound_head() in PageUptodate(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/iomap/buffered-io.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index aec28781c773..0336427b723b 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -662,18 +662,18 @@ static size_t __iomap_write_end(struct inode *inode, loff_t pos, size_t len, return copied; } -static size_t iomap_write_end_inline(struct inode *inode, struct page *page, +static size_t iomap_write_end_inline(struct inode *inode, struct folio *folio, struct iomap *iomap, loff_t pos, size_t copied) { void *addr; - WARN_ON_ONCE(!PageUptodate(page)); + WARN_ON_ONCE(!folio_uptodate(folio)); BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data)); - flush_dcache_page(page); - addr = kmap_atomic(page); + flush_dcache_folio(folio); + addr = kmap_local_folio(folio, 0); memcpy(iomap->inline_data + pos, addr + pos, copied); - kunmap_atomic(addr); + kunmap_local(addr); mark_inode_dirty(inode); return copied; @@ -690,7 +690,7 @@ static size_t iomap_write_end(struct inode *inode, loff_t pos, size_t len, size_t ret; if (srcmap->type == IOMAP_INLINE) { - ret = iomap_write_end_inline(inode, page, iomap, pos, copied); + ret = iomap_write_end_inline(inode, folio, iomap, pos, copied); } else if (srcmap->flags & IOMAP_F_BUFFER_HEAD) { ret = block_write_end(NULL, inode->i_mapping, pos, len, copied, page, NULL); -- 2.30.2