Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Robin Gong <yibin.gong@nxp.com>
To:     Lucas Stach <l.stach@pengutronix.de>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>,
        "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
        "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
        "matthias.schiffer@ew.tq-group.com" 
        <matthias.schiffer@ew.tq-group.com>,
        "frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>,
        "m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
        Clark Wang <xiaoning.wang@nxp.com>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 on
 i.mx6ul
Thread-Topic: [PATCH v14 09/12] dmaengine: imx-sdma: remove ERR009165 on
 i.mx6ul
Thread-Index: AQHXK33uJvhJxunKh0O/L1opU5bMLas69yaAgARURRA=
Date:   Mon, 12 Jul 2021 04:03:03 +0000
Message-ID: <VE1PR04MB6688F74F67882E3DC26495E489159@VE1PR04MB6688.eurprd04.prod.outlook.com>
References: <1617809456-17693-1-git-send-email-yibin.gong@nxp.com>
         <1617809456-17693-10-git-send-email-yibin.gong@nxp.com>
 <3ade0741d94e53eb2bca86743ad11e55899381d7.camel@pengutronix.de>
In-Reply-To: <3ade0741d94e53eb2bca86743ad11e55899381d7.camel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XgfR5w7BoZEDAd54+dH3/THIRiu7V+drHk6/Qx3DKD/WidU7HgrC/I9yi21m?=
 =?us-ascii?Q?O77PrK/hHLL3I6I+BbNK8auHkxLJaRbm3pFIbagfABSjed9Pbs7UQmgQFaYV?=
 =?us-ascii?Q?yYgWOTU0HY2A9b9bA8ZZntsNuypbKnYsTTp2Hd0iTZNfVDtmJVxDNeujmJRQ?=
 =?us-ascii?Q?I04amUxjijK0BjIEEdlJNMwNXI5fH+edudE3cfs4uTjJchkTYRLwc2FZaSGv?=
 =?us-ascii?Q?VPYVAskOMs0I1umgXdzRWVqxhk3SFqUOyQrgvYLHoowv//vz9+li6GcEr1Cd?=
 =?us-ascii?Q?yuhqhWrZwbQglp6CTQWVAVia8UsLE7XThd5u9y2/HdwdmuFvRKqjSkk4ck5w?=
 =?us-ascii?Q?n8RB/OVZlkCnCKiBXMv5ASOHmJgcofqjgScpclr3cZdksSx57XqfOt+Cas0V?=
 =?us-ascii?Q?P7BRJluY1eyz3lZEqyhjuf9IzzLxAZAihwM0xQhm/4d5JSwdHV+YyqVJ6v/R?=
 =?us-ascii?Q?yqaq7zaPLSd1Xism5PW6R7ju6h6rJ3YIgwwK3Zkkm5MPrAnMNx4i8FLzwoTk?=
 =?us-ascii?Q?Z0ZmgaM5ZGk2RyARP9oFrzdihvIaF7BjLaaWfFAFJs1r2l8YGre3kmmQVe0S?=
 =?us-ascii?Q?qpxAO5Kzxk4D71BmrIEg42CMSdT1Bdi32Q0AQ5Qpgx8mBieKXFFITrBRYsXB?=
 =?us-ascii?Q?Y4i3lYvJpVv5OlwiyLDGSLLBVjI39rV7IgyE8iW9hXyurZ2rVSFgmKL+Cvka?=
 =?us-ascii?Q?jfQqiY4bKwwepkBncwFpAKbn4W8tydD/aJ5B7OUS8sxrVrpHKBUioPnofA9g?=
 =?us-ascii?Q?9TZQHeowNfHbv3EtSgqnu6V4FIaEYiH3V9FvyPtWygaFwv93Hy5XVru0qYnM?=
 =?us-ascii?Q?VsN1RuSKn2Nq6CD0pmiORzAQv3Qebr/PQUE9+mjpTKerMujGAfolSaC0SZNL?=
 =?us-ascii?Q?UjKwLDDgJbKfbhNjr1PvZeWrl9RVRbOp5WSVcJnjplayiTRcbwPFP4307h6W?=
 =?us-ascii?Q?MUZP94zF9WbmOUy9tnXVeHFYYHoWGruzr8xAT2jbbTBMDyNPeuwUibB3thiv?=
 =?us-ascii?Q?/o8jsQeHoroyZwfEX5DDVSwIGVM5UWBvOwYtJvhTPkN9kAKn0lno46z90IFu?=
 =?us-ascii?Q?8KLTZnKWfh1/sYck/nm/mWu2aF4HTsoBKrCXfidj7WVNlQvmpCA8rvGCLzYy?=
 =?us-ascii?Q?NLq0IoZoYZ+8dXHrraV6vrS42NKRt+8gtl6vv8Iber0WfyX77UBNmf89BedV?=
 =?us-ascii?Q?75QogG4zlC+kxL2PBm7gGfQGpMtGXdQuSJYZFKsj35o/hVTTLepf1Jm0Zx7t?=
 =?us-ascii?Q?sOcVeWWECq5/+epCAswdDpKrJKgyutUrFQVtLQACxdYssBmWaMh5g9eCbEEw?=
 =?us-ascii?Q?yqZMNXOwBNyGxSnCHDBUu53O?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6688.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7020ea24-a85c-48f9-6c7a-08d944e9f278
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 04:03:03.4573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GlW0+lHqk/YHD6ACBoMXMAXIrLJnFIbzcbOsZ16qFWM6fZzwz8hFgpbbAbHjgD/nNcpVx587//NvIiAJ4JQc8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2670
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/07/21 17:45 Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong:
> > ECSPI issue fixed from i.mx6ul at hardware level, no need
> > ERR009165 anymore on those chips such as i.mx8mq.
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > Acked-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  drivers/dma/imx-sdma.c | 26 +++++++++++++++++++++++++-
> >  1 file changed, 25 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index
> > 86bd383..af85116 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -422,6 +422,13 @@ struct sdma_driver_data {
> >  	int num_events;
> >  	struct sdma_script_start_addrs	*script_addrs;
> >  	bool check_ratio;
> > +	/*
> > +	 * ecspi ERR009165 fixed should be done in sdma script
> > +	 * and it has been fixed in soc from i.mx6ul.
> > +	 * please get more information from the below link:
> > +	 *
> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww.n
> xp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&amp;data=3D04%7C01%7C
> yibin.gong%40nxp.com%7Cc950b1bdb6544eda369408d942be35d9%7C686ea
> 1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637614206980361737%7CU
> nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6
> Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=3D6iT6%2FbzJHyWnkhkDynY
> wmK9nn2hgCDy1GyzELeEk9K8%3D&amp;reserved=3D0
> > +	 */
> > +	bool ecspi_fixed;
> >  };
> >
> >  struct sdma_engine {
> > @@ -542,6 +549,13 @@ static struct sdma_driver_data sdma_imx6q =3D {
> >  	.script_addrs =3D &sdma_script_imx6q,
> >  };
> >
> > +static struct sdma_driver_data sdma_imx6ul =3D {
> > +	.chnenbl0 =3D SDMA_CHNENBL0_IMX35,
> > +	.num_events =3D 48,
> > +	.script_addrs =3D &sdma_script_imx6q,
> > +	.ecspi_fixed =3D true,
> > +};
> > +
> >  static struct sdma_script_start_addrs sdma_script_imx7d =3D {
> >  	.ap_2_ap_addr =3D 644,
> >  	.uart_2_mcu_addr =3D 819,
> > @@ -575,6 +589,7 @@ static const struct of_device_id sdma_dt_ids[] =3D =
{
> >  	{ .compatible =3D "fsl,imx31-sdma", .data =3D &sdma_imx31, },
> >  	{ .compatible =3D "fsl,imx25-sdma", .data =3D &sdma_imx25, },
> >  	{ .compatible =3D "fsl,imx7d-sdma", .data =3D &sdma_imx7d, },
> > +	{ .compatible =3D "fsl,imx6ul-sdma", .data =3D &sdma_imx6ul, },
> >  	{ .compatible =3D "fsl,imx8mq-sdma", .data =3D &sdma_imx8mq, },
> >  	{ /* sentinel */ }
> >  };
> > @@ -1144,8 +1159,17 @@ static int sdma_config_channel(struct dma_chan
> *chan)
> >  			if (sdmac->peripheral_type =3D=3D IMX_DMATYPE_ASRC_SP ||
> >  			    sdmac->peripheral_type =3D=3D IMX_DMATYPE_ASRC)
> >  				sdma_set_watermarklevel_for_p2p(sdmac);
> > -		} else
> > +		} else {
> > +			/*
> > +			 * ERR009165 fixed from i.mx6ul, no errata need,
> > +			 * set bit31 to let sdma script skip the errata.
> > +			 */
> > +			if (sdmac->peripheral_type =3D=3D IMX_DMATYPE_CSPI &&
> > +			    sdmac->direction =3D=3D DMA_MEM_TO_DEV &&
> > +			    sdmac->sdma->drvdata->ecspi_fixed)
> > +				__set_bit(31, &sdmac->watermark_level);
>=20
> Hm, I don't care much either way, but couldn't we just return the regular
> mcu_2_app script in sdma_get_pc when ecspi_fixed =3D=3D true? Seems like =
this
> would be a simpler and more targeted code change.
Yes, return mcu_2_app if ecspi_fixed =3D=3D true also works, but since sdma=
 firmware
have already been here to fix ERR009165 on most of legacy i.mx6/7/8 chips, =
so choosing
firmware/ram script to do like ROM/mcu_2_app is okay too since both ram scr=
ipt and rom
script in case of ecspi_fixed are almost same.

>=20
> >  			__set_bit(sdmac->event_id0, sdmac->event_mask);
> > +		}
> >
> >  		/* Address */
> >  		sdmac->shp_addr =3D sdmac->per_address;
>=20