Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2642383pxv; Sun, 11 Jul 2021 21:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIA/jbiq/7C9OLvZyca12Wbwk7yeGkcGDveq6NWa8+pr9ZvB2UlS/QdcJvfwlc/iFs5pJ8 X-Received: by 2002:a05:6638:3594:: with SMTP id v20mr41903278jal.25.1626063132509; Sun, 11 Jul 2021 21:12:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626063132; cv=none; d=google.com; s=arc-20160816; b=GsR0RWhqHpsEjHZHwHKN59FIRB3U2DynpWtKpuO0g8ybVVJ/P0rFDnfc0sHmPjOTh+ FOhCZl5Dq9MUO7IMlciVxHshqdtsa7ceEJsIVMyDkk+k/UO5fp/StT/3K6RINZur20Sf Zilwtq2Oq5R8snP6CmL6aODqskE9UcyNzTkS/e/tm0ligBfukjb8Ozls+AmPa+W9Z9+w l1X1ejvxiZO52LoOrJtDBiyQrgBfy+bBpFcCOFBE76t2a9eg1rZ2BQml3ZK8487Pio2Q hqLpSs4yk59QiRf3iEIQYFaLH5h6wYv+WpC0Eo+gXoeCKRKEnW++LKhZW0GnabZ4LrDY g3Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9yhwgjtp0/wX0Hn1pGrvOzLxkSolV7oLUpxeTzzP2kI=; b=I0bB5lOLR6+qD/UCZKIDK+5Me2z94tKuyJ6q1L2QsbUm4y84K30DH6X+gs8c2Xq8Ga ZY7eetQGWLjNItkYVUoQdDh/W/Zh5ZRe7c0ci33uHiJPsIROyogfQt1WsqP+R3uZjNK+ VmTtg63hrWNLUyr+EYwiXNbOP5cTv0ynSEkyLBAo72CtetrEKY5egyXvmZkv+311sSEa /yZO4HH3280hMdy/7x5ua92R2BAFJ+OIRd4cdiYGIv1esM2RrTodquM0igvOQs5RviU/ fnuhv6BjdDDQMQkmq7Qbyw6CeOYzRoG0YJ1Bs+SzhJf1WVrD1mQp1s8WZWQ8IPsfcosx /MeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UW30sXKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si15659675jad.111.2021.07.11.21.12.01; Sun, 11 Jul 2021 21:12:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UW30sXKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbhGLENt (ORCPT + 99 others); Mon, 12 Jul 2021 00:13:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbhGLENt (ORCPT ); Mon, 12 Jul 2021 00:13:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03789C0613DD; Sun, 11 Jul 2021 21:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=9yhwgjtp0/wX0Hn1pGrvOzLxkSolV7oLUpxeTzzP2kI=; b=UW30sXKj7aHH30b6jbziSvy3P2 vOcl6YTGy1a3AbP98rA40xIXpkkWqFjuiJUSrtM6oPHOtYsjmMiWh2w20LsgQ/Gc4Tt5hd38CKeNg RlokuaNpngG7gjUw3YFo+2p7tYOvel7mL9DpaIa8nqYKVZsrvt5zxJTjWTk9FnZuWS88K/e6YH/ni ht/hYAWU2UuYarhxCEc1cwCdWk2+gTyBqQH4RR7xdCUA+bBlXt9uiSRgt5kfpxrYNHOm8tbLjw4cq p2NtyOi7vCcCqroULkTFRa3fUJOWCb55mqpJ0lfP0fB75C1E4KNgPCcFEHMaFnkY1IOr9yKqc/6J3 KmWfvI5w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2nGU-00GrFT-AQ; Mon, 12 Jul 2021 04:10:16 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v13 120/137] mm/filemap: Remove PageHWPoison check from next_uptodate_page() Date: Mon, 12 Jul 2021 04:06:44 +0100 Message-Id: <20210712030701.4000097-121-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210712030701.4000097-1-willy@infradead.org> References: <20210712030701.4000097-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pages are individually marked as suffering from hardware poisoning. Checking that the head page is not hardware poisoned doesn't make sense; we might be after a subpage. We check each page individually before we use it, so this was an optimisation gone wrong. Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 9da9bac99ecd..9a6550c8b7c7 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -3127,8 +3127,6 @@ static struct page *next_uptodate_page(struct page *page, goto skip; if (!PageUptodate(page) || PageReadahead(page)) goto skip; - if (PageHWPoison(page)) - goto skip; if (!trylock_page(page)) goto skip; if (page->mapping != mapping) -- 2.30.2