Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2705175pxv; Sun, 11 Jul 2021 23:17:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7vbkW6ZsRh0luhNMjBUqOZmTCNDUCkIfB9iGjmlMwfYZGiu9A3Z+FL1I71wJ35zg/cK+C X-Received: by 2002:a92:cf4d:: with SMTP id c13mr1233020ilr.240.1626070641503; Sun, 11 Jul 2021 23:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626070641; cv=none; d=google.com; s=arc-20160816; b=uCCRYuiZtAA6QOelDA/fbXK/wM3y2A1zCxOvNy3a/dqHtO8i9sLyVQ3N/Y/0O9N3JZ 8IkxcM777H1hEtTuvkzcgvAcCzG1P4o5S4FPo1JlOxZKli2qaYa6yxORCN+m1lxZy3HY KxtQWDXyJgqbaTltqfaFN8kKVP/67C7vGnVHyTYXaIM2KWmM7eK4i0l1GW1sdRvShVL1 Zra72nbMD9ed/OpgouF2WTF9KmveAJJRiMxjZY/r7vskafKK2lGvHFdiny+JRyChaqKw PJkmqpe+K+eoOVa3DWXkusU9eHjPjGh4WKi0CFo4td8tDilZlS78tm6tefvLEM5npWvO aJTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vUHgRsb2zntRPdt4fg8JKf0FVGU0vbjvYnU7tWxFFGc=; b=GWsIZFQNgBmfiIsxv39JVrzmnPskd5dGSDl1O3UxIVOyYGjxqkHH1+fQKXVQVceLN4 pmBuDGEKAxzJ8gs3BuWSbAaaDfeYxSu/kosjNECf/dTJMDXAtInloHsOR8zKBQXQzkYg DU/O4EQ1NmkCE+zf4yYfr+uDyJoH9VLO+jGuz0D9dBTiYZ8zRwRYKwkinrpVnWJYn/zo 5/kVd/LfoLrgH2dtSJl+v5UXun32mIaCfu3k/qCxryhyz8K4QVFw8eB+xcQawHzOC7Oe utcJJ5PxKMNgdDfhUsQ6Jd1fWVOYu9YQZzLok+CaptGUHcsdEEoRRdoZqk795zQ/z2h1 cWMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0aZK06+M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si18196346iln.128.2021.07.11.23.17.10; Sun, 11 Jul 2021 23:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0aZK06+M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbhGLGSJ (ORCPT + 99 others); Mon, 12 Jul 2021 02:18:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:36434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233472AbhGLGSF (ORCPT ); Mon, 12 Jul 2021 02:18:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7DC53610A6; Mon, 12 Jul 2021 06:15:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626070518; bh=h+k84+0MbyDGgViUk+0tb+vj69tJF6UgaHARYATaxGQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0aZK06+MMxx2rEqWmWXvGuVGIcZwrxnP4ujto++eZFL160l0JYTgsDp9N1Xdvi+jA Cf3P3r6aUUpN+ay6gdtlOCug5QZQ2rvYrLD/ttkNDDI61RffqR76+SYS8ZBfeVXTPg b0vN082T/3Qeyy2es88uxGCpdv1jRHjtDRyWfNjY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Senozhatsky , Takashi Iwai , Max Filippov Subject: [PATCH 5.4 004/348] ALSA: intel8x0: Fix breakage at ac97 clock measurement Date: Mon, 12 Jul 2021 08:06:28 +0200 Message-Id: <20210712060700.578904441@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060659.886176320@linuxfoundation.org> References: <20210712060659.886176320@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit 24d1e49415be546470b20429d748e240d0518b7e upstream. The recent workaround for the wild interrupts in commit c1f0616124c4 ("ALSA: intel8x0: Don't update period unless prepared") leaded to a regression, causing the interrupt storm during ac97 clock measurement at the driver probe. We need to handle the interrupt while the clock measurement as well as the proper PCM streams. Fixes: c1f0616124c4 ("ALSA: intel8x0: Don't update period unless prepared") Reported-and-tested-by: Max Filippov Tested-by: Sergey Senozhatsky Cc: Link: https://lore.kernel.org/r/CAMo8BfKKMQkcsbOQaeEjq_FsJhdK=fn598dvh7YOcZshUSOH=g@mail.gmail.com Link: https://lore.kernel.org/r/20210708090738.1569-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/intel8x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/intel8x0.c +++ b/sound/pci/intel8x0.c @@ -715,7 +715,7 @@ static inline void snd_intel8x0_update(s int status, civ, i, step; int ack = 0; - if (!ichdev->prepared || ichdev->suspended) + if (!(ichdev->prepared || chip->in_measurement) || ichdev->suspended) return; spin_lock_irqsave(&chip->reg_lock, flags);