Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2718804pxv; Sun, 11 Jul 2021 23:43:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTod5YpzRYZvY9U1kBBGy6lonr4iLWh1BVFACufSxI17ieIQVYZlm/E+SlmNMaQ0J84dQp X-Received: by 2002:a17:906:3042:: with SMTP id d2mr51755730ejd.234.1626072208736; Sun, 11 Jul 2021 23:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072208; cv=none; d=google.com; s=arc-20160816; b=IwhVbvYG7iGUKn02rWefUq1hl7M/CCgVNtTBajyshBrj0PdT4pC9qk/qTEzjGCV+D1 SM5ttb9p0yI1Y0WUziwLN8hxI6aU/lQgbLpm4igBxfC4WbdPLChu29GBL/RJQd0zjjW4 2fDrQ2HYynoadNxfZ3z+i1+QmnaYFOylcbUbGQBx6iGc9c6CGt2BpPX6G6wrMXR0ooSo 3pLLmHblV470LFE/BhseAwEgcPECJptXAvflYMhUyPBDXbFfkoQKZzMlkLaJN2kCjRRb aJbZtUwjNT4cdx33GKw9DcIGiYYM4CFhCTpew9jzBKFSAfSSy6URUiaezKSlXKZFCWdN ifdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ey3dQfsyITGdJi0/NdlcJF/6wjZG7Y9Ul6r+OTuY3Dc=; b=U8CrbtkmxL1EF6khgwYtuhTY1VYJ/MUZlHJD4WQKLbMbiU+q/YyG7g511xfx+Y9E0a jxmKkgwQ7YbvL05HK/J5D8UHVyx1VIxOF4t/c9+hL+Jl3AL/IgJLPzXWADj/Ay+imQSc nfJML2EycMYAfrC/3o/aqNc1GqmwRMK/f+/fQO/kycU57Hag0Ww2uX+A8D/j/2iU1RIH 9+bWeD2Dl45VTU7+OqK7KbUoQoXcbF6lFNNl5bg/DgJbzCj41qYseqQaYHic68RPjbGw O/MdjJqHpFQ/Qb+WURulV1jdQqvSr2ZluuTscN7ENTK2Rc3+ktYls/0CC0NWH/1ZkJ9z c1Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sF1JJSSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si16941216edc.575.2021.07.11.23.43.06; Sun, 11 Jul 2021 23:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sF1JJSSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238828AbhGLGoW (ORCPT + 99 others); Mon, 12 Jul 2021 02:44:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:55328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236801AbhGLGeI (ORCPT ); Mon, 12 Jul 2021 02:34:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59AAC61153; Mon, 12 Jul 2021 06:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071417; bh=sN1qtnxFJTNFvnk+A9T/qOmTGxsHwCVsW8zFjj/i2sE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sF1JJSSYBnLh6W+EUqbxFk4VxD8wInEEkA33nCdtyQl2C0QCJnINkl/j1H9Nfmj/p dfQMpfIH4E9mQ6eTv692uHHJTurZ975SQfY8AJMbKBUsk5ULN4GQEYbHse22rptbDQ sgpCRu+hW/pDsUx1245/OvqJ8q4EkOO2GhWQ7abQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jack Pham , Minas Harutyunyan Subject: [PATCH 5.10 024/593] usb: dwc3: Fix debugfs creation flow Date: Mon, 12 Jul 2021 08:03:04 +0200 Message-Id: <20210712060845.853357606@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Minas Harutyunyan commit 84524d1232ecca7cf8678e851b254f05cff4040a upstream. Creation EP's debugfs called earlier than debugfs folder for dwc3 device created. As result EP's debugfs are created in '/sys/kernel/debug' instead of '/sys/kernel/debug/usb/dwc3.1.auto'. Moved dwc3_debugfs_init() function call before calling dwc3_core_init_mode() to allow create dwc3 debugfs parent before creating EP's debugfs's. Fixes: 8d396bb0a5b6 ("usb: dwc3: debugfs: Add and remove endpoint dirs dynamically") Cc: stable Reviewed-by: Jack Pham Signed-off-by: Minas Harutyunyan Link: https://lore.kernel.org/r/01fafb5b2d8335e98e6eadbac61fc796bdf3ec1a.1623948457.git.Minas.Harutyunyan@synopsys.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -1590,17 +1590,18 @@ static int dwc3_probe(struct platform_de } dwc3_check_params(dwc); + dwc3_debugfs_init(dwc); ret = dwc3_core_init_mode(dwc); if (ret) goto err5; - dwc3_debugfs_init(dwc); pm_runtime_put(dev); return 0; err5: + dwc3_debugfs_exit(dwc); dwc3_event_buffers_cleanup(dwc); usb_phy_shutdown(dwc->usb2_phy);