Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2729742pxv; Mon, 12 Jul 2021 00:05:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5J9t0TDSu4L6RYiVZvbyMrpgRaaL02rXw7V8BqrE0I9Jq/TP2i0mPkwistxV0XjmVrIVw X-Received: by 2002:a6b:f013:: with SMTP id w19mr14731300ioc.182.1626073513499; Mon, 12 Jul 2021 00:05:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626073513; cv=none; d=google.com; s=arc-20160816; b=NKpx5Y4gb7fRQSBHFxOoCrCufPbA4jPizhb3pmXQSlP2RO4AnLHeUDaKY4hPQsFzgz 3GYz+alNB6cUjCEckT3hxhkK0V8Oo5CpgI0wH3r/maEXUja93407zW8YtCxZfTcXzM7X Pmj0fZCJD3ExzpvRMyGx8mhgEudZfozVFFHY3lfpqE7EuGvZCi6Gti43/IdKPLQh0rUP NlFuvzOSiWhDRJtua/5AAIDopzJkwWw1T0YZdUbE0YSI02yUTLffvx05u6kJdRELhdTi 1GLWJfyzW2FuFKqnIV29tJH5sW2RoMB2HInw3hNqksjhpGx6yaCc+In4Tb4ldbXJ+iyH jr1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0t757Q731Sf5NRJwe8ns4ZynULNHpgJZUzDKQ9t2zDg=; b=ISyFXU6MlZZfpbjN+LxstepfJblmdoKd1YvqG/LR5JqSVeRXcaT9aMTZiG4ODAbQJb UpEh1ENpSVPl11beHeMCm95TcOpt2Cn6GqgCCrGIqp4zCGP/mQbVPxf6p0SeUGDdvLx2 psHOPy0H4etb8oZY4A4c7Rd/l44VPe/PAaqTCroCDoeUsw9LDS8ZKKx6Cwnc62J32QZN mrsQQC228Wz8SSx9HqKvjsN5vfN/9MQdCKM39QVEUcDqdtsi3KDUAkCCAJb5V1smXdaq 6oE6XIzsZGUIimpnJu6lxdpkuWF0f3a8cGwi0eUdBwk44Q1XuP80uw+ecYkypwBV8ZcI JJvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hYNU4CYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si6623ilq.114.2021.07.12.00.05.01; Mon, 12 Jul 2021 00:05:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hYNU4CYe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243859AbhGLHFV (ORCPT + 99 others); Mon, 12 Jul 2021 03:05:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:41506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236049AbhGLGri (ORCPT ); Mon, 12 Jul 2021 02:47:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 05E21610FA; Mon, 12 Jul 2021 06:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072203; bh=x9+c3LOph455NyjWUC6pvwlt27UKYetqTM4PfvRT/ME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hYNU4CYexAQYBwJB0V/tR3sU2n9c9dbCBD562f0DjsuxMWl9MjAtx3/fR+rNKrkbo MHo6OIMhveLMd3D0V1hzjtqU+AS/N2xAWuuAs7XlgpveWP6BhVqjrOUO121GJTkNNa td7+bdGhUSAZVsct9THHStzaYQK8pv/SS6F3R0ho= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cristobal Forno , Abdul Haleem , Dany Madden , Sukadev Bhattiprolu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 399/593] Revert "ibmvnic: remove duplicate napi_schedule call in open function" Date: Mon, 12 Jul 2021 08:09:19 +0200 Message-Id: <20210712060931.437017798@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dany Madden [ Upstream commit 2ca220f92878470c6ba03f9946e412323093cc94 ] This reverts commit 7c451f3ef676c805a4b77a743a01a5c21a250a73. When a vnic interface is taken down and then up, connectivity is not restored. We bisected it to this commit. Reverting this commit until we can fully investigate the issue/benefit of the change. Fixes: 7c451f3ef676 ("ibmvnic: remove duplicate napi_schedule call in open function") Reported-by: Cristobal Forno Reported-by: Abdul Haleem Signed-off-by: Dany Madden Signed-off-by: Sukadev Bhattiprolu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 8cc444684491..765b38c8b252 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1166,6 +1166,11 @@ static int __ibmvnic_open(struct net_device *netdev) netif_tx_start_all_queues(netdev); + if (prev_state == VNIC_CLOSED) { + for (i = 0; i < adapter->req_rx_queues; i++) + napi_schedule(&adapter->napi[i]); + } + adapter->state = VNIC_OPEN; return rc; } -- 2.30.2