Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424645AbWKPVYz (ORCPT ); Thu, 16 Nov 2006 16:24:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1424641AbWKPVYy (ORCPT ); Thu, 16 Nov 2006 16:24:54 -0500 Received: from mail.timesys.com ([65.117.135.102]:50088 "EHLO postfix.timesys.com") by vger.kernel.org with ESMTP id S1424639AbWKPVYx (ORCPT ); Thu, 16 Nov 2006 16:24:53 -0500 Subject: Re: [patch] cpufreq: mark cpufreq_tsc() as core_initcall_sync From: Thomas Gleixner Reply-To: tglx@timesys.com To: Andrew Morton Cc: Ingo Molnar , Alan Stern , LKML , Linus Torvalds , john stultz , David Miller , Arjan van de Ven , Andi Kleen In-Reply-To: <20061116132058.4c541bde.akpm@osdl.org> References: <1163707250.10333.24.camel@localhost.localdomain> <20061116201531.GA31469@elte.hu> <20061116132058.4c541bde.akpm@osdl.org> Content-Type: text/plain Date: Thu, 16 Nov 2006 22:27:36 +0100 Message-Id: <1163712457.10333.44.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 847 Lines: 24 On Thu, 2006-11-16 at 13:20 -0800, Andrew Morton wrote: > > > > -core_initcall(cpufreq_tsc); > > +/* > > + * init_cpufreq_transition_notifier_list() should execute first, > > + * which is a core_initcall, so mark this one core_initcall_sync: > > + */ > > +core_initcall_sync(cpufreq_tsc); > > Would prefer that we not use the _sync levels. They're there as a > synchronisation for MULTITHREAD_PROBE and might disappear at any time. Works also fine with postcore_init, but I'm more concerned about the delayed notification (after the actual change) which is introduced by this srcu change. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/