Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Jul 2021 09:25:16 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, vbabka@suse.cz,
        axboe@kernel.dk, iamjoonsoo.kim@lge.com, alexs@kernel.org,
        apopple@nvidia.com, willy@infradead.org, minchan@kernel.org,
        david@redhat.com, shli@fb.com, hillf.zj@alibaba-inc.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] mm/vmscan: remove unneeded return value of
 kswapd_run()
Message-ID: <YOvuXDc0LrCE+Xk/@dhcp22.suse.cz>
References: <20210710100329.49174-1-linmiaohe@huawei.com>
 <20210710100329.49174-4-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210710100329.49174-4-linmiaohe@huawei.com>
Precedence: bulk

On Sat 10-07-21 18:03:27, Miaohe Lin wrote:
> The return value of kswapd_run() is unused now. Clean it up.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  include/linux/swap.h | 2 +-
>  mm/vmscan.c          | 7 ++-----
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 6f5a43251593..717e6e500929 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -408,7 +408,7 @@ static inline bool node_reclaim_enabled(void)
>  
>  extern void check_move_unevictable_pages(struct pagevec *pvec);
>  
> -extern int kswapd_run(int nid);
> +extern void kswapd_run(int nid);
>  extern void kswapd_stop(int nid);
>  
>  #ifdef CONFIG_SWAP
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index fbe53e60b248..c580bef6b885 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4284,23 +4284,20 @@ unsigned long shrink_all_memory(unsigned long nr_to_reclaim)
>   * This kswapd start function will be called by init and node-hot-add.
>   * On node-hot-add, kswapd will moved to proper cpus if cpus are hot-added.
>   */
> -int kswapd_run(int nid)
> +void kswapd_run(int nid)
>  {
>  	pg_data_t *pgdat = NODE_DATA(nid);
> -	int ret = 0;
>  
>  	if (pgdat->kswapd)
> -		return 0;
> +		return;
>  
>  	pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid);
>  	if (IS_ERR(pgdat->kswapd)) {
>  		/* failure at boot is fatal */
>  		BUG_ON(system_state < SYSTEM_RUNNING);
>  		pr_err("Failed to start kswapd on node %d\n", nid);
> -		ret = PTR_ERR(pgdat->kswapd);
>  		pgdat->kswapd = NULL;
>  	}
> -	return ret;
>  }
>  
>  /*
> -- 
> 2.23.0

-- 
Michal Hocko
SUSE Labs