Subject: Re: [PATCH]: HVCS char driver janitoring: fix compile warnings
From: Michael Ellerman <michael@ellerman.id.au>
Reply-To: michael@ellerman.id.au
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Greg KH <greg@kroah.com>, akpm@osdl.org, Alan Cox <alan@redhat.com>,
       "Ryan S. Arnold" <rsa@us.ibm.com>, linuxppc-dev@ozlabs.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <20061116203946.GA23600@austin.ibm.com>
References: <20061115212619.GJ8395@austin.ibm.com>
	 <1163635387.8805.7.camel@localhost.localdomain>
	 <20061116203946.GA23600@austin.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-f2nqMHLg7qZnR7DtceJq"
Date: Fri, 17 Nov 2006 09:35:36 +1100
Message-Id: <1163716536.16815.5.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2064
Lines: 66


--=-f2nqMHLg7qZnR7DtceJq
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 2006-11-16 at 14:39 -0600, Linas Vepstas wrote:
> On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote:
> > On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote:
> > >=20
> > > This is a non-urgent patch.=20
> > >=20
> > > I can't figure out who the upstream maintainer for char drivers=20
> > > is supposed to be. Can this patch be applied?=20
> > >=20
> > > --linas
> > >=20
> > > This patch removes an pair of irritating compiler warnings:
> > >=20
> > > drivers/char/hvcs.c:1605: warning: ignoring return value of
> > > sysfs_create_group declared with attribute warn_unused_result
> > > drivers/char/hvcs.c:1639: warning: ignoring return value of
> > > driver_create_file declared with attribute warn_unused_result
> > >=20
> > > Doing this required moving a big block of code from the bottom=20
> > > of the file to the top, so as to avoid the need for (irritating)=20
> > > forward declarations.
> >=20
> > Can you do the move and the fix as two patches? It's very hard to revie=
w
> > in its current form.
>=20
> Sorry, coming shortly. -- linas

Thanks, new patches look good.

cheers

--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

--=-f2nqMHLg7qZnR7DtceJq
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQBFXOe4dSjSd0sB4dIRAp6yAJ9IOtdPTDEHa58LPPTw5B+1Fygi7ACdF+no
U44FrY1v6GvSb0yfQxlm6ok=
=89Hn
-----END PGP SIGNATURE-----

--=-f2nqMHLg7qZnR7DtceJq--

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/