Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162344AbWKQE3B (ORCPT ); Thu, 16 Nov 2006 23:29:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1162345AbWKQE3B (ORCPT ); Thu, 16 Nov 2006 23:29:01 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:57911 "EHLO agminet01.oracle.com") by vger.kernel.org with ESMTP id S1162344AbWKQE3A (ORCPT ); Thu, 16 Nov 2006 23:29:00 -0500 Date: Thu, 16 Nov 2006 20:28:54 -0800 From: Randy Dunlap To: lkml Cc: akpm , y-goto@jp.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, kmannth@us.ibm.com Subject: Re: memory hotplug function redefinition/confusion Message-Id: <20061116202854.cbd24bef.randy.dunlap@oracle.com> In-Reply-To: <20061116202520.afcb9224.randy.dunlap@oracle.com> References: <20061116202520.afcb9224.randy.dunlap@oracle.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 58 On Thu, 16 Nov 2006 20:25:20 -0800 Randy Dunlap wrote: > > 2.6.19-rc5-mm2: > > include/linux/memory_hotplug.h uses CONFIG_NUMA to decide: > > #ifdef CONFIG_NUMA > extern int memory_add_physaddr_to_nid(u64 start); > #else > static inline int memory_add_physaddr_to_nid(u64 start) > { > return 0; > } > #endif > > but mm/init.c uses CONFIG_ACPI_NUMA to decide: > > #ifndef CONFIG_ACPI_NUMA > int memory_add_physaddr_to_nid(u64 start) > { > return 0; > } > EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > #endif > > #ifndef CONFIG_ACPI_NUMA > int memory_add_physaddr_to_nid(u64 start) > { > return 0; > } > #endif > > (sic: duplicate function above) > > The CONFIG_NUMA vs. CONFIG_ACPI_NUMA seems to cause this build error: > > CC arch/x86_64/mm/init.o > arch/x86_64/mm/init.c:501: error: redefinition of 'memory_add_physaddr_to_nid' > include/linux/memory_hotplug.h:71: error: previous definition of 'memory_add_phys > addr_to_nid' was here > arch/x86_64/mm/init.c:509: error: redefinition of 'memory_add_physaddr_to_nid' > arch/x86_64/mm/init.c:501: error: previous definition of 'memory_add_physaddr_to_ > nid' was here > make[1]: *** [arch/x86_64/mm/init.o] Error 1 > make: *** [arch/x86_64/mm] Error 2 Actually no flavor of NUMA is set: http://oss.oracle.com/~rdunlap/configs/config-numa-err --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/