Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2824111pxv; Mon, 12 Jul 2021 02:50:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjbuuqXjg1itnVceNxslM0GtyMge1w5jZrkHmu07+olI0IDRorsD/I8xN90iZ8EX0Wc5A8 X-Received: by 2002:a6b:185:: with SMTP id 127mr30981871iob.64.1626083437329; Mon, 12 Jul 2021 02:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626083437; cv=none; d=google.com; s=arc-20160816; b=qj7kZwnthGIQVjR/GjLG6I0NmjKikafS3PmnO0UBG/JsVSmTL5Q7YGlkzxQU6v/s/U sIVmNOmsOFLZMPGDqZFRVdKBoo/CrIHbDAoX6J7wLHbcvfq0uiXWs2ImPEkWXTvXW2oE LZE8m29BoiRYLtrOaY7Xed3jypZ8x70XVVRFPJZVtNWioEoOE8X7jIpRsSat8wjblNY/ le4vBqiC6A/MxTE8639iZ7jhbwLpWOxmXfLheO8o/hNelbTGRxBWQiEqkeSH9ysyquvx XcZML2nqLVrbG2dkLWrMnEGUxzBppbsfQCTTnPA3ubpOI7fUlJV3Xumj94Nr9bD3Mz3k n0XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dPtGj5FicKn4+dFPuRwX9LHnlVPChz3dN+juqYKk9po=; b=aqgyJhzFpPZBQdxPG9wes51nE77+g51mK95OQG/3upLymWUHOPYNr2v9PpQL6NHVVz nZJM3JDrRsfYkMqNt6aj2drZEn0mLVqo6lljeamWEsrETu1jIU2hW7UAex0ereir85XP xNshwmuPSXPxzm45zGv18zPXPED0gYGdagMrFs7rZp36rqwaFJG1gwGpNnquCwNwYmQR J3pS9tjvLOM/D0Mlwq0NMNSxRnYVCK7QUbbYfYoeNXb5jaGZxCF59vzR2GVv/5m6tGOx SEa6K5+jTWE/23s4sUg1tI5OWwAzSZRxLqInW2adsJd0DWX8ENYOUybhP5wrvqUhFuXc mSng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QUXm6etr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d6si16863914ilm.75.2021.07.12.02.50.25; Mon, 12 Jul 2021 02:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QUXm6etr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237036AbhGLGqE (ORCPT + 99 others); Mon, 12 Jul 2021 02:46:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:55302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236714AbhGLGf2 (ORCPT ); Mon, 12 Jul 2021 02:35:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 896FF610CC; Mon, 12 Jul 2021 06:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071555; bh=EKY1OlRJO93TJiFmqfgVZB3HH1bgpwa6v7NyZcI16Qg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUXm6etrK2iO0esrCcGBqoxQzFE/nUL4789gUqEZ74wmW6Ytw9uKCYygXH6fktGYn XMpH3aGRvhc3dUSIyH9U3j56TghBKOH5SH6LP7uWtUYtVAQlvkywpTHQVpmMgf6W5S HcU0mmtpIqd8yFSs5B0lIKoeFj2IG+B6USf2I6x0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 121/593] media: sti: fix obj-$(config) targets Date: Mon, 12 Jul 2021 08:04:41 +0200 Message-Id: <20210712060856.461874391@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mauro Carvalho Chehab [ Upstream commit 56c1f0876293888f686e31278d183d4af2cac3c3 ] The right thing to do is to add a new object to the building system when a certain config option is selected, and *not* override them. So, fix obj-$(config) logic at sti makefiles, using "+=", instead of ":=". Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/sti/bdisp/Makefile | 2 +- drivers/media/platform/sti/delta/Makefile | 2 +- drivers/media/platform/sti/hva/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/sti/bdisp/Makefile b/drivers/media/platform/sti/bdisp/Makefile index caf7ccd193ea..39ade0a34723 100644 --- a/drivers/media/platform/sti/bdisp/Makefile +++ b/drivers/media/platform/sti/bdisp/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_VIDEO_STI_BDISP) := bdisp.o +obj-$(CONFIG_VIDEO_STI_BDISP) += bdisp.o bdisp-objs := bdisp-v4l2.o bdisp-hw.o bdisp-debug.o diff --git a/drivers/media/platform/sti/delta/Makefile b/drivers/media/platform/sti/delta/Makefile index 92b37e216f00..32412fa4c632 100644 --- a/drivers/media/platform/sti/delta/Makefile +++ b/drivers/media/platform/sti/delta/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_VIDEO_STI_DELTA_DRIVER) := st-delta.o +obj-$(CONFIG_VIDEO_STI_DELTA_DRIVER) += st-delta.o st-delta-y := delta-v4l2.o delta-mem.o delta-ipc.o delta-debug.o # MJPEG support diff --git a/drivers/media/platform/sti/hva/Makefile b/drivers/media/platform/sti/hva/Makefile index 74b41ec52f97..b5a5478bdd01 100644 --- a/drivers/media/platform/sti/hva/Makefile +++ b/drivers/media/platform/sti/hva/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_VIDEO_STI_HVA) := st-hva.o +obj-$(CONFIG_VIDEO_STI_HVA) += st-hva.o st-hva-y := hva-v4l2.o hva-hw.o hva-mem.o hva-h264.o st-hva-$(CONFIG_VIDEO_STI_HVA_DEBUGFS) += hva-debugfs.o -- 2.30.2