Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424764AbWKQF2c (ORCPT ); Fri, 17 Nov 2006 00:28:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1162362AbWKQF2c (ORCPT ); Fri, 17 Nov 2006 00:28:32 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:48900 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1162231AbWKQF2b (ORCPT ); Fri, 17 Nov 2006 00:28:31 -0500 From: Herbert Xu To: dtor@insightbb.com (Dmitry Torokhov) Subject: Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb??? Cc: herbert@gondor.apana.org.au, davem@davemloft.net, jesper.juhl@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Organization: Core In-Reply-To: <200611162246.21018.dtor@insightbb.com> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Fri, 17 Nov 2006 16:28:12 +1100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 19 Dmitry Torokhov wrote: > > BUG()s there would be a mechanism to document invariants so next time > someone is looking at the code there are no questions. Well if someone is documenting this then wouldn't a comment (or even a kerneldoc style block) be better? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/