Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2825337pxv; Mon, 12 Jul 2021 02:52:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQV7Scj0DJBxCZn6ER5eI2gJsz/AvTvcKiY12AT7tlvs9MB5HJIMLKZAMaAgesdFTIuY/A X-Received: by 2002:a02:3845:: with SMTP id v5mr43751101jae.119.1626083564157; Mon, 12 Jul 2021 02:52:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626083564; cv=none; d=google.com; s=arc-20160816; b=qmyKwfAwJo+gWVn9YWVm0fpgkUSBvPwZsd6uWhZhRg75W7liSL6GkA5Tq8ClsyESxm 4m5rjCA9YcyAyEryBiaNj2kxSB8ZVrZYH0zn0Htrn6qjajkBQm9ml8rMKHIj2GCFRDHC Iza7up+AdlExz727NFYIIC02shn2m5xfNJMN7rR0Glulitf6emU9kKkcy1J0cPfe/knJ xf2CAz1ozFFl71tYlzr3XW6JE7YV2SBs30wwsF3JMePO+koZ0VktMLvvP5qRaibK9A+x F5HkP5V+1V8uQwyg44T+MSBMy9HE6t7MkoGc/7+ZIhSfv+pFbmEOrNZbgin+ttmSz3KS R67g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PE7VOVQF+w/yQ0uwpn7SJrPUcsJ0sjNImGFJu0jauIQ=; b=zOhmFfG42nKbfSRvAiwyyvH0tZie1wt84uy9EpQ1N6+yE2EKwhazhb/yFfed2WyiTL oYMKc/GvlENL/RlrwBxy3RyCN2GMAhZlpyt7YfJ3FVLOvF1uEfLhBxyoqpWCHiBh2ryJ yW6eW59txa/0oiGm7nIqyRAAynYq7pD53fLnXlT8WTAj28lK8URDAaxpmHbANnxzf/5P 5Zzf6+S90poUiG75pWzco8qYbwS1yHKCWyknuOSCG8+lzvsWH/e4+tA+denuJokYwxlX KU9dNtYOxM4EmX651X4T5SlCl21k2iH6a/xPJdP1f8oXCFWoaKwsaG1wtpnCYHmDk7/E 0TJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fp9dSWiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si7783173ilk.94.2021.07.12.02.52.32; Mon, 12 Jul 2021 02:52:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fp9dSWiN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238885AbhGLGtT (ORCPT + 99 others); Mon, 12 Jul 2021 02:49:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:33546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237370AbhGLGjZ (ORCPT ); Mon, 12 Jul 2021 02:39:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2135761179; Mon, 12 Jul 2021 06:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071705; bh=m3zx+ceVEdckWgNJJueuh3O9BRsErHXlMTL9Bs9H3U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fp9dSWiNL0fSDteD4eKjRzggOd+Wlp22Ycwg/3q9vxh3ShxAMpx7pV6WSa4vxykr0 n+PfG8Fb5zUro6kgxksvS2LwRHtSn8QEx5c2n88od3nihrZQqZIhBL2xwDoisiqHmN 6kymeAtYgDQ1W8CZ1whvY0NBfifkwpb3KdavofM0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Jiapeng Chong , Michael Kelley , Wei Liu , Sasha Levin Subject: [PATCH 5.10 183/593] drivers: hv: Fix missing error code in vmbus_connect() Date: Mon, 12 Jul 2021 08:05:43 +0200 Message-Id: <20210712060903.155930625@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit 9de6655cc5a6a1febc514465c87c24a0e96d8dba ] Eliminate the follow smatch warning: drivers/hv/connection.c:236 vmbus_connect() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/1621940321-72353-1-git-send-email-jiapeng.chong@linux.alibaba.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/connection.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c index 11170d9a2e1a..bfd7f00a59ec 100644 --- a/drivers/hv/connection.c +++ b/drivers/hv/connection.c @@ -229,8 +229,10 @@ int vmbus_connect(void) */ for (i = 0; ; i++) { - if (i == ARRAY_SIZE(vmbus_versions)) + if (i == ARRAY_SIZE(vmbus_versions)) { + ret = -EDOM; goto cleanup; + } version = vmbus_versions[i]; if (version > max_version) -- 2.30.2