Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2825758pxv; Mon, 12 Jul 2021 02:53:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqRLZHKJThAjCC38feK02AK2IV7WWGcIT3WZ9hU+ODYPfn2Uov4CaB6GfsU6Q4r5TZPWDY X-Received: by 2002:a92:3302:: with SMTP id a2mr36861439ilf.62.1626083613311; Mon, 12 Jul 2021 02:53:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626083613; cv=none; d=google.com; s=arc-20160816; b=RhqdtFS+wFxKMleTpcBDg6MXSkO7qaFIo60MreJAgM2H3HSdry6R5HN/NYBdwzYWdC NDZQe9DdfaiXjnR00KIohQqsA1/2SWDbMtsrcbYO/3aI77YSmX98tDvDGsAl+1QRPeYd fzLk2lkoLV3PHGOTq0dZubLfVDb4ot3HOR+Q4HswNPjvNNakHyHagtLHnJssXkAh7Dds j76RSAlXXGkB0c3plgnl6A8b+QNzmti8YDeIshohfG9oadcddMZSgr1mlOuoEb1AWExv kTxgHjqfnVp/svHpP2vyEiPNRPTKLmXodJIuc5ZmeA9GjfCVUulqP5GH4CB2v4amdV30 1x8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=U0CA7eONEaKIUEqvMK4JPeridNcp6BNIfI9EAozvor4=; b=pjkAw3w1OW3F+LgG3KDkU966sD9p5Qwc2Iu5sG9AiJnNAOjDxzPSo8LQ1QBfa74bQX hY9klCQGtXROOGVDkEE29jtIYL57wCk9/bP41FdNfci2Wrb2LJgsmhBahAOUDbOBjlq2 DrlBzCiBuXylfdg1bDXXQOmTGTgsqZs1P1bxYRxLJnw9dPRrkTqTQzMH+LlqQ3qG72gr WBwaOQwxWxvmOW9niQ+B9HlYqoSq0l24eilxSCy5rcXTffgEs+4vTdIu069DA/URva9B alowWJXE0K6exkdPIZLZUX4jHxS3WwhOLZOWrbJj8KXQXgjM/vR88dPdPv53j7qgZ7Jb qgwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VxY11nhb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y18si5245246iow.54.2021.07.12.02.53.22; Mon, 12 Jul 2021 02:53:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VxY11nhb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238519AbhGLGwX (ORCPT + 99 others); Mon, 12 Jul 2021 02:52:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:34398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238394AbhGLGkK (ORCPT ); Mon, 12 Jul 2021 02:40:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6586961108; Mon, 12 Jul 2021 06:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071825; bh=K0RB13v0alRNHwX75C8a5XcddkCCjo9XD092qfbXoss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VxY11nhbQIwCjI7o4b8Zx0/l3/HGJd1T4l7LXH4aP50nDAI2Yze0tOxRAmmk0gOfZ UTJ8HxZQ9CuHuZXpGEIssFc61+OKCgzZFPaw7VfD4y/N3DMFPR3gF+H9YmGU7Co20m DxCF8wMDt0ze/rwccUwtkxKdqWtXBB4fSM49kp1k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 235/593] media: tc358743: Fix error return code in tc358743_probe_of() Date: Mon, 12 Jul 2021 08:06:35 +0200 Message-Id: <20210712060908.748628992@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhen Lei [ Upstream commit a6b1e7093f0a099571fc8836ab4a589633f956a8 ] When the CSI bps per lane is not in the valid range, an appropriate error code -EINVAL should be returned. However, we currently do not explicitly assign this error code to 'ret'. As a result, 0 was incorrectly returned. Fixes: 256148246852 ("[media] tc358743: support probe from device tree") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 1b309bb743c7..f21da11caf22 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1974,6 +1974,7 @@ static int tc358743_probe_of(struct tc358743_state *state) bps_pr_lane = 2 * endpoint.link_frequencies[0]; if (bps_pr_lane < 62500000U || bps_pr_lane > 1000000000U) { dev_err(dev, "unsupported bps per lane: %u bps\n", bps_pr_lane); + ret = -EINVAL; goto disable_clk; } -- 2.30.2