Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2826750pxv; Mon, 12 Jul 2021 02:55:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlfRWmt8MTllFiNw7l5kSG9iLXLn/YemsfFbkVwamsi6Pl+GoRbV/BTDmzurLWO3XD2+b/ X-Received: by 2002:a05:6e02:1d9b:: with SMTP id h27mr3774739ila.23.1626083715975; Mon, 12 Jul 2021 02:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626083715; cv=none; d=google.com; s=arc-20160816; b=Jx5F+i82AqaKL/Q2VStQTmp23wNKxgdErjHoluP0dgo3BaJEAgNK+TRlZqOWBYh75+ pD/R59eXiWkYWnTO6UjgUzOuLsfbFMbp5R29tS6AvGnqVWeU8E2XczI3zbnrN8JRaFFB JIVy6KIHZItQQB0vg6y/EBAe5SFgT8QmZdzsLWi46IF3QS8kssRf47iXTTLD+8qpkI/6 +70ArpTSVl51+KF8hrXGX62mOvfywTu1e/d2QL/M6MPmROJqUxZzuwq7uzsE+uu+YFLi GL1tipQujNSZXgirDITyTEZMVePEL60aIiVjuol9Pj8wytc2RzLXJW8AqGIkXESAl2Tw sGNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9beGqI79+t/OEyGr5CUUhGWt+TgsXWhOt1Rt8K2RHmg=; b=QAPUmj4z5xAwq3TftCgxbv0tsVP5H1eEpfHzBZhG6KNuGfw6AMzUWwOpwqaCk/leZ3 K4zLQPxLxCY9ssVfZ6rm1JNoC1zrCLe/bpwd18aCdUfuxwWkNd0/+U2EX+YVdcXc42o3 o2L+MtRGdCSkLj9MetGPd2JWM+4vmxr07x4i87B+QaxM/FE1fMKOZeQvAyeLDdNUifMt tvsfCJq8hxoCPaPoiIb7Zy7INs5MK6+33btxw1kfFi6JBMV8+1kat4T+OEmYRFxADS56 nu6FZotHMgTLINDP3A5BinwZwKZGUExs1Nh9v/fHvIrFMDxROZpp6xDwJQ4kOF7iF4UL NKkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EIhVCSTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 12si18136240ilz.15.2021.07.12.02.55.04; Mon, 12 Jul 2021 02:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=EIhVCSTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238576AbhGLG5F (ORCPT + 99 others); Mon, 12 Jul 2021 02:57:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:36734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236742AbhGLGlF (ORCPT ); Mon, 12 Jul 2021 02:41:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0D6BA601FC; Mon, 12 Jul 2021 06:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071897; bh=ah73J0cUkajOLCAuOZwOrSk3V2wqOwzt7M7gw3BeJ1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EIhVCSTvRj7d6w+9ykrqM5uzXPuDSmbnkuMTYU5qDP6Ot8jZK15lPSHKSWK2cCTN2 npKDwQCHutnSk8a1lTsjSzY68kUDmRa0XtOQA8WWS3b4KzN8WKT+pRzhEzPesblQnE xck/Vo7W61AenArHV9oGOnMU1ZwexSPwUK2pIick= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Joerg Roedel , Sasha Levin Subject: [PATCH 5.10 267/593] lockdep: Fix wait-type for empty stack Date: Mon, 12 Jul 2021 08:07:07 +0200 Message-Id: <20210712060912.823340442@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit f8b298cc39f0619544c607eaef09fd0b2afd10f3 ] Even the very first lock can violate the wait-context check, consider the various IRQ contexts. Fixes: de8f5e4f2dc1 ("lockdep: Introduce wait-type checks") Signed-off-by: Peter Zijlstra (Intel) Tested-by: Joerg Roedel Link: https://lore.kernel.org/r/20210617190313.256987481@infradead.org Signed-off-by: Sasha Levin --- kernel/locking/lockdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 788629c06ce9..8ae9d7abebc0 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -4626,7 +4626,7 @@ static int check_wait_context(struct task_struct *curr, struct held_lock *next) short curr_inner; int depth; - if (!curr->lockdep_depth || !next_inner || next->trylock) + if (!next_inner || next->trylock) return 0; if (!next_outer) -- 2.30.2