Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2829102pxv; Mon, 12 Jul 2021 02:59:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwv+E78j0vuGki9OWkebldIs1tSOugwu7ZErCtFSACksGBonRZwhEVeiCvObe80LzfnW9O3 X-Received: by 2002:a6b:7702:: with SMTP id n2mr38858588iom.1.1626083955264; Mon, 12 Jul 2021 02:59:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626083955; cv=none; d=google.com; s=arc-20160816; b=wYRJtXoWLBwbs5AjePYALPTFIZhihxgSGSABhN7U+gfar9giYjTkTU0vu1ePUXZ7QD +ILrW6TqhIfGZLNyWk6m/6vWXksfd7MY4r+mjEi7Kw6gj2VFhUIBI63J9T+Lgdtcub8I 1qC8j6W0VPN4Q4q0iwLG8rhjaCa6c6lZuxvyzif9/QGLBh5hK+lWAvbw8H5Z8oGd3aK3 JAIsoatOIEHKI91LcPyOWZ+v+ECHeZiRQ524Y/lH2mSONnfNq7h9KLKuvsxH1O2q0j9b U79VeU7oomG/8QIqF2yUqZAWi7zVDBa1nEO8OCpQ/fw/HkQaYbsph6N2DT5aTgiB40p6 kiYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/JF5MmWvJKQmx/GBPQbQW4v7gI8gsCr6TaCGlDxpDj8=; b=lr80TGM4r622OiFG3H1YMNNDHVnf6XqGUftzxmmuLhc4gAlbe5Mt8UB4b0LPCfyjrb Cpeh8CJndhV3qbUGDpE3D1Quc4yV4E0/S4jgZJouyRmqq2Xvz1s0Yn1rhg9h1X1K3vhV lrSUGvyT7nndcYqLQSDA0l2xD6wEPhDAdPCcBSO4ixkWyepkC3RBj8HOadA7HQo0ikST WacCbbjYnY0CNlQRq91IJzz29Stni4tYsGh8T0ph1UtpHZzO5jarVJ0Y7e5UkxxOmXqm MHw14ypN6eL1pkgBtzSz+lKIgAqtdJpIvfPtayedQe5tWxOT+4M8JdhXlI2uOWPdzclZ Zn6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oKGwzF0Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si19327973ilm.45.2021.07.12.02.59.02; Mon, 12 Jul 2021 02:59:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=oKGwzF0Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240951AbhGLHCX (ORCPT + 99 others); Mon, 12 Jul 2021 03:02:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:41192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236596AbhGLGqI (ORCPT ); Mon, 12 Jul 2021 02:46:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C2F4F6113C; Mon, 12 Jul 2021 06:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072095; bh=Kp+1xGUgv/CiBoWsPqgHBz5hTIJJRLcPsGhwhCzHy8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oKGwzF0YrFm3rj8+wdFvIxFq8+gZVv/OkRDmKeHECFDJdJI1xHh4cxqm/woevb+RY jGBJ2JwBmyudVQViZ8RrFGj2vHnqcOhCDixRs+DX5gaL+sN/NNMlgQ7ptpP/fAZm3g 9PXXNbRF5eQ9dcQslfmsBVfiKSnziGF4fGuj1ha8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Abaci Robot , Yang Li , Kalle Valo , Sasha Levin Subject: [PATCH 5.10 353/593] ath10k: Fix an error code in ath10k_add_interface() Date: Mon, 12 Jul 2021 08:08:33 +0200 Message-Id: <20210712060925.090843801@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Li [ Upstream commit e9ca70c735ce66fc6a0e02c8b6958434f74ef8de ] When the code execute this if statement, the value of ret is 0. However, we can see from the ath10k_warn() log that the value of ret should be -EINVAL. Clean up smatch warning: drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn: missing error code 'ret' Reported-by: Abaci Robot Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine") Signed-off-by: Yang Li Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index f5c0f9bac840..36183fdfb7f0 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -5482,6 +5482,7 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, if (arvif->nohwcrypt && !test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) { + ret = -EINVAL; ath10k_warn(ar, "cryptmode module param needed for sw crypto\n"); goto err; } -- 2.30.2