Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2830353pxv; Mon, 12 Jul 2021 03:00:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbXnWNnPlZeOUtlNtW66/+n53jwBHbLhOQo8nXtKOUqWnoK5+aXj4Xaj2wMOU6mGb8pHCX X-Received: by 2002:a92:1e06:: with SMTP id e6mr37144315ile.258.1626084058763; Mon, 12 Jul 2021 03:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626084058; cv=none; d=google.com; s=arc-20160816; b=RTvcySYsgMRp8mw1+062LOeEszRo6VBW2oYVWF2m0OW474TvY0fgN/Qi6OKxUNacHe zA49w5b8fBrLGyROBw5Hn6JXHa4xqiIRaS0+SvFA+bO6wCC3XAQArZb/3jG/HIENmvEY Tm0mOr08guuTwP5mkCRZ1uAlByWxgqhOJK7eF9lZ0J2jm9gAoKtgHVp3XnM6sZEIv+CP bC6UPESUc7yC0FKU5d2VfM/2BKG4SL+6AtDNcQtLl4RcHFK+gx+4AxHJazBWP6bqY6Hd m9E42N/wHGYvsSX3eGOKV7fqGAjnmwrgCnKqO+wTKctaH2ph2fooZlHxgYMsBiyCOq/5 yw0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OBBG3dFVqVnxJ5H6G9ZHO3MRH5qmt5SC2Msiv0XFFno=; b=HALQPWUmOe460yw2ZQKacWPvr5znAV4Vjj+h8wr5rdn7/Ni/0aqrBXzM+gyN3UDqFv EZnHz6vbFvYXB0UsU4HIjuPpW+jgtyyO8nJGvGmRwhbU7dOnZnOMZspIbm5UcVFXpyrC psqryddJCPfgMxFH10yAoy/Bxy+ku2KRBpuyVOh0Lxpi8BnoPP8il89uWSAWB+69js+y YymilU3xBMo7ojmkQa8WaYmKBORHBnkzX9+MlM3W7CUH1rV1FMBcTlgojg7YY5PULMnj b1bMvN8A7GOWDi5K52f8FxSJaAEE3pLXnchAzA2uDBy/GBtOecSOP5cyIIIykT9vkC5R DevA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KN1mk6aV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t6si18947785iov.63.2021.07.12.03.00.43; Mon, 12 Jul 2021 03:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KN1mk6aV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239168AbhGLHMv (ORCPT + 99 others); Mon, 12 Jul 2021 03:12:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:51170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240418AbhGLGvw (ORCPT ); Mon, 12 Jul 2021 02:51:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62B4F6101E; Mon, 12 Jul 2021 06:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072513; bh=d5bkbVdHx/ooL3Ak9tPp8dI1TFEGE/j/dFpXQNbY4GQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KN1mk6aVZno9nh6hARr4Q0O12Fc/zR6OcoVkG624VsrVpVLYwwCO1b4YKm8Twna2P yesQDZ4GYU7CT5nayr0BhBn3Raz+Lk6t+QkO/oK0u7b2CeZebbZp9lnhlS7yfW5n1N 0ZlKVvtwz4fG6ezKZiQjaM4jX8Waw/V93hOSUVfg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jean-Jacques Hiblot , Andy Shevchenko , Pavel Machek , Sasha Levin Subject: [PATCH 5.10 479/593] leds: class: The -ENOTSUPP should never be seen by user space Date: Mon, 12 Jul 2021 08:10:39 +0200 Message-Id: <20210712060943.223327461@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ] Drop the bogus error code and let of_led_get() to take care about absent of_node. Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver") Cc: Jean-Jacques Hiblot Signed-off-by: Andy Shevchenko Signed-off-by: Pavel Machek Signed-off-by: Sasha Levin --- drivers/leds/led-class.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 131ca83f5fb3..4365c1cc4505 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -286,10 +286,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev, if (!dev) return ERR_PTR(-EINVAL); - /* Not using device tree? */ - if (!IS_ENABLED(CONFIG_OF) || !dev->of_node) - return ERR_PTR(-ENOTSUPP); - led = of_led_get(dev->of_node, index); if (IS_ERR(led)) return led; -- 2.30.2