Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2831851pxv; Mon, 12 Jul 2021 03:03:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoZ44i9FsgikFKRVaLHdP+qZZVEjwaCmeE6ASFLCTQg47q5wzVZcVwgz48M9En+xgsvB+8 X-Received: by 2002:a92:d388:: with SMTP id o8mr11757119ilo.247.1626084181347; Mon, 12 Jul 2021 03:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626084181; cv=none; d=google.com; s=arc-20160816; b=k20RNNDB45b/QFsnvbPL5cICE8/nrYTs3KSAyvCQMtB7sFre6SszqogEXPqQc+IEfV nzxbAVccD6mM0q9ZwaXZcDQz6PGLWMPAl6SsXESfZGyoBrsfh4VyUYDvUu0PIYbHMNcg xv6bvbcyiqyYB0FdtDx93RdFOLkTs/BEOReVu68T5Z9uTObcgiV3qCgMp/f6gRDhnphk BDwgVYVMGenjT3eMQ4roEqakYY0RMFTVDrOAAR/nWW6MSTmDGOpi1//qAUzxOAuvmLR/ vFcq1kPFzAYKoLeFcSCBMqn8jQOTTz9lw322CD5vite14P/tM+IapglUEW3R8O6vvm3A GzFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dHWPxgtJbOKsuVKrZJVe+c+uqzrz0Dt1bwrIgGXPvBM=; b=ll6Ab9tlQql1r0SE09Tw+DjEtW3F8V7OZ1uSvOh/AJiqgcMgfSS36suvDkcvZF8dla XEqsQ7eCta7sQJXVM417yeiVEO7g/7lttrlh1tJDEJV9blzTG9cDaptsTHcMhhkvm7YM P6Y95TORLgp0BvE29Z/WU3C4ulTkk5jc5fOZj5CARp/r7siGiD+TW+5x/zt2eIT5b2V5 UNx+GjZIjgWUNRF/BD3cj2/8IWBZbyUrZMbcUC4JLodSIr1Hvn1qP9bLf1N5VL6jyEJm BI1aYgJLtdVipbwUIht36N4buqV+LMqe8VgOsYX2f7D8OqvrR5PJL1aVzHOvlUeNOTnd U25A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jPb5GWGS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si18603827ilc.93.2021.07.12.03.02.48; Mon, 12 Jul 2021 03:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jPb5GWGS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243125AbhGLHPL (ORCPT + 99 others); Mon, 12 Jul 2021 03:15:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:50488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240243AbhGLGuy (ORCPT ); Mon, 12 Jul 2021 02:50:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 23D6860FD8; Mon, 12 Jul 2021 06:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072485; bh=AoS07RgjTi3ijqRjXt5Qt0J7M7/4IUlk3SGXWrQDLEU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jPb5GWGS1GB6sXcKh7Jq5mNMNX59+8ryUtPh04MoZ6oDgIAMMqkGRmPK8q+aKz++C 29s3xIz/EDvfRuDUM80S1Zf+QcL4UTyt2sBrtqTcAJ0ZxUJl9fhKWtO/b1M/yCzMbx lP3TzeA+mhyABb9i7ooCHgfRiy/Gt0bxDeb/5PYg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huy Duong , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 512/593] eeprom: idt_89hpesx: Put fwnode in matching case during ->probe() Date: Mon, 12 Jul 2021 08:11:12 +0200 Message-Id: <20210712060948.310595494@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit 3f6ee1c095156a74ab2df605af13020f1ce3e600 ] device_get_next_child_node() bumps a reference counting of a returned variable. We have to balance it whenever we return to the caller. Fixes: db15d73e5f0e ("eeprom: idt_89hpesx: Support both ACPI and OF probing") Cc: Huy Duong Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20210607221757.81465-1-andy.shevchenko@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/eeprom/idt_89hpesx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 81c70e5bc168..45a61a1f9e98 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -1161,6 +1161,7 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev) else /* if (!fwnode_property_read_bool(node, "read-only")) */ pdev->eero = false; + fwnode_handle_put(fwnode); dev_info(dev, "EEPROM of %d bytes found by 0x%x", pdev->eesize, pdev->eeaddr); } -- 2.30.2