Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2834499pxv; Mon, 12 Jul 2021 03:06:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymfLy9DXsxn+5+2bSm9luZn8rJp29s8cLXlLEWBlxsmMxVxjDwgkz1O5B09tQUEiQ2Zf5L X-Received: by 2002:a02:9f8e:: with SMTP id a14mr1476911jam.55.1626084387321; Mon, 12 Jul 2021 03:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626084387; cv=none; d=google.com; s=arc-20160816; b=UiX9IH3ucLVenuSCnAxFbwC7xwTDD8+W0ml+ggaVnlND1+ZQh+8Ra/kR3bmHV04ND7 yuLlvGu665DHJ4o8RzGCpgmOfIBJN9mz5WwLFfKPPxSQnrqJac1Qgb15JmD4IuTCHPR/ 9FhoRuzvDvyOHm0uu40FovtA254cF+soVJqnyRh827RXjGvNmZm1LXqvPnpWjfIE4OS9 S1Gb9d3rBZ1nkMfWgpbzUritG+gQiX8/SV0Fe0BL4DGLkguvom8GPDRUhLsm68SEuBRQ rBL5dIjIONm+gXKbAZVQGtZJ+aqFbcK/iB7nnqk4MP+adHWqP32UQuHeFOIenRIOE3Vf ByAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4FFUQGclvTwX5unS2ZypvosxqJO+0sgMQeSuBYsxZp8=; b=HN7i1WPs73kXdgJQYDN835zMRE2sYNVPNR3wT84GqdBbjRPvHEVWrscUQ1hxSOUqsi RKlQpqvjTOPdnlQaZhAZ++59RWonchPIHoCeGVEUlZ2Vnizy6MqL2oDB4CiKyl/s+Tsd +U9f+1uQAR/GBPvcjJsw6NmPXdXC2R8dWWipo2HC41WnBZmB5ChTjZCyYWV3SplxMs// LE25Fvwl4Ue7pnSqHbrakdepTrUYr71BJj6QmqGMPsidosWdBkKFM3PJUIl5BM1ZXBYZ DAbdkO2FoGY4pIglD5U4URlEigdmEu6SV9N9wKE03jVCbXyLt6EAfZnOW0Oe7vj7ZQVh j0lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=edJcSVTt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w10si17853882jad.45.2021.07.12.03.06.15; Mon, 12 Jul 2021 03:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=edJcSVTt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348487AbhGLHlD (ORCPT + 99 others); Mon, 12 Jul 2021 03:41:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:41690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244226AbhGLHKb (ORCPT ); Mon, 12 Jul 2021 03:10:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAE6C613D3; Mon, 12 Jul 2021 07:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626073648; bh=muCR2VCFtcJtBccLINp2D8A5/GS4MuaRyNPoHv62FIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=edJcSVTtjS2HQJ/8QuDKBkBN7sEBQnV3Uu9a1M9DJVr2rKfLQKYHb/O5VIc4wZTxf oAgS0+0WQaTyrqa3mW4c9wWBKzmKxIVkz3BfF1nEk5LpH07rsxpqtUO2uUP4WPnujO 7hTjg1hxHTCRsJQck7iKV7nwZIITm1i12DRo9lLo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Joerg Roedel , Sasha Levin Subject: [PATCH 5.12 313/700] lockdep: Fix wait-type for empty stack Date: Mon, 12 Jul 2021 08:06:36 +0200 Message-Id: <20210712061009.653259437@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra [ Upstream commit f8b298cc39f0619544c607eaef09fd0b2afd10f3 ] Even the very first lock can violate the wait-context check, consider the various IRQ contexts. Fixes: de8f5e4f2dc1 ("lockdep: Introduce wait-type checks") Signed-off-by: Peter Zijlstra (Intel) Tested-by: Joerg Roedel Link: https://lore.kernel.org/r/20210617190313.256987481@infradead.org Signed-off-by: Sasha Levin --- kernel/locking/lockdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index b56c3855756e..8f8cd43ec2a0 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -4692,7 +4692,7 @@ static int check_wait_context(struct task_struct *curr, struct held_lock *next) u8 curr_inner; int depth; - if (!curr->lockdep_depth || !next_inner || next->trylock) + if (!next_inner || next->trylock) return 0; if (!next_outer) -- 2.30.2