Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2835602pxv; Mon, 12 Jul 2021 03:07:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwasZ3Y1I/PMLofGVEGfSZ5jAV5BI8P2VoOmAeWVu1zzCuKIvbSPgEUne9NRzJrPkCrYw7A X-Received: by 2002:a05:6638:4120:: with SMTP id ay32mr44518957jab.120.1626084470701; Mon, 12 Jul 2021 03:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626084470; cv=none; d=google.com; s=arc-20160816; b=DKdDI0QV4Il4rdzWNy1LipmGAXb6III2EzMkDEgVUOBYSfi70VOjDw4vHvUEsSkwF8 UeX4b94tO4YJ/SOUyEUNeZZ2s8v2VIYM/mt4p/VIVA0D5voV+YceEOJmZhYaxhHNveAV BNDxFO0I8/yh6lSNpn3+ZXcNL3YuO/IUl8gKVsqRFyIZ5AZDUf4kqLAFxuoSFnpfrBM0 YsTu9njCdQeKsgrL9QvHhtUU+tB31yEWhdOGinkkP+2hxRlLrH71Kt0yUd6knQJLC2/U /tqttqHcMal8MG7JoZ1jNshQODjx1qADECqiXhy7uEyh9QElsZcKDVfX6MVTQG7qf5lQ a3lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rIWqtwZF8RC2jArYqMiMey6yf36V8J6NLfFIneAHynU=; b=hQDBdntcegvpl20Wh64BUjOdlQgKhsLRrVrgb6V49H8fJAwqOsOQocUDcqcgFFITx3 DOAjQBBsqoHfLdEPbU5B1QLQ6yEHN5rkJPQuSCuGnDtFiTvhc+ZgAc7m6hEwq+zTNiio 60UiHH2TlmUAsTRg++0meG6ETZszBcUqPJ+5dhYbnCwrJpNNwl2NIPRVqoCF6g9ecFSX q4PUfky9MXqda/oLSn5gKu+e0eCwmJLs7DsBhfk0XkzExRjytsbrLiIRXVRERJZMgLnr tKJAiW/tuj7xyonom5FWF7i2/a31D2aiMKv48/o9GPoAsprVujFMLS4iks2N2xzyGFx8 a4LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="q/Iv5oET"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o7si1261927ilc.64.2021.07.12.03.07.38; Mon, 12 Jul 2021 03:07:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="q/Iv5oET"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344312AbhGLHns (ORCPT + 99 others); Mon, 12 Jul 2021 03:43:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:46194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242267AbhGLHLw (ORCPT ); Mon, 12 Jul 2021 03:11:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DF17E610D1; Mon, 12 Jul 2021 07:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626073742; bh=eeSRVt3FkCjt3WDQdxZ1x+xwWrJEEYE+1JUohQRvcN8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q/Iv5oETgr9ibaKN1C6h7UbXv7hhFP2gdo1hooEFCvCABss81AeloLzotffFMSkEG VFYxxy07VihdyeRdr+PujHQOlk66tAaiga93TWC/NgHpORTB4iihcZCib+vwpqqXuA F1jbUW1+fqQgCYEeX82g29LRtQsURjZ04j4B0aPU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kara , Ming Lei , Jens Axboe , Sasha Levin Subject: [PATCH 5.12 342/700] blk-mq: update hctx->dispatch_busy in case of real scheduler Date: Mon, 12 Jul 2021 08:07:05 +0200 Message-Id: <20210712061012.671834133@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ming Lei [ Upstream commit cb9516be7708a2a18ec0a19fe3a225b5b3bc92c7 ] Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") starts to support io batching submission by using hctx->dispatch_busy. However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy in that commit, so fix the issue by updating hctx->dispatch_busy in case of real scheduler. Reported-by: Jan Kara Reviewed-by: Jan Kara Fixes: 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io") Signed-off-by: Ming Lei Link: https://lore.kernel.org/r/20210625020248.1630497-1-ming.lei@redhat.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-mq.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index d06ff908f3d9..6a982a277176 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1223,9 +1223,6 @@ static void blk_mq_update_dispatch_busy(struct blk_mq_hw_ctx *hctx, bool busy) { unsigned int ewma; - if (hctx->queue->elevator) - return; - ewma = hctx->dispatch_busy; if (!ewma && !busy) -- 2.30.2