Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2835725pxv; Mon, 12 Jul 2021 03:08:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvGd9CK0QBpzo0Rb9/aFZrMQ0S39Wkc4auqwX0PjkQGaKpOiEC6LTxY+Z9fngQ3cuxr24X X-Received: by 2002:a02:774a:: with SMTP id g71mr7816144jac.137.1626084482006; Mon, 12 Jul 2021 03:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626084482; cv=none; d=google.com; s=arc-20160816; b=00HEyFlopKpFaNj4Bcr8mJ3jCD9IXLSl8Me7rcD9FffTAMq9nEi/I9jRAvrtOY31hc b+R03vkGsX1uoG/hwR6j7k986twetPZoYfXRaGKQEl4DpbX8qCH6SSpWkvKOOyuwzg4D UPy5pnn/YUUSHJolf+MEBirjdk+8gynb1o068oR/P5O0HWO0giWJtj8a9uC+2lJaTMQo 6uyP19/WDu6ovwh6PYsvLQgM3CBFTozuaDsLPbt61sX8DEgzuqBCTDaNQrIDPwH93D5r S5CD+MeepgUjuc4YS6UxFtuw84/IMcZlMbZsImsScNgolYzf2M+bngg65H87ZNG/tvmK wLRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=i3HomEIjaGxYKDxM8cnRreEdQTwLJFdyenpopLuLQCA=; b=w0DgWANpBY2igqIJLjKH0vZLAVLjZTRw11RIe634f1ZfHG5EjuGMtcFTQZbi/cG8u4 UjU3/HGcVTeAhDLeeX3OfqgPAHaxC0g7Qt9UJI1nXX8hqOZh3cPaU7r67hFK4ZK0wyxj zYcoJvQLu/ebkTz4t4XyTjpeYuYwIO1mUb9c28Ccbx24KXkjogBUwBTCk92qABsHqabg FnRBJXd7D7T0iOUVKhEDBvpaswXoZfWR16r4/eLqmUE+FtDIm3x/xX3glKr6woTlPLxw ktmtzvqygsglv1PkWf43+UAtC3TIaJ5vCYj07ZbB9PoySSIhnNEkZkLRQ7160jcR5y+9 mnSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="oal9p/P1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si18554108ilm.156.2021.07.12.03.07.49; Mon, 12 Jul 2021 03:08:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="oal9p/P1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349353AbhGLHuL (ORCPT + 99 others); Mon, 12 Jul 2021 03:50:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:49268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238090AbhGLHPu (ORCPT ); Mon, 12 Jul 2021 03:15:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 81471611ED; Mon, 12 Jul 2021 07:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626073951; bh=A82D2gszUA5X4xBJWxfKK5uB5nALhnH7McO6HvpiHD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oal9p/P1VMzaYSlJDHFLavMtHZ094IY0O6DoX0Xj61pycAJbv9nzdRKqOGiPxmJhj 7GKZd7o8snKhi/nTNAAJ6gP3yEx0/mYFRKIguo8q2JMPF9zsuVxUECYhYvdmbinYxF f1W5DzqS/w9cB3bTE8Be1l7cSeSxbaajdvcoWTdY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Kalle Valo , Sasha Levin Subject: [PATCH 5.12 414/700] ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n() Date: Mon, 12 Jul 2021 08:08:17 +0200 Message-Id: <20210712061020.425202307@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 515bda1d1e51c64edf2a384a58801f85a80a3f2d ] All error paths but this one 'goto err' in order to release some resources. Fix this. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Christophe JAILLET Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath11k/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 350b7913622c..b55b6289eeb1 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -445,7 +445,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab, if (len < ALIGN(ie_len, 4)) { ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n", ie_id, ie_len, len); - return -EINVAL; + ret = -EINVAL; + goto err; } switch (ie_id) { -- 2.30.2