Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2858034pxv; Mon, 12 Jul 2021 03:45:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzt0iYarisKK2V+IH+pLVsmhKsWQ8CQUoANENj3jMBFg4LC+Z0ZJI5MaqUf0H3H1hw59wLC X-Received: by 2002:a92:6412:: with SMTP id y18mr39714171ilb.158.1626086710260; Mon, 12 Jul 2021 03:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626086710; cv=none; d=google.com; s=arc-20160816; b=SPLTuoEbtPv7GvLLhDDVAYtLZyr7EzRL3cc32d3SJHTNUN0KN4vSx8MV2aKJX2FdSn uNBHpV2GFjEuOfL6JNvjGK1MJtUbZEhH6J6uNleM1Ntihuua9AUYr6AJrq50yz57NakT Po9gngiM11HnpuIe4vHH/dPtLJU+pvPBvzSt88d7sfzYwScN4Ad35ErY6T4yt2v28YOH Qbn58JG/x/UZkXVMGa5SziYEmRnu4mvPiK7femVMz376T32M1cYvuyjRPVkB+ij/YMqY 1+OdoWugT6dgjB6RPTPBOnmIC/TYuNaMZfiBfxa2G7tpyM7UkjRQjGUy9KKTDZ3W2aVI vLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rlULOQy5Lbtwxfz7ELhRtAmgtaPhxbDGZJlw/SOQi8M=; b=rWUvqcKJtObD+dVaAso1HtSH/o5xzpFDFPDbR2HrZbu6THUYH+x+LPvbzuSMoj7P23 5Nvk4rSdJuaPcyDuveuT9b7XxdBVCGFZOxK/9lLfPfQeGn17HAijRqtrYsdNEGp2XJpl 2J1sVZaq/ekProe/UErylTzpN4rpgXy4iiEEdGhnC/SUdBQ5/Cp7WeELAY6O/y4uCLLe kHJG1119ymfA5YGR8SujE8Cy2wFnW7NUizTGJsGzP6oEo9S1mJRADcw06hFIqSg2ev7D fflVyafCCUN8aAx/kBhDGHL6m4NPWno05NyPENynCEmRMvifE81QqIaUHEdvae3VmEB+ zvvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o70JatFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si17394352ild.162.2021.07.12.03.44.58; Mon, 12 Jul 2021 03:45:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o70JatFR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347322AbhGLHtd (ORCPT + 99 others); Mon, 12 Jul 2021 03:49:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243012AbhGLHPB (ORCPT ); Mon, 12 Jul 2021 03:15:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6064C613F5; Mon, 12 Jul 2021 07:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626073903; bh=pMyYFDtfX5GiJ4MJlfvITZ+k3OY0N/qMEdULP036w3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o70JatFRmULYjD4zhCRDD3PGTw7RdzxCI4hReIb2qs7EEKD5IqSTv4IuiftJCv0Vk hQfxEd6lXMBsTFs5WllfCNGJsjEBb8QSKWA7GHYSqaxjSpDsAm/0zCd8lXuF5fiObD uMzysSxmSKmRRoglCArOFXvhCii5EjkfW1OKfPww= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Thomas Zimmermann , Sasha Levin Subject: [PATCH 5.12 355/700] drm/ast: Fix missing conversions to managed API Date: Mon, 12 Jul 2021 08:07:18 +0200 Message-Id: <20210712061014.125858181@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai [ Upstream commit 9ea172a9a3f4a7c5e876469509fc18ddefc7d49d ] The commit 7cbb93d89838 ("drm/ast: Use managed pci functions") converted a few PCI accessors to the managed API and dropped the manual pci_iounmap() calls, but it seems to have forgotten converting pci_iomap() to the managed one. It resulted in the leftover resources after the driver unbind. Let's fix them. Fixes: 7cbb93d89838 ("drm/ast: Use managed pci functions") Signed-off-by: Takashi Iwai Signed-off-by: Thomas Zimmermann Link: https://patchwork.freedesktop.org/patch/msgid/20210421170458.21178-1-tiwai@suse.de Signed-off-by: Sasha Levin --- drivers/gpu/drm/ast/ast_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 0ac3c2039c4b..c29cc7f19863 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c @@ -413,7 +413,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv, pci_set_drvdata(pdev, dev); - ast->regs = pci_iomap(pdev, 1, 0); + ast->regs = pcim_iomap(pdev, 1, 0); if (!ast->regs) return ERR_PTR(-EIO); @@ -429,7 +429,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv, /* "map" IO regs if the above hasn't done so already */ if (!ast->ioregs) { - ast->ioregs = pci_iomap(pdev, 2, 0); + ast->ioregs = pcim_iomap(pdev, 2, 0); if (!ast->ioregs) return ERR_PTR(-EIO); } -- 2.30.2