Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Jul 2021 09:11:30 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Jonathan Cameron <jic23@kernel.org>, lars@metafoo.de,
        sre@kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property
Message-ID: <20210712091130.2096cf23@aktux>
In-Reply-To: <20210711112039.43c4af7b@jic23-huawei>
References: <20210705113637.28908-1-andreas@kemnade.info>
 <20210705113637.28908-3-andreas@kemnade.info>
 <20210711112039.43c4af7b@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 11 Jul 2021 11:20:39 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Mon,  5 Jul 2021 13:36:37 +0200
> Andreas Kemnade <andreas@kemnade.info> wrote:
> 
> > Read voltage_now via IIO and provide the property.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > Reported-by: kernel test robot <lkp@intel.com>  
> Huh?  Seems unlikely it pointed out that this patch was necessary in general.
> If highlighting a particular fix in an earlier version, then state what it was
> in the commit message. Note for fixes that get rolled into patches, it's
> often just mentioned in the change log and we skip the tag because it can
> cause confusion.
> 
The robot found a problem in v1 (missing depends on IIO). It is fixed
now. The message from the bot tells to add a tag. It seems not to make
sense. But probably the bot is also running on public branches (which
will not be rebase) and uses the same message where it actually makes
sense.

I will send a v3 with that tag removed and the other comment addressed.

Regards,
Andreas