Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709104320.101568-1-sumit.garg@linaro.org>
 <20210709104320.101568-5-sumit.garg@linaro.org> <CAD=FV=UqBPV_HQfu++j4yJ2nEN7tzFScnoYQFUhNuXE82OBDhg@mail.gmail.com>
In-Reply-To: <CAD=FV=UqBPV_HQfu++j4yJ2nEN7tzFScnoYQFUhNuXE82OBDhg@mail.gmail.com>
From:   Sumit Garg <sumit.garg@linaro.org>
Date:   Mon, 12 Jul 2021 12:47:06 +0530
Message-ID: <CAFA6WYNeKSi4792tUROxqyz4guinnkLzsO8K61T5UUwjTcxZ2g@mail.gmail.com>
Subject: Re: [PATCH v4 4/4] kdb: Rename members of struct kdbtab_t
To:     Doug Anderson <dianders@chromium.org>
Cc:     kgdb-bugreport@lists.sourceforge.net,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 10 Jul 2021 at 03:07, Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Jul 9, 2021 at 3:44 AM Sumit Garg <sumit.garg@linaro.org> wrote:
> >
> > @@ -711,10 +711,10 @@ static int kdb_defcmd(int argc, const char **argv)
> >                 struct kdb_macro_statement_t *kmc;
> >
> >                 list_for_each_entry(kp, &kdb_cmds_head, list_node) {
> > -                       if (kp->cmd_func == kdb_exec_defcmd) {
> > +                       if (kp->func == kdb_exec_defcmd) {
> >                                 kdb_printf("defcmd %s \"%s\" \"%s\"\n",
> > -                                          kp->cmd_name, kp->cmd_usage,
> > -                                          kp->cmd_help);
> > +                                          kp->name, kp->usage,
> > +                                          kp->help);
>
> The call could probably be squashed down to 2 lines instead of 3 now.
>

Ack.

>
> > @@ -1031,8 +1031,8 @@ int kdb_parse(const char *cmdstr)
> >          */
> >         if (list_entry_is_head(tp, &kdb_cmds_head, list_node)) {
> >                 list_for_each_entry(tp, &kdb_cmds_head, list_node) {
> > -                       if (strncmp(argv[0], tp->cmd_name,
> > -                                   strlen(tp->cmd_name)) == 0)
> > +                       if (strncmp(argv[0], tp->name,
> > +                                   strlen(tp->name)) == 0)
>
> Squash down to one line now that it's shorter.
>

Ack.

>
> The word wrapping isn't really a huge deal to me, though, so:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks,
-Sumit