Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2860489pxv; Mon, 12 Jul 2021 03:48:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlc4M78r2lmD9FOvOA2P7cEvDwMzNCZCifP3G3RIZIdYTETGZRJqbkptJUmEP+c7IsOn9c X-Received: by 2002:a05:6638:2593:: with SMTP id s19mr43695118jat.11.1626086939182; Mon, 12 Jul 2021 03:48:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626086939; cv=none; d=google.com; s=arc-20160816; b=d2CSt/XCCJvHAkFEMpI137mg5WX9P8v720MjuEHfmYa14sNOAcSuoYUaVbYBsV09w/ nLhgbXTPfvFQ8RH3LBDlLedRaFch/Buu6IulilSyvsInRBICF0jVsV2IRP6uhV/qpEoV 3A9EeMF38KDx1i73w/bub2/1vW9VhBOrGz15fk8Jhm/Bkn3fwHgiN0KWXol0mQoVIBVt GyOsnezmFSmwS5dX17FggpG8s2IMxdHdyl0dk1kX1zzvpb35YE5FqAp7est3rSDooPdE eg3Tet3QTJHq97bLmzzKMoXGN4cA9Ajv0QvrcnPYDIWxpI58eZSwQZyAk/zfYZbI5qx+ 39rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cwmmaf/ne0MIofb28dA0DMXKeW83ZOTkDsCC2WgMecU=; b=HV+PrPYe8FJzdy3J8zpJv+aU693k4Zn0oFPC7T8AaRI71Ic29D3MHoURGT4mgF4/iy KPZSczHIyET1Iz3T6n4TS6oQr+3fZ2NVyixmhWdk6+spXLDJFMinVYLsPZsZk+6MfiOq CMid7hjWB14tMICbqFB95KT0iQ4I9nruOeyuh3ojuABS1xh8Mn2liNF4/0Gk3I3ChoyI vppwG28wVSaiRjBw8EkxvK2avnOqJ/K5qNqH9iQMQ1+NVvEAanz4QcuMs3X9w1+1SnyT RFBPUgmPvn3RItCxNTLk+A7xEmed5+N9kzdfNBjCkW67nCS6iq6h4vrPf4RuhrkgtKE3 UiCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LA9LWwah; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v20si11513378jao.88.2021.07.12.03.48.47; Mon, 12 Jul 2021 03:48:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LA9LWwah; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353073AbhGLIBC (ORCPT + 99 others); Mon, 12 Jul 2021 04:01:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:34084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239371AbhGLHWx (ORCPT ); Mon, 12 Jul 2021 03:22:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BEF0B61221; Mon, 12 Jul 2021 07:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626074405; bh=zzTE9mOH1poUGryq9U6dVffdBcfSimbZPtQfVJj3PdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LA9LWwahY3FiUdGn0PGelN9JjezA52WcZl7xKUaA0fCtivNpZJj7IX1EN/vm6rNd0 g5+sKPQ4exbqZerYmlKJwpm0/4o8FlqDzmbvNtYJ5m9CyRK6HDmx8IQVfveoWWliTw Z0AEglotTMHI5fu8DxIXlxCj2AcLRsBqQn/QMQUc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jean-Jacques Hiblot , Andy Shevchenko , Pavel Machek , Sasha Levin Subject: [PATCH 5.12 568/700] leds: class: The -ENOTSUPP should never be seen by user space Date: Mon, 12 Jul 2021 08:10:51 +0200 Message-Id: <20210712061036.550635243@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit 0ac40af86077982a5346dbc9655172d2775d6b08 ] Drop the bogus error code and let of_led_get() to take care about absent of_node. Fixes: e389240ad992 ("leds: Add managed API to get a LED from a device driver") Cc: Jean-Jacques Hiblot Signed-off-by: Andy Shevchenko Signed-off-by: Pavel Machek Signed-off-by: Sasha Levin --- drivers/leds/led-class.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 2e495ff67856..fa3f5f504ff7 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -285,10 +285,6 @@ struct led_classdev *__must_check devm_of_led_get(struct device *dev, if (!dev) return ERR_PTR(-EINVAL); - /* Not using device tree? */ - if (!IS_ENABLED(CONFIG_OF) || !dev->of_node) - return ERR_PTR(-ENOTSUPP); - led = of_led_get(dev->of_node, index); if (IS_ERR(led)) return led; -- 2.30.2