Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2861025pxv; Mon, 12 Jul 2021 03:49:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjkROkVuBPtRtia5aHNEH+ffwST0bYYcEcglAV5K4rZsZOTTsZPLJaA4A0xSt4bdYjTF+c X-Received: by 2002:a5d:8888:: with SMTP id d8mr23530537ioo.170.1626086984164; Mon, 12 Jul 2021 03:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626086984; cv=none; d=google.com; s=arc-20160816; b=Y+fJkejjEe0+C4a0qotVUFsr1Lp5BgzKohzGkQ+xc6OS7Hg2LB7BsTxRXT+4qYIMGc X/ZIyMWtsTDx3qe0flZ1LafJUJcSgU82hAVTu6CvBdZzEpyNNwFG7qFSRkPxmiGpxiCq po1XF5aJfbd4JDMmE15huGiucgmSOpVY+pDCAq7yY5ysg5tdMmAo05f/+BnrfLR50tdD 5HXBGbu4vH4J7EW2mns/IYZliV7KRCIhhZww85np/PrnYio0NKoHPOYHHU4iGLjXE1cj BcHEsNPTvAc4TkCQKV2Gxv3XTGchf2QwLn8NPY4IR9y4CLpu64yt+9E3ewz/4I2m2XRi WxtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zsQJhq+eqdjOkkSAEO3ErktRbLXChO2YBtgdUw41r2U=; b=bVYfeEUbQRcPOlBXgrbF/cScambVDLHtA1VsvEw3Oik2yMg3l7kgJZr1kVBJRc/BC4 EcrZSXWgtIkQGaPafXQrRWYu5XzgZPcJqIvVcKDy96xr55rmyj8nvSyX4yWzhgnkcoM0 9TyUoy7Rq2hwxYq77DJiJjNhtQZ388k8T1G7Fefvh/RuP7QUC4blnwiY9S81GVQTVr9k 9xTIjtPSMOGFke5jYsYm7+knPPhabjJDVHq7Zd4SGu0JS/uD9aJXJ56nHCZ4Oh1Z4GLZ fia5nMaNISTrRt5ozhyQf33ZeGaGvwFE5qw6Kyukh1lcsQqJ/52LlsUnvY2Wo4u6+uVp IE8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sY0RBjOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si18694674ilm.156.2021.07.12.03.49.32; Mon, 12 Jul 2021 03:49:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sY0RBjOr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353492AbhGLIC1 (ORCPT + 99 others); Mon, 12 Jul 2021 04:02:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:34614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343885AbhGLHYX (ORCPT ); Mon, 12 Jul 2021 03:24:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C65C5613EB; Mon, 12 Jul 2021 07:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626074483; bh=pjgfzuIKSAXErgEX1VxWWkwHk0mgV0KIJDJUBjsg+lQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sY0RBjOrQTpJTWzmyaO1jlQGeREbKRkKYJ0GJt2aI530M/ziL5lUlQwaAdf9YVGXE 2hYbU54KTrnVlo3KdjP0OwXh/E6Xa11CiKJ5wOzJVV+swiaLtjrXUaO+6DHcIKiLA3 F8wRqpBt6kpvQtXSaZ1S+eNwARhmRRXwgBfpjnIc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pierre-Louis Bossart , Guennadi Liakhovetski , Bard Liao , Mark Brown , Sasha Levin Subject: [PATCH 5.12 596/700] ASoC: max98373-sdw: add missing memory allocation check Date: Mon, 12 Jul 2021 08:11:19 +0200 Message-Id: <20210712061039.359226556@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart [ Upstream commit 468a272ca49cc4e2f58f3c360643c3f6d313c146 ] We forgot to test that devm_kcalloc doesn't return NULL. Fixes: 349dd23931d1 ('ASoC: max98373: don't access volatile registers in bias level off') Signed-off-by: Pierre-Louis Bossart Reviewed-by: Guennadi Liakhovetski Reviewed-by: Bard Liao Link: https://lore.kernel.org/r/20210607222239.582139-2-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98373-sdw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c index f3a12205cd48..c7a3506046db 100644 --- a/sound/soc/codecs/max98373-sdw.c +++ b/sound/soc/codecs/max98373-sdw.c @@ -787,6 +787,8 @@ static int max98373_init(struct sdw_slave *slave, struct regmap *regmap) max98373->cache = devm_kcalloc(dev, max98373->cache_num, sizeof(*max98373->cache), GFP_KERNEL); + if (!max98373->cache) + return -ENOMEM; for (i = 0; i < max98373->cache_num; i++) max98373->cache[i].reg = max98373_sdw_cache_reg[i]; -- 2.30.2