Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2862496pxv; Mon, 12 Jul 2021 03:52:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzquBKvnkpzLV8X+Vn06eJFaqU7j10ZMfVtJii8GosSqkNS4YQG3Cb4X5STSHEYLGx5qKt8 X-Received: by 2002:a05:6402:17d3:: with SMTP id s19mr17784938edy.49.1626087132235; Mon, 12 Jul 2021 03:52:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626087132; cv=none; d=google.com; s=arc-20160816; b=bmYuTZ+JUKK665zhp1DYlOe8+wpt8g0tZ0ewJrPliejXCPF0NNUAvoPRpWs0uKAWeT TERcEf9DA/sHX29ebUh5ZXnJi87A5rXk1yyrIFqJHhAyNbeuvbAoSf4H0TI+jnIS5dFH bGvHpkGh2oV+HQ4lfZxNhLrsU1Guhhrl+r6PDM3kni/lAe+Vy7uA3y3/AmN33NtWltqA 6+BKQp+nNjwHFMNx/ptfWacI4EzZ5bPxHXq6leh+PqTbUabpHpugXU2xDOP6HvWEAfUs mzKi/mVe25Wn7v4XSHzuxh+baC1gjutd3++0hFjtLPHh398rUb5CnoAjNJhlbYcipEac 9/lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RzgIMqVPkCAy4D8RgS80HRSP3XJLcVw+FQ2P7aIlKsE=; b=pAgZXlj45X5Il0X2FKrQY9nepbRQkqtmPaVivBSRcpby3lID8+1bDFN8fSqWovFTCY hpY2vBo9rbQza9bTU2xNsS4GXJ4ZvbNc0CUpznL9UhgqNSnUZvxyENCRd+oGHUO4k6YK 5AaIV8EKavQGdQmhUdWayDSgRiEbTVL1j1rIgyvUF+sa+oxImw/TzWex2KSc+9qtU1DI G3bvHYU3lQwwmcuaSWSx6FnzweMX4e8a0WNrs32cOAI5phNDJD7wM+N+EuZvI1z4ZoJp Jhq8SChxmZWZQiRbSZut4PK/qtu57nBbgZuxsFLpPJ9V/0EQtoJ0ky6cSGnvuSUh6TdT udoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ADmkQFI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z21si15726149edb.572.2021.07.12.03.51.49; Mon, 12 Jul 2021 03:52:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ADmkQFI1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356280AbhGLIQV (ORCPT + 99 others); Mon, 12 Jul 2021 04:16:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:49338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346954AbhGLHbS (ORCPT ); Mon, 12 Jul 2021 03:31:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 982D86052B; Mon, 12 Jul 2021 07:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626074910; bh=lxWKkhWvx7weg2HTlJ+Tg5ExhWIeVZT0LJuJjQ5AMro=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ADmkQFI1taJRPuG9xappVzXgLjt4KLIMuEPKrLNneViA51be4Q1077VznX3REbRWb RpNsHrsDPC8DJKPniYkKJdD/8KI4gu7gkjyRy8d2mqEkB8gxGCYQJoV5j3WnAWZg5A vGca+NhmWKneNaP93xhYiAVGjEmomSgy0JnQjfpU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Senozhatsky , Takashi Iwai , Max Filippov Subject: [PATCH 5.13 009/800] ALSA: intel8x0: Fix breakage at ac97 clock measurement Date: Mon, 12 Jul 2021 08:00:32 +0200 Message-Id: <20210712060914.420979735@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060912.995381202@linuxfoundation.org> References: <20210712060912.995381202@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit 24d1e49415be546470b20429d748e240d0518b7e upstream. The recent workaround for the wild interrupts in commit c1f0616124c4 ("ALSA: intel8x0: Don't update period unless prepared") leaded to a regression, causing the interrupt storm during ac97 clock measurement at the driver probe. We need to handle the interrupt while the clock measurement as well as the proper PCM streams. Fixes: c1f0616124c4 ("ALSA: intel8x0: Don't update period unless prepared") Reported-and-tested-by: Max Filippov Tested-by: Sergey Senozhatsky Cc: Link: https://lore.kernel.org/r/CAMo8BfKKMQkcsbOQaeEjq_FsJhdK=fn598dvh7YOcZshUSOH=g@mail.gmail.com Link: https://lore.kernel.org/r/20210708090738.1569-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/intel8x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/intel8x0.c +++ b/sound/pci/intel8x0.c @@ -692,7 +692,7 @@ static inline void snd_intel8x0_update(s int status, civ, i, step; int ack = 0; - if (!ichdev->prepared || ichdev->suspended) + if (!(ichdev->prepared || chip->in_measurement) || ichdev->suspended) return; spin_lock_irqsave(&chip->reg_lock, flags);