Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: p7zr5Zd1XTwGvqH0hUKgYKtDidPC/fK2MazwRLDLSKemMGqe/VJIRwnLGemasRgQSiUWVUuT0O
 KvrNrt7wBvP/6Q29cT2Zw2rW6yTPHIGeJLkC74qjRoNqdM3rAtGgBI4ZMg21PrSLFkemaH6Jer
 o+cQQYpTr4Cdld1u1XR0FRv0PHvQMa+w7E1/oy9IJ1SnUK+ixlKL+q2dlViZ82eaIunlycRMCe
 gZcI8NBAz9gpyT9+ksf0hSDcA9GC90mQQnMSmzExnRdHjXo+Ixh1SZRGBXwRcy7bC7RI6Xv5qu
 50A=
IronPort-SDR: PvGWsHkSrNFCzslH2B9CFpxQOFQvjLa2QbKsF5GP8GOu7Yx2nof5MCtUOVCitQDBbIh842k2b5
 CM2QADRgJVBvTO6Qwm3oMtNVwt7yoTu97MmNExKhZ55HYUO1AZRCf8MCJIbxGpivjtX1x+/iPH
 mjCO5CyBgy21N0k6DHqlnXmJJ6EM4112tAhv5qtlTOdtUPb8WJFcMW8vn1VY6pcFNPglvGvrMl
 yiVd1kc6AZW0gh0o/MPxiYKGEXG0a9LxY3YncmPT8tztttdhmiXKOsrzJUTwDCQ6vzo1buKXjv
 sZTMLFcgMb4kNW4xZDFqrUJK
IronPort-SDR: HS/Szc3ouw9r3j2JN40ob0pHNQid2sPOnbLcf35TmP/vOrBMoVmkMy/FMsFelS6q6NbOmA71BP
 4E75Xv6W83xfV1yg8dwM2lAceQt6rKDW7xlNRN2zKH/f5SXaM4cvunrsRBDkW7YsZ7LtVy+NYE
 caygD7LbvmfmHoNt1P9d8EDAsnO/9XFMkphB+z31DNm4UhkuS3kDx+B/sdJujBSYhf2Vw7OS5a
 KVkzR1o4HiLmm2ksLTm7iz/rAN9JLzNYfE5uA5mrHC/ZJP5ncIrfeYTM4dDgWC1tdKtcZgzWqS
 cBY=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <avi.shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>, cang@codeaurora.org,
        stanley.chu@mediatek.com, Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v12 09/12] scsi: ufshpb: Limit the number of inflight map requests
Date:   Mon, 12 Jul 2021 12:50:36 +0300
Message-Id: <20210712095039.8093-10-avri.altman@wdc.com>
In-Reply-To: <20210712095039.8093-1-avri.altman@wdc.com>
References: <20210712095039.8093-1-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

In host control mode the host is the originator of map requests. To not
flood the device with map requests, use a simple throttling mechanism
that limits the number of inflight map requests.

Signed-off-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Daejun Park <daejun7.park@samsung.com>
---
 drivers/scsi/ufs/ufshpb.c | 11 +++++++++++
 drivers/scsi/ufs/ufshpb.h |  1 +
 2 files changed, 12 insertions(+)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 4138f081d1dc..472633052af1 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -21,6 +21,7 @@
 #define READ_TO_MS 1000
 #define READ_TO_EXPIRIES 100
 #define POLLING_INTERVAL_MS 200
+#define THROTTLE_MAP_REQ_DEFAULT 1
 
 /* memory management */
 static struct kmem_cache *ufshpb_mctx_cache;
@@ -742,6 +743,14 @@ static struct ufshpb_req *ufshpb_get_map_req(struct ufshpb_lu *hpb,
 	struct ufshpb_req *map_req;
 	struct bio *bio;
 
+	if (hpb->is_hcm &&
+	    hpb->num_inflight_map_req >= THROTTLE_MAP_REQ_DEFAULT) {
+		dev_info(&hpb->sdev_ufs_lu->sdev_dev,
+			 "map_req throttle. inflight %d throttle %d",
+			 hpb->num_inflight_map_req, THROTTLE_MAP_REQ_DEFAULT);
+		return NULL;
+	}
+
 	map_req = ufshpb_get_req(hpb, srgn->rgn_idx, REQ_OP_SCSI_IN, false);
 	if (!map_req)
 		return NULL;
@@ -756,6 +765,7 @@ static struct ufshpb_req *ufshpb_get_map_req(struct ufshpb_lu *hpb,
 
 	map_req->rb.srgn_idx = srgn->srgn_idx;
 	map_req->rb.mctx = srgn->mctx;
+	hpb->num_inflight_map_req++;
 
 	return map_req;
 }
@@ -765,6 +775,7 @@ static void ufshpb_put_map_req(struct ufshpb_lu *hpb,
 {
 	bio_put(map_req->bio);
 	ufshpb_put_req(hpb, map_req);
+	hpb->num_inflight_map_req--;
 }
 
 static int ufshpb_clear_dirty_bitmap(struct ufshpb_lu *hpb,
diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
index 8309b59c7819..edf565e9036f 100644
--- a/drivers/scsi/ufs/ufshpb.h
+++ b/drivers/scsi/ufs/ufshpb.h
@@ -217,6 +217,7 @@ struct ufshpb_lu {
 	struct ufshpb_req *pre_req;
 	int num_inflight_pre_req;
 	int throttle_pre_req;
+	int num_inflight_map_req;
 	struct list_head lh_pre_req_free;
 	int cur_read_id;
 	int pre_req_min_tr_len;
-- 
2.25.1