Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b079157aede9b8ebb0cb58a6fdabb7d4d2a84e74.camel@redhat.com>
Subject: Re: [PATCH] timers: Fix get_next_timer_interrupt() with no timers
 pending
From:   Nicolas Saenz Julienne <nsaenzju@redhat.com>
To:     Frederic Weisbecker <frederic@kernel.org>
Cc:     He Zhe <zhe.he@windriver.com>, anna-maria@linutronix.de,
        linux-kernel@vger.kernel.org, tglx@linutronix.de
Date:   Mon, 12 Jul 2021 12:19:00 +0200
In-Reply-To: <20210710005243.GA23956@lothringen>
References: <20200723151641.12236-1-frederic@kernel.org>
         <dfbf752e-91db-b128-76a8-98fde4c5d480@windriver.com>
         <20210708153620.GA6716@lothringen>
         <c7a5015a-2b93-17d2-29bc-cd03e40cc09c@windriver.com>
         <20210709084303.GA17239@lothringen>
         <11e85cd8-40ac-09fe-e1fe-0eafa351072c@windriver.com>
         <f520c8b87f56fcda0158853c5127f0488918503e.camel@redhat.com>
         <4409fa71931446d9cabd849431ee0098c9b31292.camel@redhat.com>
         <20210710005243.GA23956@lothringen>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2021-07-10 at 02:52 +0200, Frederic Weisbecker wrote:
> Very good catch.
> 
> And the fix looks good:
> 
>     Acked-by: Frederic Weisbecker <frederic@kernel.org>

Thanks!

> 
> I guess later we can turn this .timers_pending into
> .timers_count and that would spare us the costly call to
> __next_timer_interrupt() up to the last level after the last
> timer is dequeued.

Sound like something manageable. I'll probably have a go at it in the future.

-- 
Nicolás Sáenz