Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2982598pxv; Mon, 12 Jul 2021 06:41:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMaQaaxmuiGmJY8gIjuZDOA0Bdw8jw+loVfd5C2SlL1Pwax9Upq46JWqsk4VGZIZVVoutM X-Received: by 2002:aa7:c1ca:: with SMTP id d10mr13863922edp.107.1626097287324; Mon, 12 Jul 2021 06:41:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626097287; cv=none; d=google.com; s=arc-20160816; b=ASbkFXdPBpy2jXGENvLf/lsiw8T8I9QNxyB42yQuL0ON9OfCWr5rbRDSn/40ZRsHj3 0Gl3ZVnVAqE16+FE9mmQiNd7ggFvIWYQDS2UKGMxdYyQ2PBTQjwQIZfGmxPvmNRAuIps R4eufyzHs1xq1nb5mlFM6786DEZl+k1qvapy0aA/s282eJazA5k5V+VaasID1R4ajmW9 0vlACD5hw4EEuXgj3hb3JrUsu3CaKadc3NbJ2zsSizSB5FrblR/kym45rz+H1rEzGD6w GadeDWfwkVyxmp3qL4i2nx6SX0vfWKgOQNO586JZrp106RJTPujLb98GKsP8IX2eOco0 51bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=kyuy/TMad7cxpm1QRRjZnXAq9QqFJSCLz6h75SVCscI=; b=tRBcAnmINYqJnhffa5BRx2nwcNkywzorBa5UAeARtZz8rUSFfpo9sgZoRMHcABIaNE /+45vqoedT+PLepSz3NsLimm1nuP4lSdvuS2VlZZdZsDgb2PegU1M+YOGolXYNPrzRYl RS+B3vs2aiDLrL/3Gx9pjWSuA22KNpFEWEHVoVCXUc2UR/S4daymqo73BZKMRbIJCw+i J1pKMcACqTkcvu/LgGckcdHn1y72ChBdJY19kWblrdEVHJcnMulyjxPBPGznYPfflClx /xJIRzcv4L2/2osNLzD/YPZsfDpoe54pJ+uNl7BLfK7if5UInzQ4qw3gySgCQ75gAGTe KZBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si16610400edw.18.2021.07.12.06.41.04; Mon, 12 Jul 2021 06:41:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234621AbhGLNm5 (ORCPT + 99 others); Mon, 12 Jul 2021 09:42:57 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:11266 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbhGLNm4 (ORCPT ); Mon, 12 Jul 2021 09:42:56 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GNl9f4df4z1CGb7; Mon, 12 Jul 2021 21:34:30 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 12 Jul 2021 21:40:05 +0800 Received: from localhost (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 12 Jul 2021 21:40:04 +0800 From: YueHaibing To: , , , , <0x7f454c46@gmail.com> CC: , , YueHaibing Subject: [PATCH] xfrm/compat: Fix general protection fault in xfrm_user_rcv_msg_compat() Date: Mon, 12 Jul 2021 21:40:02 +0800 Message-ID: <20210712134002.34048-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In xfrm_user_rcv_msg_compat() if maxtype is not zero and less than XFRMA_MAX, nlmsg_parse_deprecated() do not initialize attrs array fully. xfrm_xlate32() will access uninit 'attrs[i]' while iterating all attrs array. KASAN: probably user-memory-access in range [0x0000000041b58ab0-0x0000000041b58ab7] CPU: 0 PID: 15799 Comm: syz-executor.2 Tainted: G W 5.14.0-rc1-syzkaller #0 RIP: 0010:nla_type include/net/netlink.h:1130 [inline] RIP: 0010:xfrm_xlate32_attr net/xfrm/xfrm_compat.c:410 [inline] RIP: 0010:xfrm_xlate32 net/xfrm/xfrm_compat.c:532 [inline] RIP: 0010:xfrm_user_rcv_msg_compat+0x5e5/0x1070 net/xfrm/xfrm_compat.c:577 [...] Call Trace: xfrm_user_rcv_msg+0x556/0x8b0 net/xfrm/xfrm_user.c:2774 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2504 xfrm_netlink_rcv+0x6b/0x90 net/xfrm/xfrm_user.c:2824 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline] netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1340 netlink_sendmsg+0x86d/0xdb0 net/netlink/af_netlink.c:1929 sock_sendmsg_nosec net/socket.c:702 [inline] Fixes: 5106f4a8acff ("xfrm/compat: Add 32=>64-bit messages translator") Signed-off-by: YueHaibing --- net/xfrm/xfrm_compat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_compat.c b/net/xfrm/xfrm_compat.c index a20aec9d7393..4738660cadea 100644 --- a/net/xfrm/xfrm_compat.c +++ b/net/xfrm/xfrm_compat.c @@ -559,8 +559,8 @@ static struct nlmsghdr *xfrm_user_rcv_msg_compat(const struct nlmsghdr *h32, (h32->nlmsg_flags & NLM_F_DUMP)) return NULL; - err = nlmsg_parse_deprecated(h32, compat_msg_min[type], attrs, - maxtype ? : XFRMA_MAX, policy ? : compat_policy, extack); + err = nlmsg_parse_deprecated(h32, compat_msg_min[type], attrs, XFRMA_MAX, + policy ? : compat_policy, extack); if (err < 0) return ERR_PTR(err); -- 2.20.1