Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709104320.101568-1-sumit.garg@linaro.org>
 <20210709104320.101568-2-sumit.garg@linaro.org> <CAD=FV=W4zMtf-Cmu1KcboJTx=G52rr6Z7hy3LvT3fS76XEbtSw@mail.gmail.com>
 <CAFA6WYOYin8v6y+Pk4mqLHjENkhyGvmX_pqWVvT1TifTahJwYQ@mail.gmail.com>
In-Reply-To: <CAFA6WYOYin8v6y+Pk4mqLHjENkhyGvmX_pqWVvT1TifTahJwYQ@mail.gmail.com>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 12 Jul 2021 06:40:59 -0700
Message-ID: <CAD=FV=XJAAz1a0DJF0f23e+6SPWrNW2EbhWp5xiq40OCLu4m5w@mail.gmail.com>
Subject: Re: [PATCH v4 1/4] kdb: Rename struct defcmd_set to struct kdb_macro_t
To:     Sumit Garg <sumit.garg@linaro.org>
Cc:     kgdb-bugreport@lists.sourceforge.net,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Jul 12, 2021 at 12:13 AM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> > > @@ -671,7 +671,7 @@ static int kdb_exec_defcmd(int argc, const char **argv);
> > >
> > >  static int kdb_defcmd2(const char *cmdstr, const char *argv0)
> > >  {
> > > -       struct defcmd_set *s = defcmd_set + defcmd_set_count - 1;
> > > +       struct kdb_macro_t *s = kdb_macro + kdb_macro_count - 1;
> >
> > I guess the variable "s" was short for "set". Should it change to "m"
> > ? Here and in other places below.
> >
>
> This variable is dropped in patch #3. Can we bear this variable name
> until that patch?

Sure.

-Doug