Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp2987212pxv; Mon, 12 Jul 2021 06:48:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUb1fiBRIlDQP+VDCI+GRfr7Mwq38tOwaUQwjFgS8QJun7MUip119pZ/1Rpm0y8xViF2JG X-Received: by 2002:a17:906:9fc1:: with SMTP id hj1mr51937026ejc.103.1626097684435; Mon, 12 Jul 2021 06:48:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626097684; cv=none; d=google.com; s=arc-20160816; b=e8wMkRCx4LZxvLjT9oj9UkZP5+X4vtPIlGpPxWitKCQ8MVv/gR5J7pbRG1FK426qq5 2g3dwwlTtVUcqHLMD5F5gV3kMdFCSdQybNRNdzjlU0kxbA15ma3403ycKqumOS/dssek HQppqXxViCFX5El9SoSUaCx9HAAN0Cgb7TWMWCkjrrVEcmUB8mqoHF/Ys7b2v2+D6eWi SyWwXkBhfOvwjdQoWvZoU8CXjcelpelrZNlcsfSQY6AYn+WOgVBUPNE06AQbPnhbqwxO N/pQ973BIECcQsUbWS4B5dQQNQCsJfZy+bEiw3rG8PXnMncBBTtHMWY3ldZu/Z9o1Lt4 yV5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hkyO8imEL0+DUAAtvz5beSJFhYFF7552OLN4p+89W8M=; b=FR41WJfgrMK7XzCingaoRGOCvYi+hy1eMB99b5ULvc4bhXGsBtP0Cvq1i+PDHks7Qg tG84FwkmkG/4HRLzonYlIdE9odP432qXggylvcgvHHG1yY/VTrbAXG/gkPuocWD7E/lS JXzPaIfdSToCeJcAh/r8c5p/I6ssmxb4P/5rrA5Ql0PB/Oxi8rQwifrvbYVM8dARKDr8 gTiozcXvYESlMPmUsah4GAsHmIz7Y8RWw3RLB4JpjVTLBzL4nj07kbGerLfW4DQgqb0u ZTMV8YLCYDvFziQZnDV7j9xOWGDLicHaEg4ICS8EOuAy7GTS9gOMtNsQokK3eTBo3MaB 4NFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wtuJcrv7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si14510329edy.460.2021.07.12.06.47.42; Mon, 12 Jul 2021 06:48:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wtuJcrv7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234867AbhGLNta (ORCPT + 99 others); Mon, 12 Jul 2021 09:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234861AbhGLNt3 (ORCPT ); Mon, 12 Jul 2021 09:49:29 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 479C4C0613DD for ; Mon, 12 Jul 2021 06:46:41 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id me13-20020a17090b17cdb0290173bac8b9c9so2235764pjb.3 for ; Mon, 12 Jul 2021 06:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hkyO8imEL0+DUAAtvz5beSJFhYFF7552OLN4p+89W8M=; b=wtuJcrv79psn5e7ySL+Uc5JkU75XGINeXdYj2rN07URLOREmnYlcnk558ONCarvXgm hAOoRDCp533iiso1JfUQ+Au1CsVBVTaDvskwsNVrNAcACJFBKeAX9mQSIp8PWp23MqEQ 826Q42x3fUYBYPzxxjq8GcG+HYP1mzC7XrZgpJizWuHNLZAsrBPHDoHe5Ty2ExvhJmQ/ pwKFzNx6QG224TLCWEi+dujOqyCfuRgW3DDzQrVSrl6w7+crS6tmu5mb/MLPLLGtxXi3 nTWg8x0pGkJOVPP3jCQWoEWdGr4TPJP1aBHBGFbf67RBkWTp15KBPA35nw6J4FmpcMKl GJog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hkyO8imEL0+DUAAtvz5beSJFhYFF7552OLN4p+89W8M=; b=RPNeyEDx62dvnVVUvsJG9imVcR3TKI6UDVeTsOzw9Sq5WYsDpysumJKPgee4DFD2Sx MkHvQKZ89nobOsYNi5qp7rI/DSaZqjIbE7+ag3TbXHao3W8wvXQgMRLlyHo/Rwxt1pSd JGGsNymZ85Ht81m3YplPiPjdmeUeBeGgcpSpoyjl5jHtkEEK2BHpjSqW7FfTMyYO0Um+ 7ZytXN60HafiFYecEiMC1gfICicQRuLzSbpbTO8zscNjv/a4CQ5GrUBDCAUfgZn0AfZc Aqq4/dhFXpgmwjiAIyhaMNKJ5nMjVtcAPRzsdXmaq3GYpHwcL9DEefajNHgLvYQs4vfk u0Mg== X-Gm-Message-State: AOAM5338leX8cBxtK77BoyH4z4mYtW68+l/L6EMJPEMiduhDRw1L0L/9 wy9mjcy+C3X6ilwWrv2YQfUcpQ== X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr14617653pjd.213.1626097600772; Mon, 12 Jul 2021 06:46:40 -0700 (PDT) Received: from localhost.localdomain ([223.178.210.84]) by smtp.gmail.com with ESMTPSA id z13sm835405pfn.94.2021.07.12.06.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 06:46:40 -0700 (PDT) From: Sumit Garg To: kgdb-bugreport@lists.sourceforge.net Cc: daniel.thompson@linaro.org, jason.wessel@windriver.com, dianders@chromium.org, rostedt@goodmis.org, mingo@redhat.com, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v5 0/4] kdb code refactoring Date: Mon, 12 Jul 2021 19:16:16 +0530 Message-Id: <20210712134620.276667-1-sumit.garg@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some more kdb code refactoring related to: - Removal of redundant kdb_register_flags(). - Simplification of kdb defcmd macro logic. Tested with kgdbtest on arm64, doesn't show any regressions. Changes in v5: - Incorporated minor comments from Doug. - Added Doug's review tag. Changes in v4: - Split rename of "defcmd_set" to "kdb_macro" as a separate patch. - Incorporated misc. comments from Doug. - Added a patch that removes redundant prefix "cmd_" from name of members of struct kdbtab_t. Changes in v3: - Split patch into 2 for ease of review. - Get rid of kdb_register_flags() completely via switching all user to register pre-allocated kdb commands. Changes in v2: - Define new structs: kdb_macro_t and kdb_macro_cmd_t instead of modifying existing kdb command struct and struct kdb_subcmd. - Reword commit message. Sumit Garg (4): kdb: Rename struct defcmd_set to struct kdb_macro kdb: Get rid of redundant kdb_register_flags() kdb: Simplify kdb_defcmd macro logic kdb: Rename members of struct kdbtab_t include/linux/kdb.h | 27 +- kernel/debug/kdb/kdb_bp.c | 72 ++-- kernel/debug/kdb/kdb_main.c | 626 +++++++++++++++------------------ kernel/debug/kdb/kdb_private.h | 13 - kernel/trace/trace_kdb.c | 12 +- samples/kdb/kdb_hello.c | 20 +- 6 files changed, 357 insertions(+), 413 deletions(-) -- 2.25.1