Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Jul 2021 16:57:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alexander Gordeev <lasaine@lvk.cs.msu.su>
Cc:     linux-kernel@vger.kernel.org,
        Rodolfo Giometti <giometti@enneenne.com>
Subject: Re: [PATCH v1 1/1] pps: generators: pps_gen_parport: Switch to use
 module_parport_driver()
Message-ID: <YOxKT9FnFPd+491W@smile.fi.intel.com>
References: <20210616143121.46059-1-andriy.shevchenko@linux.intel.com>
 <YMoOVrJ1ETVhRr4F@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YMoOVrJ1ETVhRr4F@kroah.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jun 16, 2021 at 04:44:38PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jun 16, 2021 at 05:31:21PM +0300, Andy Shevchenko wrote:
> > Switch to use module_parport_driver() to reduce boilerplate code.

> > +	pr_info("hrtimer avg error is %ldns\n", hrtimer_error);
> 
> Why is this line needed?  When drivers work properly, they are quiet.
> 
> I know the existing code has it, no reason it needs to stay here, that's
> why we created these macros, to remove the ability for drivers to be
> printing junk like this that they do not need to be printing.

Seems the original authors keeps silent. What do you suggest in this case?
Remove the line and resubmit?

-- 
With Best Regards,
Andy Shevchenko